Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: unpinned social-auth-core (#37550)

Browse Source 
* feat: unpinned social-auth-core

feat: unpinned social-auth-core

* fix: updated to resolve failing tests

* fix: resolved linter errors and failing tests

* fix: updated get_attr signature according to new version
This commit is contained in:
Ahtisham Shahid
2025-10-29 22:16:34 +05:00
committed by GitHub
parent 2a473cffd3
commit dc7db1d3ad
9 changed files with 64 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

55
common/djangoapps/third_party_auth/tests/specs/test_testshib.py
View File

@@ -31,6 +31,7 @@ from openedx.features.enterprise_support.tests.factories import EnterpriseCustom
from .base import IntegrationTestMixin
from common.test.utils import assert_dict_contains_subset
from urllib.parse import urlparse, parse_qs, quote
TESTSHIB_ENTITY_ID = "https://idp.testshib.org/idp/shibboleth"
TESTSHIB_METADATA_URL = "https://mock.testshib.org/metadata/testshib-providers.xml"
@@ -143,10 +144,20 @@ class SamlIntegrationTestUtilities:
os.path.join(os.path.dirname(os.path.dirname(__file__)), "data", "testshib_saml_response.xml")
)
data = utils.prepare_saml_response_from_xml(saml_response_xml)
# Extract RelayState from the redirect to IdP
parsed_url = urlparse(provider_redirect_url)
query_params = parse_qs(parsed_url.query)
relay_state = query_params.get('RelayState', [''])[0]
if relay_state:
data += '&RelayState=' + quote(relay_state) # Append as string to the URL-encoded data
return self.client.post( # lint-amnesty, pylint: disable=no-member
self.complete_url, # lint-amnesty, pylint: disable=no-member
content_type="application/x-www-form-urlencoded",
data=utils.prepare_saml_response_from_xml(saml_response_xml),
data=data,
)
@@ -189,45 +200,6 @@ class TestIndexExceptionTest(SamlIntegrationTestUtilities, IntegrationTestMixin,
return response_data
@ddt.ddt
@utils.skip_unless_thirdpartyauth()
class TestKeyExceptionTest(SamlIntegrationTestUtilities, IntegrationTestMixin, testutil.SAMLTestCase):
"""
To test SAML error handling when presented with missing attributes
"""
TOKEN_RESPONSE_DATA = {
"access_token": "access_token_value",
"expires_in": "expires_in_value",
}
USER_RESPONSE_DATA = {
"lastName": "lastName_value",
"id": "id_value",
"firstName": "firstName_value",
"idp_name": "testshib",
"attributes": {"name_id": "1"},
"session_index": "1",
}
def test_key_error_from_missing_saml_attributes(self):
"""
The `urn:oid:0.9.2342.19200300.100.1.1` attribute is missing,
should throw a specific exception NOT a Key Error
"""
self.provider = self._configure_testshib_provider()
request, strategy = self.get_request_and_strategy(
auth_entry=pipeline.AUTH_ENTRY_LOGIN, redirect_uri="social:complete"
)
with self.assertRaises(IncorrectConfigurationException):
request.backend.auth_complete = MagicMock(return_value=self.fake_auth_complete(strategy))
def get_response_data(self):
"""Gets dict (string -> object) of merged data about the user."""
response_data = dict(self.TOKEN_RESPONSE_DATA)
response_data.update(self.USER_RESPONSE_DATA)
return response_data
@ddt.ddt
@utils.skip_unless_thirdpartyauth()
class TestShibIntegrationTest(SamlIntegrationTestUtilities, IntegrationTestMixin, testutil.SAMLTestCase):
@@ -415,7 +387,8 @@ class TestShibIntegrationTest(SamlIntegrationTestUtilities, IntegrationTestMixin
assert msg.startswith("SAML login %s")
assert action_type == "response"
assert idp_name == self.PROVIDER_IDP_SLUG
assert_dict_contains_subset(self, {"RelayState": idp_name}, response_data)
expected_relay_state = json.dumps({"idp": idp_name, "next": expected_next_url}) # Remove "auth_entry"
assert_dict_contains_subset(self, {"RelayState": expected_relay_state}, response_data)
assert "SAMLResponse" in response_data
assert next_url == expected_next_url
assert "<saml2p:Response" in xml