From dbad75467eca22382d65708ee4353875f415724a Mon Sep 17 00:00:00 2001 From: Waheed Ahmed Date: Mon, 4 Mar 2019 15:24:17 +0500 Subject: [PATCH] Return credit status error if no provider info found. Return credit status error if no provider info found in provider info by id dict. Also add logs to get an idea what is in this dict. LEARNER-6643 --- common/djangoapps/student/views/dashboard.py | 8 ++++++++ openedx/core/djangoapps/credit/models.py | 2 -- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/common/djangoapps/student/views/dashboard.py b/common/djangoapps/student/views/dashboard.py index be52bf8360..fe3f139346 100644 --- a/common/djangoapps/student/views/dashboard.py +++ b/common/djangoapps/student/views/dashboard.py @@ -510,6 +510,14 @@ def _credit_statuses(user, course_enrollments): status["provider_status_url"] = provider_info.get("status_url") status["provider_id"] = provider_id + if not status["provider_name"] and not status["provider_status_url"]: + status["error"] = True + log.error( + u"Could not find credit provider info for [%s] in [%s]. The user will not " + u"be able to see his or her credit request status on the student dashboard.", + provider_id, provider_info_by_id + ) + statuses[course_key] = status return statuses diff --git a/openedx/core/djangoapps/credit/models.py b/openedx/core/djangoapps/credit/models.py index 4da884f872..11693fe9cd 100644 --- a/openedx/core/djangoapps/credit/models.py +++ b/openedx/core/djangoapps/credit/models.py @@ -184,8 +184,6 @@ class CreditProvider(TimeStampedModel): ] cache.set(cls.CREDIT_PROVIDERS_CACHE_KEY, credit_providers) - else: - log.info(u"Found %d credit providers from cache.", len(credit_providers)) if providers_list: credit_providers = [provider for provider in credit_providers if provider['id'] in providers_list]