From f21017d5d611b7dda9db52eb80f1a9cdb70fcac5 Mon Sep 17 00:00:00 2001 From: Feanil Patel Date: Fri, 26 Jul 2019 16:19:55 -0400 Subject: [PATCH 1/3] Remove the configmodel for push notifications. This feature was used to enable/disable push notifications using Parse.com. That service died a few years ago but this was never cleaned up. Cleaning it up as a part of DEPR-41 now that we've removed the code that references this model. --- ...ove_push_notification_configmodel_table.py | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 cms/djangoapps/contentstore/migrations/0004_remove_push_notification_configmodel_table.py diff --git a/cms/djangoapps/contentstore/migrations/0004_remove_push_notification_configmodel_table.py b/cms/djangoapps/contentstore/migrations/0004_remove_push_notification_configmodel_table.py new file mode 100644 index 0000000000..947d4eac93 --- /dev/null +++ b/cms/djangoapps/contentstore/migrations/0004_remove_push_notification_configmodel_table.py @@ -0,0 +1,22 @@ +# -*- coding: utf-8 -*- +# Generated by Django 1.11.22 on 2019-07-26 20:12 +from __future__ import unicode_literals + +from django.db import migrations + + +class Migration(migrations.Migration): + + dependencies = [ + ('contentstore', '0003_remove_assets_page_flag'), + ] + + operations = [ + migrations.RemoveField( + model_name='pushnotificationconfig', + name='changed_by', + ), + migrations.DeleteModel( + name='PushNotificationConfig', + ), + ] From 63f8167dfc4ed4abf0cf7e2326d43b202f79a408 Mon Sep 17 00:00:00 2001 From: Feanil Patel Date: Fri, 26 Jul 2019 16:24:05 -0400 Subject: [PATCH 2/3] Remove the task that is no longer being referenced. Second phase for removing the task. The references to it were removed earlier as a part of DEPR-41 --- cms/djangoapps/contentstore/tasks.py | 9 --------- 1 file changed, 9 deletions(-) diff --git a/cms/djangoapps/contentstore/tasks.py b/cms/djangoapps/contentstore/tasks.py index fe3bf88dfa..3fdad36719 100644 --- a/cms/djangoapps/contentstore/tasks.py +++ b/cms/djangoapps/contentstore/tasks.py @@ -550,15 +550,6 @@ def update_library_index(library_id, triggered_time_isoformat): LOGGER.debug(u'Search indexing successful for library %s', library_id) -@task() -def push_course_update_task(course_key_string, course_subscription_id, course_display_name): - """ - Sends a push notification for a course update. - """ - # TODO Delete once we've done a deploy where nothing is using this. DEPR-41 - pass - - class CourseExportTask(UserTask): # pylint: disable=abstract-method """ Base class for course and library export tasks. From 636af346d58664fa79f1e17e42d8acb8c184849e Mon Sep 17 00:00:00 2001 From: Feanil Patel Date: Fri, 26 Jul 2019 16:27:14 -0400 Subject: [PATCH 3/3] Don't skip the migration test. --- common/djangoapps/util/tests/test_db.py | 1 - 1 file changed, 1 deletion(-) diff --git a/common/djangoapps/util/tests/test_db.py b/common/djangoapps/util/tests/test_db.py index ecfc4c02e2..3df590fc95 100644 --- a/common/djangoapps/util/tests/test_db.py +++ b/common/djangoapps/util/tests/test_db.py @@ -222,7 +222,6 @@ class MigrationTests(TestCase): """ Tests for migrations. """ - @unittest.skip("Migration will delete a model. Need to ship not referencing it first. DEPR-41.") @override_settings(MIGRATION_MODULES={}) def test_migrations_are_in_sync(self): """