style: code cleanups from Steven Burch (#29292)

* chore: update deprecated import from collections

* chore: remove outdated imports from markdown library

as it hasn't been supported since 2.0.3 and we're on 3.x.
This was deprecated at least as early as 2012!

* docs: add docstring and remove lint-amnesty to markdown plugin

* chore: remove deprecated etree import

* style: remove unnecessary-comprehension for sets

* style: resolve a number of amnestied pylint complaints

Co-authored-by: stvn <stvn@mit.edu>

lms/djangoapps/instructor_task/tests/test_base.py

@@ -354,7 +354,7 @@ class TestReportMixin:
         report_path = report_store.path_to(self.course.id, report_csv_filename)
         with report_store.storage.open(report_path) as csv_file:
             # Expand the dict reader generator so we don't lose it's content
-            csv_rows = [row for row in unicodecsv.DictReader(csv_file, encoding='utf-8-sig')]  # lint-amnesty, pylint: disable=unnecessary-comprehension
+            csv_rows = list(unicodecsv.DictReader(csv_file, encoding='utf-8-sig'))
 
             if ignore_other_columns:
                 csv_rows = [

lms/djangoapps/instructor_task/views.py

@@ -13,7 +13,7 @@ from lms.djangoapps.instructor_task.models import PROGRESS
 log = logging.getLogger(__name__)
 
 # return status for completed tasks and tasks in progress
-STATES_WITH_STATUS = [state for state in READY_STATES] + [PROGRESS]  # lint-amnesty, pylint: disable=unnecessary-comprehension
+STATES_WITH_STATUS = list(READY_STATES) + [PROGRESS]
 
 
 def _get_instructor_task_status(task_id):