From d687bc7ba22fa36264283fd91978c4c0ecec9d1d Mon Sep 17 00:00:00 2001 From: Kshitij Sobti Date: Thu, 9 Jun 2022 01:00:31 +0530 Subject: [PATCH] fix: Fix jasmine-jquery package format to avoid checking out over ssh (#30437) The npm package manager seems to try checking out over ssh unless a github dependency is specified with the git user via git@. Checking out over ssh breaks deployments in CI and deployment environments. --- package-lock.json | 8 ++++---- package.json | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package-lock.json b/package-lock.json index 81ddbe0537..47c28e4e19 100644 --- a/package-lock.json +++ b/package-lock.json @@ -89,7 +89,7 @@ "eslint-config-edx-es5": "2.0.0", "eslint-import-resolver-webpack": "0.8.4", "jasmine-core": "2.6.4", - "jasmine-jquery": "git+https://github.com/velesin/jasmine-jquery.git#ebad463d592d3fea00c69f26ea18a930e09c7b58", + "jasmine-jquery": "git+https://git@github.com/velesin/jasmine-jquery.git#ebad463d592d3fea00c69f26ea18a930e09c7b58", "jest": "26.0.0", "jest-enzyme": "6.0.2", "karma": "0.13.22", @@ -23675,7 +23675,7 @@ }, "node_modules/jasmine-jquery": { "version": "2.1.1", - "resolved": "git+ssh://git@github.com/velesin/jasmine-jquery.git#ebad463d592d3fea00c69f26ea18a930e09c7b58", + "resolved": "git+https://git@github.com/velesin/jasmine-jquery.git#ebad463d592d3fea00c69f26ea18a930e09c7b58", "integrity": "sha512-P9aZDwDEAVgAbdHG/ViapRzAUJ6zBSq/4I1lJFluIbrld6Sv6LI+HT2J4dgWqtfaCgIyDnHBHSHiJ/anter7wQ==", "dev": true, "license": "MIT" @@ -56974,10 +56974,10 @@ "dev": true }, "jasmine-jquery": { - "version": "git+ssh://git@github.com/velesin/jasmine-jquery.git#ebad463d592d3fea00c69f26ea18a930e09c7b58", + "version": "git+https://git@github.com/velesin/jasmine-jquery.git#ebad463d592d3fea00c69f26ea18a930e09c7b58", "integrity": "sha512-P9aZDwDEAVgAbdHG/ViapRzAUJ6zBSq/4I1lJFluIbrld6Sv6LI+HT2J4dgWqtfaCgIyDnHBHSHiJ/anter7wQ==", "dev": true, - "from": "jasmine-jquery@git+https://github.com/velesin/jasmine-jquery.git#ebad463d592d3fea00c69f26ea18a930e09c7b58" + "from": "jasmine-jquery@git+https://git@github.com/velesin/jasmine-jquery.git#ebad463d592d3fea00c69f26ea18a930e09c7b58" }, "jest": { "version": "26.0.0", diff --git a/package.json b/package.json index 2f7b92e285..97740991aa 100644 --- a/package.json +++ b/package.json @@ -84,7 +84,7 @@ "eslint-config-edx-es5": "2.0.0", "eslint-import-resolver-webpack": "0.8.4", "jasmine-core": "2.6.4", - "jasmine-jquery": "git+https://github.com/velesin/jasmine-jquery.git#ebad463d592d3fea00c69f26ea18a930e09c7b58", + "jasmine-jquery": "git+https://git@github.com/velesin/jasmine-jquery.git#ebad463d592d3fea00c69f26ea18a930e09c7b58", "jest": "26.0.0", "jest-enzyme": "6.0.2", "karma": "0.13.22",