From d462c73fd854a4cbf9e1b50432ff83e766e67d27 Mon Sep 17 00:00:00 2001 From: Andy Armstrong Date: Wed, 20 Apr 2016 23:43:11 -0400 Subject: [PATCH] Use the UI Toolkit's spec helpers. --- cms/static/coffee/spec/main_spec.coffee | 2 +- .../coffee/spec/models/section_spec.coffee | 2 +- .../coffee/spec/views/assets_spec.coffee | 2 +- .../coffee/spec/views/course_info_spec.coffee | 3 +- .../coffee/spec/views/textbook_spec.coffee | 636 +++++++++--------- .../coffee/spec/views/upload_spec.coffee | 250 +++---- .../spec/views/certificate_details_spec.js | 2 +- .../spec/views/certificate_editor_spec.js | 2 +- .../spec/views/certificate_preview_spec.js | 2 +- .../spec/views/certificates_list_spec.js | 2 +- .../js/spec/utils/drag_and_drop_spec.js | 3 +- .../spec/video/transcripts/videolist_spec.js | 4 +- cms/static/js/spec/views/assets_spec.js | 2 +- cms/static/js/spec/views/container_spec.js | 2 +- .../js/spec/views/group_configuration_spec.js | 29 +- cms/static/js/spec/views/login_studio_spec.js | 3 +- .../js/spec/views/modals/edit_xblock_spec.js | 2 +- .../js/spec/views/paged_container_spec.js | 2 +- .../js/spec/views/pages/container_spec.js | 2 +- .../views/pages/container_subviews_spec.js | 2 +- .../spec/views/pages/course_outline_spec.js | 6 +- .../js/spec/views/pages/course_rerun_spec.js | 5 +- cms/static/js/spec/views/pages/index_spec.js | 4 +- .../js/spec/views/pages/library_users_spec.js | 2 +- cms/static/js/spec/views/paging_spec.js | 16 +- .../js/spec/views/settings/main_spec.js | 7 +- cms/static/js/spec/views/unit_outline_spec.js | 5 +- .../js/spec/views/xblock_editor_spec.js | 2 +- cms/static/js/spec/views/xblock_spec.js | 2 +- .../views/xblock_string_field_editor_spec.js | 2 +- cms/static/js/spec_helpers/edit_helpers.js | 6 +- .../js/spec/components/paginated_view_spec.js | 2 +- .../js/spec/components/paging_footer_spec.js | 2 +- .../js/spec/components/search_field_spec.js | 30 +- .../common/js/spec_helpers/ajax_helpers.js | 207 ------ .../common/js/spec_helpers/spec_helpers.js | 52 -- .../common/js/spec_helpers/view_helpers.js | 2 +- .../js/spec/collections/enrollment_spec.js | 2 +- .../support/js/spec/models/enrollment_spec.js | 2 +- .../js/spec/views/certificates_spec.js | 2 +- .../js/spec/views/enrollment_modal_spec.js | 2 +- .../support/js/spec/views/enrollment_spec.js | 2 +- .../spec/collections/topic_collection_spec.js | 2 +- .../js/spec/views/edit_team_members_spec.js | 2 +- .../teams/js/spec/views/edit_team_spec.js | 2 +- .../js/spec/views/instructor_tools_spec.js | 2 +- .../teams/js/spec/views/my_teams_spec.js | 2 +- .../js/spec/views/team_discussion_spec.js | 2 +- .../views/team_profile_header_actions_spec.js | 2 +- .../teams/js/spec/views/team_profile_spec.js | 2 +- .../teams/js/spec/views/teams_tab_spec.js | 58 +- .../static/teams/js/spec/views/topics_spec.js | 2 +- .../js/spec/api_admin/catalog_preview_spec.js | 2 +- lms/static/js/spec/ccx/schedule_spec.js | 2 +- .../js/spec/commerce/receipt_view_spec.js | 4 +- .../courseware/bookmark_button_view_spec.js | 2 +- .../courseware/bookmarks_list_view_spec.js | 2 +- lms/static/js/spec/dashboard/donation.js | 4 +- .../spec/discovery/discovery_factory_spec.js | 2 +- .../discovery/models/course_directory_spec.js | 2 +- .../discovery/models/search_state_spec.js | 2 +- lms/static/js/spec/edxnotes/helpers.js | 2 +- .../js/spec/edxnotes/plugins/events_spec.js | 2 +- .../plugins/store_error_handler_spec.js | 2 +- .../js/spec/edxnotes/views/note_item_spec.js | 2 +- .../spec/edxnotes/views/notes_factory_spec.js | 2 +- .../js/spec/edxnotes/views/notes_page_spec.js | 3 +- .../views/notes_visibility_factory_spec.js | 21 +- .../js/spec/edxnotes/views/search_box_spec.js | 2 +- .../views/tabs/recent_activity_spec.js | 2 +- .../views/tabs/search_results_spec.js | 3 +- .../js/spec/groups/views/cohorts_spec.js | 3 +- .../certificates_exception_spec.js | 2 +- .../certificates_invalidation_spec.js | 2 +- .../instructor_dashboard/certificates_spec.js | 2 +- .../data_download_spec.js | 5 +- .../student_admin_spec.js | 2 +- lms/static/js/spec/search/search_spec.js | 2 +- .../js/spec/shoppingcart/shoppingcart_spec.js | 2 +- .../js/spec/staff_debug_actions_spec.js | 2 +- .../js/spec/student_account/access_spec.js | 2 +- .../account_settings_factory_spec.js | 6 +- .../account_settings_fields_helpers.js | 6 +- .../account_settings_fields_spec.js | 6 +- .../account_settings_view_spec.js | 6 +- .../spec/student_account/emailoptin_spec.js | 2 +- .../spec/student_account/enrollment_spec.js | 2 +- .../spec/student_account/finish_auth_spec.js | 2 +- .../spec/student_account/hinted_login_spec.js | 2 +- .../js/spec/student_account/login_spec.js | 2 +- .../logistration_factory_spec.js | 2 +- .../student_account/password_reset_spec.js | 2 +- .../js/spec/student_account/register_spec.js | 2 +- .../spec/student_account/shoppingcart_spec.js | 2 +- .../badge_list_container_spec.js | 13 +- lms/static/js/spec/student_profile/helpers.js | 2 +- .../learner_profile_factory_spec.js | 2 +- .../learner_profile_fields_spec.js | 6 +- .../learner_profile_view_spec.js | 2 +- .../spec/verify_student/image_input_spec.js | 2 +- .../make_payment_step_view_ab_testing_spec.js | 2 +- .../make_payment_step_view_spec.js | 2 +- .../review_photos_step_view_spec.js | 2 +- .../verify_student/webcam_photo_view_spec.js | 2 +- lms/static/js/spec/views/fields_helpers.js | 6 +- lms/static/js/spec/views/fields_spec.js | 2 +- .../js/spec/views/file_uploader_spec.js | 2 +- .../js/spec/preview/preview_factory_spec.js | 2 +- package.json | 2 +- 109 files changed, 678 insertions(+), 892 deletions(-) delete mode 100644 common/static/common/js/spec_helpers/ajax_helpers.js delete mode 100644 common/static/common/js/spec_helpers/spec_helpers.js diff --git a/cms/static/coffee/spec/main_spec.coffee b/cms/static/coffee/spec/main_spec.coffee index ed6b6b6d6e..3875df0de5 100644 --- a/cms/static/coffee/spec/main_spec.coffee +++ b/cms/static/coffee/spec/main_spec.coffee @@ -1,4 +1,4 @@ -require ["jquery", "backbone", "coffee/src/main", "common/js/spec_helpers/ajax_helpers", "jquery.cookie"], +require ["jquery", "backbone", "coffee/src/main", "edx-ui-toolkit/js/utils/spec-helpers/ajax-helpers", "jquery.cookie"], ($, Backbone, main, AjaxHelpers) -> describe "CMS", -> it "should initialize URL", -> diff --git a/cms/static/coffee/spec/models/section_spec.coffee b/cms/static/coffee/spec/models/section_spec.coffee index 8e7438f5ba..8a954b50dc 100644 --- a/cms/static/coffee/spec/models/section_spec.coffee +++ b/cms/static/coffee/spec/models/section_spec.coffee @@ -1,4 +1,4 @@ -define ["js/models/section", "common/js/spec_helpers/ajax_helpers", "js/utils/module"], (Section, AjaxHelpers, ModuleUtils) -> +define ["js/models/section", "edx-ui-toolkit/js/utils/spec-helpers/ajax-helpers", "js/utils/module"], (Section, AjaxHelpers, ModuleUtils) -> describe "Section", -> describe "basic", -> beforeEach -> diff --git a/cms/static/coffee/spec/views/assets_spec.coffee b/cms/static/coffee/spec/views/assets_spec.coffee index eea73055c5..e94d166a52 100644 --- a/cms/static/coffee/spec/views/assets_spec.coffee +++ b/cms/static/coffee/spec/views/assets_spec.coffee @@ -1,4 +1,4 @@ -define ["jquery", "common/js/spec_helpers/ajax_helpers", "squire"], +define ["jquery", "edx-ui-toolkit/js/utils/spec-helpers/ajax-helpers", "squire"], ($, AjaxHelpers, Squire) -> assetLibraryTpl = readFixtures('asset-library.underscore') diff --git a/cms/static/coffee/spec/views/course_info_spec.coffee b/cms/static/coffee/spec/views/course_info_spec.coffee index edcf9bf7a7..6e275ca2f7 100644 --- a/cms/static/coffee/spec/views/course_info_spec.coffee +++ b/cms/static/coffee/spec/views/course_info_spec.coffee @@ -1,4 +1,5 @@ -define ["js/views/course_info_handout", "js/views/course_info_update", "js/models/module_info", "js/collections/course_update", "common/js/spec_helpers/ajax_helpers"], +define ["js/views/course_info_handout", "js/views/course_info_update", "js/models/module_info", + "js/collections/course_update", "edx-ui-toolkit/js/utils/spec-helpers/ajax-helpers"], (CourseInfoHandoutsView, CourseInfoUpdateView, ModuleInfo, CourseUpdateCollection, AjaxHelpers) -> describe "Course Updates and Handouts", -> diff --git a/cms/static/coffee/spec/views/textbook_spec.coffee b/cms/static/coffee/spec/views/textbook_spec.coffee index bc855b621d..b4cbdcbf70 100644 --- a/cms/static/coffee/spec/views/textbook_spec.coffee +++ b/cms/static/coffee/spec/views/textbook_spec.coffee @@ -1,339 +1,341 @@ define ["js/models/textbook", "js/models/chapter", "js/collections/chapter", "js/models/course", "js/collections/textbook", "js/views/show_textbook", "js/views/edit_textbook", "js/views/list_textbooks", "js/views/edit_chapter", "common/js/components/views/feedback_prompt", - "common/js/components/views/feedback_notification", "common/js/components/utils/view_utils","common/js/spec_helpers/ajax_helpers", + "common/js/components/views/feedback_notification", "common/js/components/utils/view_utils", + "edx-ui-toolkit/js/utils/spec-helpers/ajax-helpers", "js/spec_helpers/modal_helpers"], -(Textbook, Chapter, ChapterSet, Course, TextbookSet, ShowTextbook, EditTextbook, ListTextbooks, EditChapter, Prompt, Notification, ViewUtils, AjaxHelpers, modal_helpers) -> + (Textbook, Chapter, ChapterSet, Course, TextbookSet, ShowTextbook, EditTextbook, ListTextbooks, EditChapter, + Prompt, Notification, ViewUtils, AjaxHelpers, modal_helpers) -> - describe "ShowTextbook", -> - tpl = readFixtures('show-textbook.underscore') - - beforeEach -> - setFixtures($("