From d45636e2e1fb29aab7ffdb4e094683aca11627f6 Mon Sep 17 00:00:00 2001 From: Kshitij Sobti Date: Wed, 13 Jun 2018 15:39:03 +0530 Subject: [PATCH] Update tests --- .../js/spec/discovery/discovery_factory_spec.js | 3 ++- .../course_search/js/spec/course_search_spec.js | 12 ++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/lms/static/js/spec/discovery/discovery_factory_spec.js b/lms/static/js/spec/discovery/discovery_factory_spec.js index abd779539d..a311938c71 100644 --- a/lms/static/js/spec/discovery/discovery_factory_spec.js +++ b/lms/static/js/spec/discovery/discovery_factory_spec.js @@ -156,8 +156,9 @@ define([ var requests = AjaxHelpers.requests(this); $('.discovery-input').val('asdfasdf'); $('.discovery-submit').trigger('click'); - AjaxHelpers.respondWithError(requests, 404); + AjaxHelpers.respondWithError(requests, 404, {'error': 'some-search-error'}); expect($('#discovery-message')).not.toBeEmpty(); + expect($('#discovery-message')).toContainHtml('some-search-error'); expect($('.courses-listing')).toBeEmpty(); }); diff --git a/openedx/features/course_search/static/course_search/js/spec/course_search_spec.js b/openedx/features/course_search/static/course_search/js/spec/course_search_spec.js index edcf323421..9c05077d8e 100644 --- a/openedx/features/course_search/static/course_search/js/spec/course_search_spec.js +++ b/openedx/features/course_search/static/course_search/js/spec/course_search_spec.js @@ -299,6 +299,16 @@ define([ expect($('.cancel-button')).toBeVisible(); } + function showDefaultErrorMessage() { + this.form.showErrorMessage(); + expect(this.form.$message).toContainHtml('There was an error, try searching again.'); + } + + function showRemoteErrorMessage() { + this.form.showErrorMessage('some-error-message'); + expect(this.form.$message).toContainHtml('some-error-message'); + } + function triggersSearchEvent() { var term = 'search string'; $('.search-field').val(term); @@ -341,6 +351,8 @@ define([ }); it('trims input string', trimsInputString); it('handles calls to doSearch', doesSearch); + it('displays default message on error', showDefaultErrorMessage); + it('displays provided message on error', showRemoteErrorMessage); it('triggers a search event and changes to active state', triggersSearchEvent); it('clears search when clicking on cancel button', clearsSearchOnCancel); it('clears search when search box is empty', clearsSearchOnEmpty);