Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: default grade designations configurable from settings (#32406)

Browse Source
This commit is contained in:
Kaustav Banerjee
2024-05-08 01:14:03 +05:30
committed by GitHub
parent e94b942ec9
commit d43a2f73eb
9 changed files with 41 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
cms/djangoapps/contentstore/rest_api/v1/serializers/grading.py
View File

@@ -40,3 +40,6 @@ class CourseGradingSerializer(serializers.Serializer):
course_details = CourseGradingModelSerializer()
show_credit_eligibility = serializers.BooleanField()
is_credit_course = serializers.BooleanField()
default_grade_designations = serializers.ListSerializer(
child=serializers.CharField()
)

3
cms/djangoapps/contentstore/rest_api/v1/views/grading.py
View File

@@ -85,7 +85,8 @@ class CourseGradingView(DeveloperErrorViewMixin, APIView):
"minimum_grade_credit": 0.7
},
"show_credit_eligibility": false,
"is_credit_course": true
"is_credit_course": true,
"default_grade_designations": ["A","B","C","D"]
}
```
"""

11
cms/djangoapps/contentstore/rest_api/v1/views/tests/test_grading.py
View File

@@ -42,11 +42,22 @@ class CourseGradingViewTest(CourseTestCase, PermissionAccessMixin):
"course_details": grading_data.__dict__,
"show_credit_eligibility": False,
"is_credit_course": False,
"default_grade_designations": ['A', 'B', 'C', 'D'],
}
self.assertEqual(response.status_code, status.HTTP_200_OK)
self.assertDictEqual(expected_response, response.data)
@patch("django.conf.settings.DEFAULT_GRADE_DESIGNATIONS", ['A', 'B'])
def test_default_grade_designations_setting(self):
"""
Check that DEFAULT_GRADE_DESIGNATIONS setting reflects correctly in API.
"""
response = self.client.get(self.url)
self.assertEqual(response.status_code, status.HTTP_200_OK)
self.assertEqual(['A', 'B'], response.data["default_grade_designations"])
@patch.dict("django.conf.settings.FEATURES", {"ENABLE_CREDIT_ELIGIBILITY": True})
def test_credit_eligibility_setting(self):
"""

3
cms/djangoapps/contentstore/utils.py
View File

@@ -1486,7 +1486,8 @@ def get_course_grading(course_key):
'grading_url': reverse_course_url('grading_handler', course_key),
'is_credit_course': is_credit_course(course_key),
'mfe_proctored_exam_settings_url': get_proctored_exam_settings_url(course_key),
'course_assignment_lists': dict(course_assignment_lists)
'course_assignment_lists': dict(course_assignment_lists),
'default_grade_designations': settings.DEFAULT_GRADE_DESIGNATIONS
}
return grading_context