diff --git a/cms/djangoapps/contentstore/views/course.py b/cms/djangoapps/contentstore/views/course.py index 70ebc65893..c71197892b 100644 --- a/cms/djangoapps/contentstore/views/course.py +++ b/cms/djangoapps/contentstore/views/course.py @@ -78,7 +78,7 @@ from openedx.features.content_type_gating.partitions import CONTENT_TYPE_GATING_ from openedx.features.course_experience.waffle import ENABLE_COURSE_ABOUT_SIDEBAR_HTML from xmodule.contentstore.content import StaticContent # lint-amnesty, pylint: disable=wrong-import-order from xmodule.course_block import CourseBlock, DEFAULT_START_DATE, CourseFields # lint-amnesty, pylint: disable=wrong-import-order -from xmodule.error_module import ErrorBlock # lint-amnesty, pylint: disable=wrong-import-order +from xmodule.error_block import ErrorBlock # lint-amnesty, pylint: disable=wrong-import-order from xmodule.modulestore import EdxJSONEncoder # lint-amnesty, pylint: disable=wrong-import-order from xmodule.modulestore.django import modulestore # lint-amnesty, pylint: disable=wrong-import-order from xmodule.modulestore.exceptions import DuplicateCourseError, ItemNotFoundError # lint-amnesty, pylint: disable=wrong-import-order diff --git a/common/djangoapps/student/tests/test_course_listing.py b/common/djangoapps/student/tests/test_course_listing.py index e93ec5f817..726de56e9c 100644 --- a/common/djangoapps/student/tests/test_course_listing.py +++ b/common/djangoapps/student/tests/test_course_listing.py @@ -17,7 +17,7 @@ from common.djangoapps.student.roles import GlobalStaff from common.djangoapps.student.tests.factories import UserFactory from common.djangoapps.student.views import get_course_enrollments from common.djangoapps.util.milestones_helpers import get_pre_requisite_courses_not_completed, set_prerequisite_courses -from xmodule.error_module import ErrorBlock # lint-amnesty, pylint: disable=wrong-import-order +from xmodule.error_block import ErrorBlock # lint-amnesty, pylint: disable=wrong-import-order from xmodule.modulestore import ModuleStoreEnum # lint-amnesty, pylint: disable=wrong-import-order from xmodule.modulestore.django import modulestore # lint-amnesty, pylint: disable=wrong-import-order from xmodule.modulestore.tests.django_utils import ModuleStoreTestCase # lint-amnesty, pylint: disable=wrong-import-order diff --git a/lms/djangoapps/ccx/models.py b/lms/djangoapps/ccx/models.py index 46400b5357..21f0136f07 100644 --- a/lms/djangoapps/ccx/models.py +++ b/lms/djangoapps/ccx/models.py @@ -14,7 +14,7 @@ from lazy import lazy from opaque_keys.edx.django.models import CourseKeyField, UsageKeyField from pytz import utc -from xmodule.error_module import ErrorBlock +from xmodule.error_block import ErrorBlock from xmodule.modulestore.django import modulestore log = logging.getLogger("edx.ccx") diff --git a/lms/djangoapps/courseware/access.py b/lms/djangoapps/courseware/access.py index b38a0230d2..0e9b43281c 100644 --- a/lms/djangoapps/courseware/access.py +++ b/lms/djangoapps/courseware/access.py @@ -62,7 +62,7 @@ from common.djangoapps.util.milestones_helpers import ( is_prerequisite_courses_enabled ) from xmodule.course_block import CATALOG_VISIBILITY_ABOUT, CATALOG_VISIBILITY_CATALOG_AND_ABOUT, CourseBlock # lint-amnesty, pylint: disable=wrong-import-order -from xmodule.error_module import ErrorBlock # lint-amnesty, pylint: disable=wrong-import-order +from xmodule.error_block import ErrorBlock # lint-amnesty, pylint: disable=wrong-import-order from xmodule.partitions.partitions import NoSuchUserPartitionError, NoSuchUserPartitionGroupError # lint-amnesty, pylint: disable=wrong-import-order log = logging.getLogger(__name__) diff --git a/lms/djangoapps/courseware/rules.py b/lms/djangoapps/courseware/rules.py index 8f4d0de981..8202418f6f 100644 --- a/lms/djangoapps/courseware/rules.py +++ b/lms/djangoapps/courseware/rules.py @@ -20,7 +20,7 @@ from openedx.core.djangoapps.enrollments.api import is_enrollment_valid_for_proc from common.djangoapps.student.models import CourseAccessRole from common.djangoapps.student.roles import CourseRole, OrgRole from xmodule.course_block import CourseBlock # lint-amnesty, pylint: disable=wrong-import-order -from xmodule.error_module import ErrorBlock # lint-amnesty, pylint: disable=wrong-import-order +from xmodule.error_block import ErrorBlock # lint-amnesty, pylint: disable=wrong-import-order from .access import has_access diff --git a/lms/djangoapps/courseware/tests/tests.py b/lms/djangoapps/courseware/tests/tests.py index 86e5a53bbb..c815f7eadb 100644 --- a/lms/djangoapps/courseware/tests/tests.py +++ b/lms/djangoapps/courseware/tests/tests.py @@ -12,7 +12,7 @@ from opaque_keys.edx.keys import CourseKey from lms.djangoapps.courseware.tests.helpers import LoginEnrollmentTestCase from lms.djangoapps.lms_xblock.field_data import LmsFieldData -from xmodule.error_module import ErrorBlock # lint-amnesty, pylint: disable=wrong-import-order +from xmodule.error_block import ErrorBlock # lint-amnesty, pylint: disable=wrong-import-order from xmodule.modulestore.django import modulestore # lint-amnesty, pylint: disable=wrong-import-order from xmodule.modulestore.tests.django_utils import TEST_DATA_MIXED_MODULESTORE, ModuleStoreTestCase # lint-amnesty, pylint: disable=wrong-import-order from xmodule.modulestore.tests.factories import ToyCourseFactory # lint-amnesty, pylint: disable=wrong-import-order diff --git a/openedx/core/djangoapps/content/course_overviews/models.py b/openedx/core/djangoapps/content/course_overviews/models.py index 0c0e574ea4..14eb3095a6 100644 --- a/openedx/core/djangoapps/content/course_overviews/models.py +++ b/openedx/core/djangoapps/content/course_overviews/models.py @@ -29,7 +29,7 @@ from openedx.core.lib.cache_utils import request_cached, RequestCache from common.djangoapps.static_replace.models import AssetBaseUrlConfig from xmodule import block_metadata_utils, course_metadata_utils # lint-amnesty, pylint: disable=wrong-import-order from xmodule.course_block import DEFAULT_START_DATE, CourseBlock # lint-amnesty, pylint: disable=wrong-import-order -from xmodule.error_module import ErrorBlock # lint-amnesty, pylint: disable=wrong-import-order +from xmodule.error_block import ErrorBlock # lint-amnesty, pylint: disable=wrong-import-order from xmodule.modulestore.django import modulestore # lint-amnesty, pylint: disable=wrong-import-order from xmodule.tabs import CourseTab # lint-amnesty, pylint: disable=wrong-import-order diff --git a/openedx/core/djangoapps/content/course_overviews/tests/test_course_overviews.py b/openedx/core/djangoapps/content/course_overviews/tests/test_course_overviews.py index 1f3650ff1e..ea2ad0753b 100644 --- a/openedx/core/djangoapps/content/course_overviews/tests/test_course_overviews.py +++ b/openedx/core/djangoapps/content/course_overviews/tests/test_course_overviews.py @@ -33,7 +33,7 @@ from xmodule.course_block import ( # lint-amnesty, pylint: disable=wrong-import CATALOG_VISIBILITY_CATALOG_AND_ABOUT, CATALOG_VISIBILITY_NONE ) -from xmodule.error_module import ErrorBlock # lint-amnesty, pylint: disable=wrong-import-order +from xmodule.error_block import ErrorBlock # lint-amnesty, pylint: disable=wrong-import-order from xmodule.modulestore import ModuleStoreEnum # lint-amnesty, pylint: disable=wrong-import-order from xmodule.modulestore.django import modulestore # lint-amnesty, pylint: disable=wrong-import-order from xmodule.modulestore.tests.django_utils import ModuleStoreTestCase # lint-amnesty, pylint: disable=wrong-import-order diff --git a/setup.py b/setup.py index fd2db8a663..939e5e9df6 100644 --- a/setup.py +++ b/setup.py @@ -16,7 +16,7 @@ XBLOCKS = [ "custom_tag_template = xmodule.template_module:CustomTagTemplateBlock", "discuss = xmodule.template_module:TranslateCustomTagBlock", "discussion = xmodule.discussion_block:DiscussionXBlock", - "error = xmodule.error_module:ErrorBlock", + "error = xmodule.error_block:ErrorBlock", "hidden = xmodule.hidden_module:HiddenDescriptor", "html = xmodule.html_module:HtmlBlock", "image = xmodule.template_module:TranslateCustomTagBlock", diff --git a/xmodule/error_module.py b/xmodule/error_block.py similarity index 99% rename from xmodule/error_module.py rename to xmodule/error_block.py index 012e667d3a..d74cb59304 100644 --- a/xmodule/error_module.py +++ b/xmodule/error_block.py @@ -113,7 +113,7 @@ class ErrorBlock( }) return system.construct_xblock_from_class( cls, - # The error module doesn't use scoped data, and thus doesn't need + # The error block doesn't use scoped data, and thus doesn't need # real scope keys ScopeIds(None, 'error', location, location), field_data, diff --git a/xmodule/modulestore/inheritance.py b/xmodule/modulestore/inheritance.py index bf05a192ec..315ce6e509 100644 --- a/xmodule/modulestore/inheritance.py +++ b/xmodule/modulestore/inheritance.py @@ -303,7 +303,7 @@ def inherit_metadata(descriptor, inherited_data): """ try: descriptor.xblock_kvs.inherited_settings = inherited_data - except AttributeError: # the kvs doesn't have inherited_settings probably b/c it's an error module + except AttributeError: # the kvs doesn't have inherited_settings probably b/c it's an error block pass diff --git a/xmodule/modulestore/mongo/base.py b/xmodule/modulestore/mongo/base.py index de49043e5b..e832a60876 100644 --- a/xmodule/modulestore/mongo/base.py +++ b/xmodule/modulestore/mongo/base.py @@ -36,7 +36,7 @@ from xblock.runtime import KvsFieldData from xmodule.assetstore import AssetMetadata, CourseAssetsFromStorage from xmodule.course_block import CourseSummary -from xmodule.error_module import ErrorBlock +from xmodule.error_block import ErrorBlock from xmodule.errortracker import exc_info_to_str, null_error_tracker from xmodule.exceptions import HeartbeatFailure from xmodule.mako_module import MakoDescriptorSystem diff --git a/xmodule/modulestore/split_mongo/caching_descriptor_system.py b/xmodule/modulestore/split_mongo/caching_descriptor_system.py index f951e5b000..b96dee278e 100644 --- a/xmodule/modulestore/split_mongo/caching_descriptor_system.py +++ b/xmodule/modulestore/split_mongo/caching_descriptor_system.py @@ -9,7 +9,7 @@ from opaque_keys.edx.locator import BlockUsageLocator, DefinitionLocator, LocalI from xblock.fields import ScopeIds from xblock.runtime import KeyValueStore, KvsFieldData -from xmodule.error_module import ErrorBlock +from xmodule.error_block import ErrorBlock from xmodule.errortracker import exc_info_to_str from xmodule.library_tools import LibraryToolsService from xmodule.mako_module import MakoDescriptorSystem diff --git a/xmodule/modulestore/split_mongo/split.py b/xmodule/modulestore/split_mongo/split.py index 5010bf443f..14557a9d85 100644 --- a/xmodule/modulestore/split_mongo/split.py +++ b/xmodule/modulestore/split_mongo/split.py @@ -80,7 +80,7 @@ from xblock.fields import Reference, ReferenceList, ReferenceValueDict, Scope from xmodule.assetstore import AssetMetadata from xmodule.course_block import CourseSummary -from xmodule.error_module import ErrorBlock +from xmodule.error_block import ErrorBlock from xmodule.errortracker import null_error_tracker from xmodule.library_content_module import LibrarySummary from xmodule.modulestore import ( diff --git a/xmodule/modulestore/tests/test_xml.py b/xmodule/modulestore/tests/test_xml.py index 9b59cabb46..b2c10157fc 100644 --- a/xmodule/modulestore/tests/test_xml.py +++ b/xmodule/modulestore/tests/test_xml.py @@ -48,7 +48,7 @@ class TestXMLModuleStore(TestCase): with pytest.raises(UnicodeDecodeError): xml.decode('ascii') - # Load the course, but don't make error modules. This will succeed, + # Load the course, but don't make error blocks. This will succeed, # but will record the errors. modulestore = XMLModuleStore( DATA_DIR, diff --git a/xmodule/modulestore/xml.py b/xmodule/modulestore/xml.py index 0830281ba4..c7e74f180c 100644 --- a/xmodule/modulestore/xml.py +++ b/xmodule/modulestore/xml.py @@ -23,7 +23,7 @@ from xblock.fields import ScopeIds from xblock.runtime import DictKeyValueStore from common.djangoapps.util.monitoring import monitor_import_failure -from xmodule.error_module import ErrorBlock +from xmodule.error_block import ErrorBlock from xmodule.errortracker import exc_info_to_str, make_error_tracker from xmodule.mako_module import MakoDescriptorSystem from xmodule.modulestore import COURSE_ROOT, LIBRARY_ROOT, ModuleStoreEnum, ModuleStoreReadBase diff --git a/xmodule/tests/test_conditional.py b/xmodule/tests/test_conditional.py index 00abe5f340..c8a59efb4e 100644 --- a/xmodule/tests/test_conditional.py +++ b/xmodule/tests/test_conditional.py @@ -14,7 +14,7 @@ from xblock.field_data import DictFieldData from xblock.fields import ScopeIds from xmodule.conditional_block import ConditionalBlock -from xmodule.error_module import ErrorBlock +from xmodule.error_block import ErrorBlock from xmodule.modulestore.xml import CourseLocationManager, ImportSystem, XMLModuleStore from xmodule.tests import DATA_DIR, get_test_descriptor_system, get_test_system from xmodule.tests.xml import XModuleXmlImportTest diff --git a/xmodule/tests/test_error_module.py b/xmodule/tests/test_error_block.py similarity index 96% rename from xmodule/tests/test_error_module.py rename to xmodule/tests/test_error_block.py index 448152501e..5df3bcb61f 100644 --- a/xmodule/tests/test_error_module.py +++ b/xmodule/tests/test_error_block.py @@ -7,7 +7,7 @@ import unittest from opaque_keys.edx.locator import CourseLocator -from xmodule.error_module import ErrorBlock +from xmodule.error_block import ErrorBlock from xmodule.modulestore.xml import CourseLocationManager from xmodule.tests import get_test_system from xmodule.x_module import STUDENT_VIEW