From cee0eb8779f32351fa2fae828dba045e9f161866 Mon Sep 17 00:00:00 2001
From: umar-nawaz <h.umarnawaz@gmail.com>
Date: Wed, 1 Mar 2017 16:02:32 +0500
Subject: [PATCH] a11y footer links to ul

---
 lms/static/sass/shared/_footer-edx.scss  |  6 ++++--
 themes/edx.org/lms/templates/footer.html | 16 ++++++++++++----
 2 files changed, 16 insertions(+), 6 deletions(-)

diff --git a/lms/static/sass/shared/_footer-edx.scss b/lms/static/sass/shared/_footer-edx.scss
index 162ada538d..1ef6d748d2 100644
--- a/lms/static/sass/shared/_footer-edx.scss
+++ b/lms/static/sass/shared/_footer-edx.scss
@@ -35,7 +35,7 @@ footer#footer-edx-v3 {
 
   .site-nav,
   .legal-notices {
-    a {
+    li {
       @include font-size(14);
       @include line-height(14);
       @include margin-right(20px);
@@ -83,7 +83,9 @@ footer#footer-edx-v3 {
       width: 100%;
     }
   }
-  
+
+  .about-links,
+  .legal-links,
   .social-media-links,
   .mobile-app-links {
       @extend %ui-no-list;
diff --git a/themes/edx.org/lms/templates/footer.html b/themes/edx.org/lms/templates/footer.html
index c849aa451a..25d26c3d2d 100644
--- a/themes/edx.org/lms/templates/footer.html
+++ b/themes/edx.org/lms/templates/footer.html
@@ -27,14 +27,22 @@
 
       <div class="site-details">
           <nav class="site-nav" aria-label="${_("About edX")}">
-              % for link in footer["navigation_links"]:
-              <a href="${link['url']}">${link['title']}</a>
-              % endfor
+            <ul class="about-links">
+                % for link in footer["navigation_links"]:
+                <li class="list-item">
+                  <a href="${link['url']}">${link['title']}</a>
+                </li>
+                % endfor
+            </ul>
           </nav>
           <nav class="legal-notices" aria-label="${_("Legal")}">
+            <ul class="legal-links">
               % for link in footer["legal_links"]:
-              <a href="${link['url']}">${link['title']}</a>
+                <li class="list-item">
+                  <a href="${link['url']}">${link['title']}</a>
+                </li>
               % endfor
+            </ul>
           </nav>
           <p class="copyright">${_(
           u"\u00A9 2012-{year} edX Inc.  All rights reserved except where noted.  "