From ce42ba56559bc5d54005e76a9891aa57d81d52bd Mon Sep 17 00:00:00 2001 From: Christine Lytwynec Date: Mon, 5 Oct 2015 12:05:21 -0400 Subject: [PATCH] move existing a11y tests to bokchoy test folder --- .../test/acceptance/accessibility/__init__.py | 0 .../accessibility/test_lms_dashboard_a11y.py | 28 ----------------- .../accessibility/test_studio_library_a11y.py | 30 ------------------- .../tests/lms/test_lms_dashboard.py | 23 ++++++++++++++ .../tests/studio/test_studio_library.py | 23 ++++++++++++++ scripts/accessibility-tests.sh | 2 +- scripts/generic-ci-tests.sh | 2 +- 7 files changed, 48 insertions(+), 60 deletions(-) delete mode 100644 common/test/acceptance/accessibility/__init__.py delete mode 100644 common/test/acceptance/accessibility/test_lms_dashboard_a11y.py delete mode 100644 common/test/acceptance/accessibility/test_studio_library_a11y.py diff --git a/common/test/acceptance/accessibility/__init__.py b/common/test/acceptance/accessibility/__init__.py deleted file mode 100644 index e69de29bb2..0000000000 diff --git a/common/test/acceptance/accessibility/test_lms_dashboard_a11y.py b/common/test/acceptance/accessibility/test_lms_dashboard_a11y.py deleted file mode 100644 index 45304ae506..0000000000 --- a/common/test/acceptance/accessibility/test_lms_dashboard_a11y.py +++ /dev/null @@ -1,28 +0,0 @@ -""" -Accessibility tests for LMS dashboard page. - -Run just this test with: -SELENIUM_BROWSER=phantomjs paver test_bokchoy -d accessibility -t test_lms_dashboard_a11y.py -""" -from ..tests.lms.test_lms_dashboard import BaseLmsDashboardTest - - -class LmsDashboardAxsTest(BaseLmsDashboardTest): - """ - Class to test lms student dashboard accessibility. - """ - - def test_dashboard_course_listings_axs(self): - """ - Test the accessibility of the course listings - """ - course_listings = self.dashboard_page.get_course_listings() - self.assertEqual(len(course_listings), 1) - - # There are several existing color contrast errors on this page, - # we will ignore this error in the test until we fix them. - self.dashboard_page.a11y_audit.config.set_rules({ - "ignore": ['color-contrast'], - }) - - self.dashboard_page.a11y_audit.check_for_accessibility_errors() diff --git a/common/test/acceptance/accessibility/test_studio_library_a11y.py b/common/test/acceptance/accessibility/test_studio_library_a11y.py deleted file mode 100644 index a4a86e1f43..0000000000 --- a/common/test/acceptance/accessibility/test_studio_library_a11y.py +++ /dev/null @@ -1,30 +0,0 @@ -""" -Accessibility tests for Studio Library pages. - -Run just this test with: -SELENIUM_BROWSER=phantomjs paver test_bokchoy -d accessibility -t test_studio_library_a11y.py -""" -from ..tests.studio.base_studio_test import StudioLibraryTest -from ..pages.studio.library import LibraryEditPage - - -class StudioLibraryAxsTest(StudioLibraryTest): - """ - Class to test Studio pages accessibility. - """ - - def test_lib_edit_page_axs(self): - """ - Check accessibility of LibraryEditPage. - """ - lib_page = LibraryEditPage(self.browser, self.library_key) - lib_page.visit() - lib_page.wait_until_ready() - - # There are several existing color contrast errors on this page, - # we will ignore this error in the test until we fix them. - lib_page.a11y_audit.config.set_rules({ - "ignore": ['color-contrast'], - }) - - lib_page.a11y_audit.check_for_accessibility_errors() diff --git a/common/test/acceptance/tests/lms/test_lms_dashboard.py b/common/test/acceptance/tests/lms/test_lms_dashboard.py index 8373360434..4e8cbf599c 100644 --- a/common/test/acceptance/tests/lms/test_lms_dashboard.py +++ b/common/test/acceptance/tests/lms/test_lms_dashboard.py @@ -3,6 +3,7 @@ End-to-end tests for the main LMS Dashboard (aka, Student Dashboard). """ import datetime +from nose.plugins.attrib import attr from ..helpers import UniqueCourseTest from ...fixtures.course import CourseFixture @@ -217,3 +218,25 @@ class LmsDashboardPageTest(BaseLmsDashboardTest): # Test that proper course date with 'starts' message is displayed if a course is about to start in future, # and course starts within 5 days self.assertEqual(course_date, expected_course_date) + + +@attr('a11y') +class LmsDashboardA11yTest(BaseLmsDashboardTest): + """ + Class to test lms student dashboard accessibility. + """ + + def test_dashboard_course_listings_a11y(self): + """ + Test the accessibility of the course listings + """ + course_listings = self.dashboard_page.get_course_listings() + self.assertEqual(len(course_listings), 1) + + # There are several existing color contrast errors on this page, + # we will ignore this error in the test until we fix them. + self.dashboard_page.a11y_audit.config.set_rules({ + "ignore": ['color-contrast'], + }) + + self.dashboard_page.a11y_audit.check_for_accessibility_errors() diff --git a/common/test/acceptance/tests/studio/test_studio_library.py b/common/test/acceptance/tests/studio/test_studio_library.py index 3094499285..fed2f5b8cf 100644 --- a/common/test/acceptance/tests/studio/test_studio_library.py +++ b/common/test/acceptance/tests/studio/test_studio_library.py @@ -637,3 +637,26 @@ class LibraryUsersPageTest(StudioLibraryTest): self.assertEqual(len(self.page.users), 1) user = self.page.users[0] self.assertTrue(user.is_current_user) + + +@attr('a11y') +class StudioLibraryA11yTest(StudioLibraryTest): + """ + Class to test Studio pages accessibility. + """ + + def test_lib_edit_page_a11y(self): + """ + Check accessibility of LibraryEditPage. + """ + lib_page = LibraryEditPage(self.browser, self.library_key) + lib_page.visit() + lib_page.wait_until_ready() + + # There are several existing color contrast errors on this page, + # we will ignore this error in the test until we fix them. + lib_page.a11y_audit.config.set_rules({ + "ignore": ['color-contrast'], + }) + + lib_page.a11y_audit.check_for_accessibility_errors() diff --git a/scripts/accessibility-tests.sh b/scripts/accessibility-tests.sh index 1350f09891..d34b9e3bbc 100755 --- a/scripts/accessibility-tests.sh +++ b/scripts/accessibility-tests.sh @@ -3,4 +3,4 @@ echo "Setting up for accessibility tests..." source scripts/jenkins-common.sh echo "Running explicit accessibility tests..." -SELENIUM_BROWSER=phantomjs paver test_bokchoy -d accessibility +SELENIUM_BROWSER=phantomjs paver test_bokchoy --extra_args="-a 'a11y'" diff --git a/scripts/generic-ci-tests.sh b/scripts/generic-ci-tests.sh index bf71d64aa8..bf3e928466 100755 --- a/scripts/generic-ci-tests.sh +++ b/scripts/generic-ci-tests.sh @@ -173,7 +173,7 @@ END ;; "7") - paver test_bokchoy --extra_args="-a shard_1=False,shard_2=False,shard_3=False,shard_4=False,shard_5=False,shard_6=False --with-flaky" + paver test_bokchoy --extra_args="-a shard_1=False,shard_2=False,shard_3=False,shard_4=False,shard_5=False,shard_6=False,a11y=False --with-flaky" ;; # Default case because if we later define another bok-choy shard on Jenkins