From cd7f2aeee1f925768c9986a7d69d667a8afe8944 Mon Sep 17 00:00:00 2001 From: Feanil Patel Date: Mon, 2 Feb 2026 14:43:27 -0500 Subject: [PATCH] fix: use correct Django settings for each service in CI The static-assets-check workflow was setting DJANGO_SETTINGS_MODULE=lms.envs.production globally, but then running both LMS and CMS collectstatic. Because manage.py doesn't override DJANGO_SETTINGS_MODULE when it's already set (and --settings isn't passed), CMS was running with LMS settings instead of CMS settings. This meant CMS-specific RequireJS builds (cms/static/cms/js/build.js) were never being tested, allowing issues like missing modules to slip through to sandbox deployments. Fix by setting DJANGO_SETTINGS_MODULE explicitly for each service. Co-Authored-By: Claude Opus 4.5 --- .github/workflows/static-assets-check.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/static-assets-check.yml b/.github/workflows/static-assets-check.yml index ae9b57879c..8e83a9a46c 100644 --- a/.github/workflows/static-assets-check.yml +++ b/.github/workflows/static-assets-check.yml @@ -98,7 +98,6 @@ jobs: env: LMS_CFG: lms/envs/minimal.yml CMS_CFG: lms/envs/minimal.yml - DJANGO_SETTINGS_MODULE: lms.envs.production run: | - ./manage.py lms collectstatic --noinput - ./manage.py cms collectstatic --noinput + DJANGO_SETTINGS_MODULE=lms.envs.production ./manage.py lms collectstatic --noinput + DJANGO_SETTINGS_MODULE=cms.envs.production ./manage.py cms collectstatic --noinput