From ccbd9d5b83220a0e4ab8bafc40140c98dae57b26 Mon Sep 17 00:00:00 2001
From: Jeff Witt <jeff.witt@edx.org>
Date: Mon, 14 Jan 2019 11:31:03 -0500
Subject: [PATCH] fix video player various buttons accessibility

---
 common/lib/xmodule/xmodule/css/video/display.scss             | 3 ++-
 .../lib/xmodule/xmodule/js/src/video/04_video_full_screen.js  | 2 ++
 .../xmodule/xmodule/js/src/video/07_video_volume_control.js   | 2 ++
 .../xmodule/xmodule/js/src/video/08_video_speed_control.js    | 4 ++--
 4 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/common/lib/xmodule/xmodule/css/video/display.scss b/common/lib/xmodule/xmodule/css/video/display.scss
index bd4fce681f..424d0f6dfb 100644
--- a/common/lib/xmodule/xmodule/css/video/display.scss
+++ b/common/lib/xmodule/xmodule/css/video/display.scss
@@ -573,7 +573,8 @@ $cool-dark: rgb(79, 89, 93); // UXPL cool dark
               color: rgb(231, 236, 238); // UXPL grayscale-cool x-light
 
               @media (max-width: 1120px) {
-                display: none;
+                  position: absolute;
+                  clip: rect(1px, 1px, 1px, 1px);
               }
             }
 
diff --git a/common/lib/xmodule/xmodule/js/src/video/04_video_full_screen.js b/common/lib/xmodule/xmodule/js/src/video/04_video_full_screen.js
index 590e057cf1..3349aa0a7d 100644
--- a/common/lib/xmodule/xmodule/js/src/video/04_video_full_screen.js
+++ b/common/lib/xmodule/xmodule/js/src/video/04_video_full_screen.js
@@ -4,6 +4,8 @@
         var template = [
             '<button class="control add-fullscreen" aria-disabled="false" title="',
             gettext('Fill browser'),
+            '" aria-label="',
+            gettext('Fill browser'),
             '">',
             '<span class="icon fa fa-arrows-alt" aria-hidden="true"></span>',
             '</button>'
diff --git a/common/lib/xmodule/xmodule/js/src/video/07_video_volume_control.js b/common/lib/xmodule/xmodule/js/src/video/07_video_volume_control.js
index 8500f219db..86d6a29b1d 100644
--- a/common/lib/xmodule/xmodule/js/src/video/07_video_volume_control.js
+++ b/common/lib/xmodule/xmodule/js/src/video/07_video_volume_control.js
@@ -46,6 +46,8 @@ function(HtmlUtils) {
                 '<button class="control" aria-disabled="false"',
                 '" aria-expanded="false" title="',
                 '{adjustVideoVolume}',
+                '" aria-label="',
+                '{adjustVideoVolume}',
                 '">',
                 '<span class="icon fa fa-volume-up" aria-hidden="true"></span>',
                 '</button>',
diff --git a/common/lib/xmodule/xmodule/js/src/video/08_video_speed_control.js b/common/lib/xmodule/xmodule/js/src/video/08_video_speed_control.js
index fffc121b53..5668bb1360 100644
--- a/common/lib/xmodule/xmodule/js/src/video/08_video_speed_control.js
+++ b/common/lib/xmodule/xmodule/js/src/video/08_video_speed_control.js
@@ -41,9 +41,9 @@
             '<span>',
             '<span class="icon fa fa-caret-right" aria-hidden="true"></span>',
             '</span>',
-            '<span class="label" aria-hidden="true">',
+            '<span class="label">',
             gettext('Speed'),
-            '</span>',
+            ' </span>',
             '<span class="value"></span>',
             '</button>',
             '<ol class="video-speeds menu"></ol>',