Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Dont fetch caption on getting translations

Browse Source 
This fixes the endless loop of fetchCaptions ajax requests. fetchCaption on error calls fetchAvailableTranslations which again calls fetchCaption on success and so on. We don't see any significance for calling fetchCaption in fetchAvailableTranslations.
This commit is contained in:
Qubad786
2017-07-11 23:50:32 +05:00
parent aee1b7f412
commit c9bbc0b68a
2 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
common/lib/xmodule/xmodule/js/spec/video/video_caption_spec.js
View File

@@ -779,7 +779,6 @@
Caption.fetchAvailableTranslations(); Caption.fetchAvailableTranslations();
expect($.ajaxWithPrefix).toHaveBeenCalled(); expect($.ajaxWithPrefix).toHaveBeenCalled();
expect(Caption.fetchCaption).toHaveBeenCalled();
expect(state.config.transcriptLanguages).toEqual({ expect(state.config.transcriptLanguages).toEqual({
'uk': 'Ukrainian', 'uk': 'Ukrainian',
'de': 'German' 'de': 'German'
@@ -799,7 +798,6 @@
Caption.fetchAvailableTranslations(); Caption.fetchAvailableTranslations();
expect($.ajaxWithPrefix).toHaveBeenCalled(); expect($.ajaxWithPrefix).toHaveBeenCalled();
expect(Caption.fetchCaption).not.toHaveBeenCalled();
expect(state.config.transcriptLanguages).toEqual({}); expect(state.config.transcriptLanguages).toEqual({});
expect(Caption.renderLanguageMenu).not.toHaveBeenCalled(); expect(Caption.renderLanguageMenu).not.toHaveBeenCalled();
}); });

6
common/lib/xmodule/xmodule/js/src/video/09_video_caption.js
View File

@@ -596,8 +596,8 @@
}, },
/** /**
* @desc Fetch the list of available translations. Upon successful receipt, * @desc Fetch the list of available language codes. Upon successful receipt
* the list of available translations will be updated. * the list of available languages will be updated.
* *
* @returns {jquery Promise} * @returns {jquery Promise}
*/ */
@@ -618,8 +618,6 @@
self.container.find('.langs-list').remove(); self.container.find('.langs-list').remove();
if (_.keys(newLanguages).length) { if (_.keys(newLanguages).length) {
// And try again to fetch transcript.
self.fetchCaption();
self.renderLanguageMenu(newLanguages); self.renderLanguageMenu(newLanguages);
} }
}, },