cleanup and response to PR review

lms/envs/common.py

@@ -672,7 +672,7 @@ FAVICON_PATH = 'images/favicon.ico'
 TIME_ZONE = 'America/New_York'  # http://en.wikipedia.org/wiki/List_of_tz_zones_by_name
 LANGUAGE_CODE = 'en'  # http://www.i18nguy.com/unicode/language-identifiers.html
 # these languages display right to left
-LANGUAGES_BIDI = ("en@rtl", "he", "ar", "fa")
+LANGUAGES_BIDI = ("en@rtl", "he", "ar", "fa", "ur", "fa-ir")
 
 # Sourced from http://www.localeplanet.com/icu/ and wikipedia
 LANGUAGES = (

lms/static/sass/application-extend1-rtl.scss.mako

@@ -12,7 +12,6 @@
 
 // base - utilities
 @import 'base/reset';
-@import 'base/config';
 @import 'base/variables';
 @import 'base/mixins';
 

lms/static/sass/application-extend1.scss.mako

@@ -12,7 +12,6 @@
 
 // base - utilities
 @import 'base/reset';
-@import 'base/config';
 @import 'base/variables';
 @import 'base/mixins';
 

lms/static/sass/application-extend2-rtl.scss.mako

@@ -12,7 +12,6 @@
 
 // base - utilities
 @import 'base/reset';
-@import 'base/config';
 @import 'base/variables';
 @import 'base/mixins';
 

lms/static/sass/application-extend2.scss.mako

@@ -12,7 +12,6 @@
 
 // base - utilities
 @import 'base/reset';
-@import 'base/config';
 @import 'base/variables';
 @import 'base/mixins';
 

lms/static/sass/application-rtl.scss.mako

@@ -12,7 +12,6 @@
 
 // base - utilities
 @import 'base/reset';
-@import 'base/config';
 @import 'base/variables';
 @import 'base/mixins';
 

lms/static/sass/application.scss.mako

@@ -12,7 +12,6 @@
 
 // base - utilities
 @import 'base/reset';
-@import 'base/config';
 @import 'base/variables';
 @import 'base/mixins';
 

lms/static/sass/base/_config.scss

@@ -1,7 +0,0 @@
-// lms - config
-// ====================
-// TODO: make the RTL variable work here for LMS and xmodules
-// setting the layout to handle right to left languages
-// false= lang direction left to right (eg. english); true = rtl (eg. arabic)
-//$rtl: true;
-// does not work here - is in LMS variables

lms/static/sass/base/_mixins.scss

@@ -54,11 +54,6 @@
 
 // ====================
 
-// Cross-browsers transform
-@mixin transform($transform-functions) {
-  @include prefixer(transform, $transform-functions, webkit moz ms o spec);
-}
-
 // extends - UI - used for page/view-level wrappers (for centering/grids)
 %ui-wrapper {
   @include clearfix();

lms/static/sass/base/_variables.scss

@@ -1,10 +1,5 @@
 // lms variables
 
-// setting the layout to handle right to left languages
-// false= lang direction left to right (eg. english); true = rtl (eg. arabic)
-$rtl: false;
-
-
 // base
 $baseline: 20px;
 

lms/static/sass/course/courseware/_courseware.scss

@@ -23,7 +23,7 @@ html.video-fullscreen{
 
   .instructor-info-action {
     @extend %t-copy-sub2;
-    @include float(left);
+    @include float(right);
     margin-left: ($baseline/2);
     padding: ($baseline/4) ($baseline/2);
     border-radius: ($baseline/4);

lms/static/sass/course/courseware/_sidebar.scss

@@ -2,7 +2,7 @@
   @extend .sidebar;
   @extend .tran;
   @include border-right(1px solid $border-color-2);
-  @include border-radius(3px 0 0 3px);
+  @include border-radius(3px, 0, 0, 3px);
 
   #open_close_accordion {
     display: none;
@@ -66,11 +66,14 @@
           background-image: url("/static/images/ui-icons_222222_256x240.png");  // jQuery UI sprite
 
           &.ui-icon-triangle-1-e {
+
+            // CASE: left to right layout
             @include ltr {
               background-position: -32px -16px; // jQuery UI east arrow position
             }
 
-            @include rtl {
+           // CASE: right to left layout
+           @include rtl {
               background-position: -96px -16px; // jQuery UI west arrow position
             }
           }

lms/static/sass/discussion/_discussion.scss

@@ -734,7 +734,7 @@ body.discussion {
       display: inline-block;
       position: relative;
       top: 5px;
-      margin-right: 6px;
+      @include margin-right(6px);
       width: 21px;
       height: 19px;
       background: url(../images/show-hide-discussion-icon.png) no-repeat;
@@ -744,7 +744,7 @@ body.discussion {
 
   .new-post-btn {
     display: inline-block;
-    float: right;
+    @include float(right);
   }
 
   section.discussion {

lms/static/sass/discussion/views/_create-edit-post.scss

@@ -46,7 +46,7 @@
     .field-help {
       @include box-sizing(border-box);
       display: inline-block;
-      padding-left: $baseline;
+      @include padding-left($baseline);
       width: 50%;
       font-size: 12px;
     }
@@ -131,7 +131,7 @@
   .post-option {
     @include box-sizing(border-box);
     display: inline-block;
-    margin-right: $baseline;
+    @include margin-right($baseline);
     border: 1px solid transparent;
     border-radius: 3px;
     padding: ($baseline/2);

lms/static/sass/multicourse/_dashboard.scss

@@ -452,7 +452,7 @@
           @include box-sizing(border-box);
           border-radius: 3px;
           display: block;
-          float: left;
+          @include float(left);
           font: normal 15px/1.6rem $sans-serif;
           letter-spacing: 0;
           padding: 6px 32px 7px;

lms/static/sass/shared/_footer.scss

@@ -32,16 +32,16 @@
 
     // colophon
     .colophon {
-      margin-right: flex-gutter();
+      @include margin-right(flex-gutter());
       width: flex-grid(8,12);
-      float: left;
+      @include float(left);
 
       .nav-colophon {
         @include clearfix();
         margin: $footer_margin;
 
         li {
-          float: left;
+          @include float(left);
           margin-right: ($baseline*0.75);
 
           a {
@@ -102,12 +102,12 @@
       margin: -2px 0 8px 0;
       font-size: em(11);
       color: $gray-l2;
-      text-align: left;
+      @include text-align(left);
     }
 
     .nav-legal {
       @include clearfix();
-      text-align: left;
+      @include text-align(left);
 
       li {
         display: inline-block;
@@ -154,10 +154,11 @@
 
     // platform Open edX logo and link
     .powered-by {
+      @include float(right);
       width: flex-grid(3,12);
       display: inline-block;
       vertical-align: bottom;
-      text-align: right;
+      @include text-align(right);
 
       a {
         display: inline-block;

lms/static/sass/shared/_header.scss

@@ -146,6 +146,7 @@ header.global {
         @include background-image(url('../images/small-header-home-icon.png'));
         background-repeat: no-repeat;
 
+        // CASE: right to left layout
         @include rtl {
           background-position: top right;
         }
@@ -420,7 +421,7 @@ header.global-new {
       vertical-align: middle;
 
       &:last-child {
-        @include margin-right(0px);
+        @include margin-right(0);
       }
 
       &:hover, &:focus, &:active {
@@ -436,12 +437,12 @@ header.global-new {
     > .primary {
       display: block;
       @include float(left);
-      margin: 0px;
+      margin: 0;
       position: relative;
 
       > a {
         margin: 0px;
-        @include border-right-radius(0px);
+        @include border-right-radius(0);
       }
 
       &:last-child {
@@ -497,7 +498,7 @@ header.global-new {
       display: none;
       padding: 5px 10px;
       position: absolute;
-      @include right(0px);
+      @include right(0);
       top: 34px;
       width: 170px;
       z-index: 3;

lms/templates/main.html

@@ -4,7 +4,7 @@
 <!--[if IE 9]><html class="ie ie9 lte9" lang="${LANGUAGE_CODE}"><![endif]-->
 <!--[if gt IE 9]><!--><html lang="${LANGUAGE_CODE}"><!--<![endif]-->
 <%
-    # This should be done someplace more central.
+    # set doc language direction
     from django.utils.translation import get_language_bidi
     dir_rtl = 'rtl' if get_language_bidi() else 'ltr'
 %>