From c875f71573e3b8033a0cfb51cddf3fdbec2790dd Mon Sep 17 00:00:00 2001 From: Ben Patterson Date: Thu, 18 Sep 2014 13:54:36 -0400 Subject: [PATCH] Disable flaky javascript tests TL-439 --- .../js/spec/video/video_context_menu_spec.js | 4 +++- .../xmodule/js/spec/video/video_player_spec.js | 16 ++++++++++++---- 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/common/lib/xmodule/xmodule/js/spec/video/video_context_menu_spec.js b/common/lib/xmodule/xmodule/js/spec/video/video_context_menu_spec.js index c779b9888d..324975efe8 100644 --- a/common/lib/xmodule/xmodule/js/spec/video/video_context_menu_spec.js +++ b/common/lib/xmodule/xmodule/js/spec/video/video_context_menu_spec.js @@ -217,7 +217,9 @@ expect(menuSubmenuItem).not.toHaveClass('is-opened'); }); - it('mouse left/right-clicking behaves as expected on play/pause menu item', function () { + // Flaky-test resulting in timeout errors. Disabled 09/18/2014 + // See TNL-439 + xit('mouse left/right-clicking behaves as expected on play/pause menu item', function () { var menuItem = menuItems.first(); runs(function () { // Left-click on play diff --git a/common/lib/xmodule/xmodule/js/spec/video/video_player_spec.js b/common/lib/xmodule/xmodule/js/spec/video/video_player_spec.js index 40507ce94a..e42143cc38 100644 --- a/common/lib/xmodule/xmodule/js/spec/video/video_player_spec.js +++ b/common/lib/xmodule/xmodule/js/spec/video/video_player_spec.js @@ -382,7 +382,9 @@ function (VideoPlayer) { }, 'video didn\'t start playing', WAIT_TIMEOUT); }); - it('slider event causes log update', function () { + // as per TNL-439 this test is deemed flaky and needs to be fixed. + // disabled 09/18/2014 + xit('slider event causes log update', function () { runs(function () { spyOn(state.videoPlayer, 'log'); state.videoProgressSlider.onSlide( @@ -416,7 +418,9 @@ function (VideoPlayer) { }); }); - it('seek the player', function () { + // as per TNL-439 this test is deemed flaky and needs to be fixed. + // disabled 09/18/2014 + xit('seek the player', function () { runs(function () { spyOn(state.videoPlayer.player, 'seekTo') .andCallThrough(); @@ -435,7 +439,9 @@ function (VideoPlayer) { }); }); - it('call updatePlayTime on player', function () { + // as per TNL-439 this test is deemed flaky and needs to be fixed. + // disabled 09/18/2014 + xit('call updatePlayTime on player', function () { runs(function () { spyOn(state.videoPlayer, 'updatePlayTime') .andCallThrough(); @@ -475,7 +481,9 @@ function (VideoPlayer) { }); }); - describe('when the video is not playing', function () { + // as per TNL-439 these tests are deemed flaky and needs to be fixed. + // disabled 09/18/2014 + xdescribe('when the video is not playing', function () { beforeEach(function () { spyOn(state.videoPlayer, 'setPlaybackRate') .andCallThrough();