Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prevent unbounded nesting of lms field_datas

Browse Source 
Previously, whenever a XModule was created from a XDescriptor, we
created another level of nesting of FieldData objects. This change
prevents that nesting.

[TKTS-393]
This commit is contained in:
Calen Pennington
2013-10-25 11:53:35 -04:00
parent 8c51c59b55
commit c3d25e1e61
5 changed files with 52 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cms/djangoapps/contentstore/views/preview.py
View File

@@ -16,7 +16,7 @@ from xmodule.modulestore.django import modulestore
from xmodule.x_module import ModuleSystem
from xblock.runtime import DbModel
from lms.xblock.field_data import lms_field_data
from lms.xblock.field_data import LmsFieldData
from util.sandboxing import can_execute_unsafe_code
@@ -149,7 +149,7 @@ def load_preview_module(request, preview_id, descriptor):
student_data = DbModel(SessionKeyValueStore(request))
descriptor.bind_for_student(
preview_module_system(request, preview_id, descriptor),
lms_field_data(descriptor._field_data, student_data), # pylint: disable=protected-access
LmsFieldData(descriptor._field_data, student_data), # pylint: disable=protected-access
)
return descriptor