From c39ff353ead444ea2cf29cfaed8d8accd1c81af3 Mon Sep 17 00:00:00 2001 From: cahrens Date: Mon, 25 Mar 2013 11:09:33 -0400 Subject: [PATCH] Don't assume input fields will be within a div. https://edx.lighthouseapp.com/projects/102637/tickets/232 --- cms/static/js/views/validating_view.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/cms/static/js/views/validating_view.js b/cms/static/js/views/validating_view.js index 041e779030..c3ea57fd20 100644 --- a/cms/static/js/views/validating_view.js +++ b/cms/static/js/views/validating_view.js @@ -25,11 +25,14 @@ CMS.Views.ValidatingView = Backbone.View.extend({ for (var field in error) { var ele = this.$el.find('#' + this.fieldToSelectorMap[field]); this._cacheValidationErrors.push(ele); - if ($(ele).is('div')) { - // put error on the contained inputs - $(ele).find('input, textarea').addClass('error'); + var inputElements = 'input, textarea'; + if ($(ele).is(inputElements)) { + $(ele).addClass('error'); + } + else { + // put error on the contained inputs + $(ele).find(inputElements).addClass('error'); } - else $(ele).addClass('error'); $(ele).parent().append(this.errorTemplate({message : error[field]})); } },