From c0fef0b0e09d3eb3c1834050fbe6a111cd51337e Mon Sep 17 00:00:00 2001 From: muzaffaryousaf Date: Wed, 6 Apr 2016 21:25:07 +0500 Subject: [PATCH] Js test fixes for cms and cms-squire. --- cms/static/coffee/spec/main.coffee | 6 +- cms/static/coffee/spec/main_spec.coffee | 24 +- .../coffee/spec/models/section_spec.coffee | 4 +- .../coffee/spec/models/textbook_spec.coffee | 6 - .../coffee/spec/views/assets_spec.coffee | 58 +- .../coffee/spec/views/course_info_spec.coffee | 34 +- .../coffee/spec/views/module_edit_spec.coffee | 16 +- .../coffee/spec/views/textbook_spec.coffee | 52 +- .../coffee/spec/views/upload_spec.coffee | 26 +- .../js/certificates/spec/custom_matchers.js | 34 +- .../spec/views/certificate_details_spec.js | 43 +- .../spec/views/certificate_editor_spec.js | 49 +- .../spec/views/certificate_preview_spec.js | 36 +- .../spec/views/certificates_list_spec.js | 44 +- .../certificates/views/certificate_details.js | 9 +- .../certificates/views/certificate_editor.js | 12 +- .../certificates/views/certificate_preview.js | 8 +- .../certificates/views/signatory_details.js | 13 +- .../js/certificates/views/signatory_editor.js | 9 +- .../spec/models/group_configuration_spec.js | 207 +++--- .../js/spec/utils/drag_and_drop_spec.js | 36 +- .../spec/utils/handle_iframe_binding_spec.js | 4 +- .../spec/video/file_uploader_editor_spec.js | 133 ++-- .../js/spec/video/transcripts/editor_spec.js | 81 +-- .../video/transcripts/file_uploader_spec.js | 14 +- .../video/transcripts/message_manager_spec.js | 81 +-- .../js/spec/video/transcripts/utils_spec.js | 2 +- .../spec/video/transcripts/videolist_spec.js | 682 +++++++++--------- .../js/spec/video/translations_editor_spec.js | 173 +++-- .../views/active_video_upload_list_spec.js | 44 +- cms/static/js/spec/views/assets_spec.js | 4 +- cms/static/js/spec/views/baseview_spec.js | 4 +- .../js/spec/views/group_configuration_spec.js | 110 ++- cms/static/js/spec/views/login_studio_spec.js | 2 +- .../js/spec/views/modals/base_modal_spec.js | 11 +- .../modals/validation_error_modal_spec.js | 13 +- .../js/spec/views/paged_container_spec.js | 7 +- .../js/spec/views/pages/container_spec.js | 2 +- .../views/pages/container_subviews_spec.js | 32 +- .../spec/views/pages/course_outline_spec.js | 27 +- .../views/pages/group_configurations_spec.js | 16 +- .../js/spec/views/pages/library_users_spec.js | 9 +- .../spec/views/previous_video_upload_spec.js | 2 +- cms/static/js/spec/views/unit_outline_spec.js | 15 +- cms/static/js/spec/views/xblock_spec.js | 4 +- cms/static/js/views/experiment_group_edit.js | 7 +- cms/static/js/views/license.js | 9 +- cms/static/js_test.yml | 5 +- cms/static/js_test_squire.yml | 3 - cms/static/karma_cms.conf.js | 1 + cms/static/karma_cms_squire.conf.js | 1 + ...xmodule-editor-with-custom-tabs.underscore | 2 +- ...ck-xmodule-settings-only-editor.underscore | 2 +- common/static/js/libs/jasmine-extensions.js | 22 +- pavelib/utils/envs.py | 8 +- 55 files changed, 1219 insertions(+), 1039 deletions(-) diff --git a/cms/static/coffee/spec/main.coffee b/cms/static/coffee/spec/main.coffee index ee456c3bd5..0aa0e96687 100644 --- a/cms/static/coffee/spec/main.coffee +++ b/cms/static/coffee/spec/main.coffee @@ -231,9 +231,9 @@ testFiles = [ "coffee/spec/views/upload_spec", "js/spec/video/transcripts/utils_spec", "js/spec/video/transcripts/editor_spec", - "js/spec/video/transcripts/videolist_spec", - "js/spec/video/transcripts/message_manager_spec", - "js/spec/video/transcripts/file_uploader_spec", +# "js/spec/video/transcripts/videolist_spec", +# "js/spec/video/transcripts/message_manager_spec", +# "js/spec/video/transcripts/file_uploader_spec", "js/spec/models/component_template_spec", "js/spec/models/explicit_url_spec", "js/spec/models/xblock_info_spec", diff --git a/cms/static/coffee/spec/main_spec.coffee b/cms/static/coffee/spec/main_spec.coffee index 66e8048889..ee68e31326 100644 --- a/cms/static/coffee/spec/main_spec.coffee +++ b/cms/static/coffee/spec/main_spec.coffee @@ -1,4 +1,5 @@ -require ["jquery", "backbone", "coffee/src/main", "common/js/spec_helpers/ajax_helpers", "jasmine-stealth", "jquery.cookie"], +require ["jquery", "backbone", "coffee/src/main", "common/js/spec_helpers/ajax_helpers", + "jasmine-stealth", "jasmine-waituntil", "jquery.cookie"], ($, Backbone, main, AjaxHelpers) -> describe "CMS", -> it "should initialize URL", -> @@ -7,8 +8,12 @@ require ["jquery", "backbone", "coffee/src/main", "common/js/spec_helpers/ajax_h describe "main helper", -> beforeEach -> @previousAjaxSettings = $.extend(true, {}, $.ajaxSettings) - spyOn($, "cookie") - $.cookie.when("csrftoken").thenReturn("stubCSRFToken") + spyOn($, "cookie").and.callFake( + (param) -> + if param == "csrftoken" + return "stubCSRFToken" + ) + main() afterEach -> @@ -21,12 +26,15 @@ require ["jquery", "backbone", "coffee/src/main", "common/js/spec_helpers/ajax_h expect($.ajaxSettings.headers["X-CSRFToken"]).toEqual("stubCSRFToken") describe "AJAX Errors", -> - + server = null beforeEach -> appendSetFixtures(sandbox({id: "page-notification"})) + afterEach -> + server && server.restore() + it "successful AJAX request does not pop an error notification", -> - server = AjaxHelpers.server(this, [200, {}, '']) + server = AjaxHelpers.server([200, {}, '']) expect($("#page-notification")).toBeEmpty() $.ajax("/test") @@ -35,15 +43,15 @@ require ["jquery", "backbone", "coffee/src/main", "common/js/spec_helpers/ajax_h expect($("#page-notification")).toBeEmpty() it "AJAX request with error should pop an error notification", -> - server = AjaxHelpers.server(this, [500, {}, '']) + server = AjaxHelpers.server([500, {}, '']) $.ajax("/test") server.respond() expect($("#page-notification")).not.toBeEmpty() - expect($("#page-notification")).toContain('div.wrapper-notification-error') + expect($("#page-notification")).toContainElement('div.wrapper-notification-error') it "can override AJAX request with error so it does not pop an error notification", -> - server = AjaxHelpers.server(this, [500, {}, '']) + server = AjaxHelpers.server([500, {}, '']) $.ajax url: "/test" diff --git a/cms/static/coffee/spec/models/section_spec.coffee b/cms/static/coffee/spec/models/section_spec.coffee index 536d3507d6..82fd1c9b3f 100644 --- a/cms/static/coffee/spec/models/section_spec.coffee +++ b/cms/static/coffee/spec/models/section_spec.coffee @@ -34,7 +34,7 @@ define ["js/models/section", "common/js/spec_helpers/ajax_helpers", "js/utils/mo }) it "show/hide a notification when it saves to the server", -> - server = AjaxHelpers.server(this, [200, {}, '']) + server = AjaxHelpers.server([200, {}, '']) @model.save() expect(Section.prototype.showNotification).toHaveBeenCalled() @@ -43,7 +43,7 @@ define ["js/models/section", "common/js/spec_helpers/ajax_helpers", "js/utils/mo it "don't hide notification when saving fails", -> # this is handled by the global AJAX error handler - server = AjaxHelpers.server(this, [500, {}, '']) + server = AjaxHelpers.server([500, {}, '']) @model.save() server.respond() diff --git a/cms/static/coffee/spec/models/textbook_spec.coffee b/cms/static/coffee/spec/models/textbook_spec.coffee index fa4f86742c..dd78ba8997 100644 --- a/cms/static/coffee/spec/models/textbook_spec.coffee +++ b/cms/static/coffee/spec/models/textbook_spec.coffee @@ -1,12 +1,6 @@ define ["backbone", "js/models/textbook", "js/collections/textbook", "js/models/chapter", "js/collections/chapter", "coffee/src/main"], (Backbone, Textbook, TextbookSet, Chapter, ChapterSet, main) -> - beforeEach -> - @addMatchers - toBeInstanceOf: (expected) -> - return @actual instanceof expected - - describe "Textbook model", -> beforeEach -> main() diff --git a/cms/static/coffee/spec/views/assets_spec.coffee b/cms/static/coffee/spec/views/assets_spec.coffee index aa24e82ac2..6c82b2e3e2 100644 --- a/cms/static/coffee/spec/views/assets_spec.coffee +++ b/cms/static/coffee/spec/views/assets_spec.coffee @@ -1,25 +1,25 @@ -define ["jquery", "jasmine", "common/js/spec_helpers/ajax_helpers", "squire"], -($, jasmine, AjaxHelpers, Squire) -> +define ["jquery", "common/js/spec_helpers/ajax_helpers", "squire"], +($, AjaxHelpers, Squire) -> assetLibraryTpl = readFixtures('asset-library.underscore') assetTpl = readFixtures('asset.underscore') describe "Asset view", -> - beforeEach -> + beforeEach (done) -> setFixtures($("