From bf6cbe7f6b804fa2ddd7d7eb048105b93fdf8bcf Mon Sep 17 00:00:00 2001 From: arbisoft Date: Fri, 23 Aug 2019 13:46:16 +0500 Subject: [PATCH] BOM-356 None type comparison with int was not working in python3. There was an issue with previous condition also. with Nonetype it was not coming into error part. --- cms/djangoapps/contentstore/views/item.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cms/djangoapps/contentstore/views/item.py b/cms/djangoapps/contentstore/views/item.py index 7209219aca..e96956a8e3 100644 --- a/cms/djangoapps/contentstore/views/item.py +++ b/cms/djangoapps/contentstore/views/item.py @@ -791,7 +791,7 @@ def _move_item(source_usage_key, target_parent_usage_key, user, target_index=Non else: try: target_index = int(target_index) if target_index is not None else None - if len(target_parent.children) < target_index: + if target_index is not None and len(target_parent.children) < target_index: error = _(u'You can not move {source_usage_key} at an invalid index ({target_index}).').format( source_usage_key=text_type(source_usage_key), target_index=target_index