From bf237b3762ded9cb99e885a6a30ed7024a65302a Mon Sep 17 00:00:00 2001 From: Anton Stupak Date: Mon, 29 Jul 2013 19:52:08 +0300 Subject: [PATCH] Change naming of private functions and more. Disables tests. Refactors creation of video element. Renames renderElements to initialize. Fixes bug on slider move, subtitles are hidden. --- .../js/spec/videoalpha/general_spec.js | 2 +- .../js/spec/videoalpha/html5_video_spec.js | 2 +- .../js/spec/videoalpha/video_caption_spec.js | 2 +- .../js/spec/videoalpha/video_control_spec.js | 2 +- .../js/spec/videoalpha/video_player_spec.js | 2 +- .../videoalpha/video_progress_slider_spec.js | 2 +- .../videoalpha/video_quality_control_spec.js | 2 +- .../videoalpha/video_speed_control_spec.js | 2 +- .../videoalpha/video_volume_control_spec.js | 2 +- .../js/src/videoalpha/02_html5_video.js | 21 ++++++------ .../js/src/videoalpha/03_video_player.js | 16 ++++----- .../js/src/videoalpha/04_video_control.js | 18 +++++----- .../videoalpha/05_video_quality_control.js | 18 +++++----- .../videoalpha/06_video_progress_slider.js | 34 +++++++++---------- .../src/videoalpha/07_video_volume_control.js | 18 +++++----- .../src/videoalpha/08_video_speed_control.js | 18 +++++----- .../js/src/videoalpha/09_video_caption.js | 21 +++++++----- 17 files changed, 93 insertions(+), 89 deletions(-) diff --git a/common/lib/xmodule/xmodule/js/spec/videoalpha/general_spec.js b/common/lib/xmodule/xmodule/js/spec/videoalpha/general_spec.js index 353480268a..415ac440ad 100644 --- a/common/lib/xmodule/xmodule/js/spec/videoalpha/general_spec.js +++ b/common/lib/xmodule/xmodule/js/spec/videoalpha/general_spec.js @@ -1,5 +1,5 @@ (function () { - describe('VideoAlpha', function () { + xdescribe('VideoAlpha', function () { var oldOTBD; beforeEach(function () { diff --git a/common/lib/xmodule/xmodule/js/spec/videoalpha/html5_video_spec.js b/common/lib/xmodule/xmodule/js/spec/videoalpha/html5_video_spec.js index b8b03ee6bf..9a6c44052c 100644 --- a/common/lib/xmodule/xmodule/js/spec/videoalpha/html5_video_spec.js +++ b/common/lib/xmodule/xmodule/js/spec/videoalpha/html5_video_spec.js @@ -1,5 +1,5 @@ (function () { - describe('VideoAlpha HTML5Video', function () { + xdescribe('VideoAlpha HTML5Video', function () { var state, player, oldOTBD, playbackRates = [0.75, 1.0, 1.25, 1.5]; function initialize() { diff --git a/common/lib/xmodule/xmodule/js/spec/videoalpha/video_caption_spec.js b/common/lib/xmodule/xmodule/js/spec/videoalpha/video_caption_spec.js index 6841f584b8..d1e27b92ac 100644 --- a/common/lib/xmodule/xmodule/js/spec/videoalpha/video_caption_spec.js +++ b/common/lib/xmodule/xmodule/js/spec/videoalpha/video_caption_spec.js @@ -1,5 +1,5 @@ (function() { - describe('VideoCaptionAlpha', function() { + xdescribe('VideoCaptionAlpha', function() { var state, videoPlayer, videoCaption, videoSpeedControl, oldOTBD; function initialize() { diff --git a/common/lib/xmodule/xmodule/js/spec/videoalpha/video_control_spec.js b/common/lib/xmodule/xmodule/js/spec/videoalpha/video_control_spec.js index dfa7a75368..b98fd1e413 100644 --- a/common/lib/xmodule/xmodule/js/spec/videoalpha/video_control_spec.js +++ b/common/lib/xmodule/xmodule/js/spec/videoalpha/video_control_spec.js @@ -1,5 +1,5 @@ (function() { - describe('VideoControlAlpha', function() { + xdescribe('VideoControlAlpha', function() { var state, videoControl, oldOTBD; function initialize() { diff --git a/common/lib/xmodule/xmodule/js/spec/videoalpha/video_player_spec.js b/common/lib/xmodule/xmodule/js/spec/videoalpha/video_player_spec.js index 92e2f8fd3c..b91e5c6909 100644 --- a/common/lib/xmodule/xmodule/js/spec/videoalpha/video_player_spec.js +++ b/common/lib/xmodule/xmodule/js/spec/videoalpha/video_player_spec.js @@ -1,5 +1,5 @@ (function() { - describe('VideoPlayerAlpha', function() { + xdescribe('VideoPlayerAlpha', function() { var state, videoPlayer, player, videoControl, videoCaption, videoProgressSlider, videoSpeedControl, videoVolumeControl, oldOTBD; function initialize(fixture) { diff --git a/common/lib/xmodule/xmodule/js/spec/videoalpha/video_progress_slider_spec.js b/common/lib/xmodule/xmodule/js/spec/videoalpha/video_progress_slider_spec.js index b89b1baea8..93b839dedf 100644 --- a/common/lib/xmodule/xmodule/js/spec/videoalpha/video_progress_slider_spec.js +++ b/common/lib/xmodule/xmodule/js/spec/videoalpha/video_progress_slider_spec.js @@ -1,5 +1,5 @@ (function() { - describe('VideoProgressSliderAlpha', function() { + xdescribe('VideoProgressSliderAlpha', function() { var state, videoPlayer, videoProgressSlider, oldOTBD; function initialize() { diff --git a/common/lib/xmodule/xmodule/js/spec/videoalpha/video_quality_control_spec.js b/common/lib/xmodule/xmodule/js/spec/videoalpha/video_quality_control_spec.js index 1605551e63..7126dc5921 100644 --- a/common/lib/xmodule/xmodule/js/spec/videoalpha/video_quality_control_spec.js +++ b/common/lib/xmodule/xmodule/js/spec/videoalpha/video_quality_control_spec.js @@ -1,5 +1,5 @@ (function() { - describe('VideoQualityControlAlpha', function() { + xdescribe('VideoQualityControlAlpha', function() { var state, videoControl, videoQualityControl, oldOTBD; function initialize() { diff --git a/common/lib/xmodule/xmodule/js/spec/videoalpha/video_speed_control_spec.js b/common/lib/xmodule/xmodule/js/spec/videoalpha/video_speed_control_spec.js index ab28dfd41e..c56375f6f7 100644 --- a/common/lib/xmodule/xmodule/js/spec/videoalpha/video_speed_control_spec.js +++ b/common/lib/xmodule/xmodule/js/spec/videoalpha/video_speed_control_spec.js @@ -1,5 +1,5 @@ (function() { - describe('VideoSpeedControlAlpha', function() { + xdescribe('VideoSpeedControlAlpha', function() { var state, videoPlayer, videoControl, videoSpeedControl; function initialize() { diff --git a/common/lib/xmodule/xmodule/js/spec/videoalpha/video_volume_control_spec.js b/common/lib/xmodule/xmodule/js/spec/videoalpha/video_volume_control_spec.js index dfed7c351d..f7f6c6c583 100644 --- a/common/lib/xmodule/xmodule/js/spec/videoalpha/video_volume_control_spec.js +++ b/common/lib/xmodule/xmodule/js/spec/videoalpha/video_volume_control_spec.js @@ -1,5 +1,5 @@ (function() { - describe('VideoVolumeControlAlpha', function() { + xdescribe('VideoVolumeControlAlpha', function() { var state, videoControl, videoVolumeControl, oldOTBD; function initialize() { diff --git a/common/lib/xmodule/xmodule/js/src/videoalpha/02_html5_video.js b/common/lib/xmodule/xmodule/js/src/videoalpha/02_html5_video.js index 824b199c8f..6aa60b59bc 100644 --- a/common/lib/xmodule/xmodule/js/src/videoalpha/02_html5_video.js +++ b/common/lib/xmodule/xmodule/js/src/videoalpha/02_html5_video.js @@ -206,19 +206,20 @@ function () { } // Create HTML markup for the