From 60a853134854d598b0411c46c031e5759986b133 Mon Sep 17 00:00:00 2001 From: Matt Drayer Date: Mon, 14 Sep 2015 17:05:14 -0400 Subject: [PATCH] mattdrayer/signatory-title-length: Bump to 106 characters * Fix typo * Fix odd test inputs --- cms/static/js/certificates/models/signatory.js | 4 ++-- .../js/certificates/spec/views/certificate_details_spec.js | 2 +- .../js/certificates/spec/views/certificate_editor_spec.js | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cms/static/js/certificates/models/signatory.js b/cms/static/js/certificates/models/signatory.js index ba478d5ece..416607d222 100644 --- a/cms/static/js/certificates/models/signatory.js +++ b/cms/static/js/certificates/models/signatory.js @@ -46,8 +46,8 @@ function(_, str, Backbone, BackboneRelational, gettext) { 'title': gettext('Signatory title should span over maximum of 2 lines.') }, errors); } - else if ((lines.length > 1 && (lines[0].length > 40 || lines[1].length > 40)) || - (lines.length === 1 && title.length > 40)) { + else if ((lines.length > 1 && (lines[0].length > 53 && lines[1].length > 53)) || + (lines.length === 1 && title.length > 106)) { errors = _.extend({ 'title': gettext('Signatory title should have maximum of 40 characters per line.') }, errors); diff --git a/cms/static/js/certificates/spec/views/certificate_details_spec.js b/cms/static/js/certificates/spec/views/certificate_details_spec.js index 75c3f84d51..b4044182fa 100644 --- a/cms/static/js/certificates/spec/views/certificate_details_spec.js +++ b/cms/static/js/certificates/spec/views/certificate_details_spec.js @@ -246,7 +246,7 @@ function(_, Course, CertificatesCollection, CertificateModel, CertificateDetails }); setValuesToInputs(this.view, { - inputSignatoryTitle: 'New Signatory Test Title longer than 40 characters in length' + inputSignatoryTitle: 'This is a certificate signatory title that has waaaaaaay more than 106 characters, in order to cause an exception.' }); setValuesToInputs(this.view, { diff --git a/cms/static/js/certificates/spec/views/certificate_editor_spec.js b/cms/static/js/certificates/spec/views/certificate_editor_spec.js index af3681d2de..5ccd3794f2 100644 --- a/cms/static/js/certificates/spec/views/certificate_editor_spec.js +++ b/cms/static/js/certificates/spec/views/certificate_editor_spec.js @@ -228,7 +228,7 @@ function(_, Course, CertificateModel, SignatoryModel, CertificatesCollection, Ce } ); - it('signatories should not save when title has more than 40 characters per line', function() { + it('signatories should not save when fields have too many characters per line', function() { this.view.$(SELECTORS.addSignatoryButton).click(); setValuesToInputs(this.view, { inputCertificateName: 'New Certificate Name' @@ -239,7 +239,7 @@ function(_, Course, CertificateModel, SignatoryModel, CertificatesCollection, Ce }); setValuesToInputs(this.view, { - inputSignatoryTitle: 'New Signatory title longer than 40 characters on one line' + inputSignatoryTitle: 'This is a certificate signatory title that has waaaaaaay more than 106 characters, in order to cause an exception.' }); setValuesToInputs(this.view, {