From beb95eb69cf9eaf47e0b871d1d417f39ab949601 Mon Sep 17 00:00:00 2001 From: Nimisha Asthagiri Date: Sat, 28 Sep 2019 18:34:46 -0400 Subject: [PATCH] Python 3: assertIn -> assertContains consistency --- .../contentstore/tests/test_export_git.py | 6 +- .../contentstore/views/tests/test_library.py | 2 +- .../contentstore/views/tests/test_videos.py | 6 +- cms/djangoapps/maintenance/tests.py | 4 +- lms/djangoapps/branding/tests/test_views.py | 2 +- .../bulk_email/tests/test_course_optout.py | 2 +- .../certificates/tests/test_views.py | 4 +- .../certificates/tests/test_webview_views.py | 92 +++++++++---------- .../courseware/tests/test_entrance_exam.py | 2 +- .../courseware/tests/test_navigation.py | 6 +- lms/djangoapps/courseware/tests/test_views.py | 2 +- .../dashboard/tests/test_sysadmin.py | 10 +- lms/djangoapps/instructor/tests/test_api.py | 18 ++-- .../tests/test_tasks_helper.py | 8 +- .../shoppingcart/tests/test_views.py | 10 +- 15 files changed, 87 insertions(+), 87 deletions(-) diff --git a/cms/djangoapps/contentstore/tests/test_export_git.py b/cms/djangoapps/contentstore/tests/test_export_git.py index 8b9e5f3b3f..a969968cac 100644 --- a/cms/djangoapps/contentstore/tests/test_export_git.py +++ b/cms/djangoapps/contentstore/tests/test_export_git.py @@ -88,7 +88,7 @@ class TestExportGit(CourseTestCase): modulestore().update_item(self.course_module, self.user.id) response = self.client.get('{}?action=push'.format(self.test_url)) - self.assertIn('Export Failed:', response.content.decode('utf-8')) + self.assertContains(response, 'Export Failed:') def test_exception_translation(self): """ @@ -107,7 +107,7 @@ class TestExportGit(CourseTestCase): self.make_bare_repo_with_course('test_repo') response = self.client.get('{}?action=push'.format(self.test_url)) - self.assertIn('Export Succeeded', response.content.decode('utf-8')) + self.assertContains(response, 'Export Succeeded') def test_repo_with_dots(self): """ @@ -115,7 +115,7 @@ class TestExportGit(CourseTestCase): """ self.make_bare_repo_with_course('test.repo') response = self.client.get('{}?action=push'.format(self.test_url)) - self.assertIn('Export Succeeded', response.content.decode('utf-8')) + self.assertContains(response, 'Export Succeeded') def test_dirty_repo(self): """ diff --git a/cms/djangoapps/contentstore/views/tests/test_library.py b/cms/djangoapps/contentstore/views/tests/test_library.py index c324fc8fd8..2b052db99c 100644 --- a/cms/djangoapps/contentstore/views/tests/test_library.py +++ b/cms/djangoapps/contentstore/views/tests/test_library.py @@ -341,4 +341,4 @@ class UnitTestLibraries(CourseTestCase): # Now extra_user should apear in the list: response = self.client.get(manage_users_url) self.assertEqual(response.status_code, 200) - self.assertIn(extra_user.username, response.content.decode('utf-8')) + self.assertContains(response, extra_user.username) diff --git a/cms/djangoapps/contentstore/views/tests/test_videos.py b/cms/djangoapps/contentstore/views/tests/test_videos.py index 4bcc27ab9e..d4f6ac2d6c 100644 --- a/cms/djangoapps/contentstore/views/tests/test_videos.py +++ b/cms/djangoapps/contentstore/views/tests/test_videos.py @@ -325,10 +325,10 @@ class VideosHandlerTestCase(VideoUploadTestMixin, CourseTestCase): response = self.client.get(self.url) self.assertEqual(response.status_code, 200) self.assertRegexpMatches(response["Content-Type"], "^text/html(;.*)?$") - self.assertIn(_get_default_video_image_url(), response.content.decode('utf-8')) + self.assertContains(response, _get_default_video_image_url()) # Crude check for presence of data in returned HTML for video in self.previous_uploads: - self.assertIn(video["edx_video_id"], response.content.decode('utf-8')) + self.assertContains(response, video["edx_video_id"]) self.assertNotContains(response, 'video_upload_pagination') @override_waffle_flag(ENABLE_VIDEO_UPLOAD_PAGINATION, active=True) @@ -338,7 +338,7 @@ class VideosHandlerTestCase(VideoUploadTestMixin, CourseTestCase): """ response = self.client.get(self.url) self.assertEqual(response.status_code, 200) - self.assertIn('video_upload_pagination', response.content.decode('utf-8')) + self.assertContains(response, 'video_upload_pagination') def test_post_non_json(self): response = self.client.post(self.url, {"files": []}) diff --git a/cms/djangoapps/maintenance/tests.py b/cms/djangoapps/maintenance/tests.py index 9887caa733..4135de466e 100644 --- a/cms/djangoapps/maintenance/tests.py +++ b/cms/djangoapps/maintenance/tests.py @@ -289,7 +289,7 @@ class TestAnnouncementsViews(MaintenanceViewTestCase): """ url = reverse("maintenance:announcement_index") response = self.client.get(url) - self.assertIn('
', response.content.decode('utf-8')) + self.assertContains(response, '
') def test_create(self): """ @@ -308,7 +308,7 @@ class TestAnnouncementsViews(MaintenanceViewTestCase): announcement.save() url = reverse("maintenance:announcement_edit", kwargs={"pk": announcement.pk}) response = self.client.get(url) - self.assertIn('
', response.content.decode('utf-8')) + self.assertContains(response, '
') self.client.post(url, {"content": "Test Edit Announcement", "active": True}) announcement = Announcement.objects.get(pk=announcement.pk) self.assertEquals(announcement.content, "Test Edit Announcement") diff --git a/lms/djangoapps/branding/tests/test_views.py b/lms/djangoapps/branding/tests/test_views.py index 9900e24aeb..628619afa9 100644 --- a/lms/djangoapps/branding/tests/test_views.py +++ b/lms/djangoapps/branding/tests/test_views.py @@ -315,4 +315,4 @@ class TestIndex(SiteMixin, TestCase): self.use_site(self.site_other) self.client.login(username=self.user.username, password="password") response = self.client.get(reverse("dashboard")) - self.assertIn(self.site_configuration_other.values["MKTG_URLS"]["ROOT"], response.content.decode('utf-8')) + self.assertContains(response, self.site_configuration_other.values["MKTG_URLS"]["ROOT"]) diff --git a/lms/djangoapps/bulk_email/tests/test_course_optout.py b/lms/djangoapps/bulk_email/tests/test_course_optout.py index 8407889567..ae705a7c3c 100644 --- a/lms/djangoapps/bulk_email/tests/test_course_optout.py +++ b/lms/djangoapps/bulk_email/tests/test_course_optout.py @@ -57,7 +57,7 @@ class TestOptoutCourseEmails(ModuleStoreTestCase): response = self.client.get(url) email_section = '
' # If this fails, it is likely because BulkEmailFlag.is_enabled() is set to False - self.assertIn(email_section, response.content.decode('utf-8')) + self.assertContains(response, email_section) def test_optout_course(self): """ diff --git a/lms/djangoapps/certificates/tests/test_views.py b/lms/djangoapps/certificates/tests/test_views.py index c008d877c4..9af3af3002 100644 --- a/lms/djangoapps/certificates/tests/test_views.py +++ b/lms/djangoapps/certificates/tests/test_views.py @@ -295,7 +295,7 @@ class CertificatesViewsSiteTests(ModuleStoreTestCase): self.assertIn( 'My Platform Site offers interactive online classes and MOOCs.', response.content.decode('utf-8') ) - self.assertIn('About My Platform Site', response.content.decode('utf-8')) + self.assertContains(response, 'About My Platform Site') @override_settings(FEATURES=FEATURES_WITH_CERTS_ENABLED) def test_html_view_site_configuration_missing(self): @@ -305,7 +305,7 @@ class CertificatesViewsSiteTests(ModuleStoreTestCase): ) self._add_course_certificates(count=1, signatory_count=2) response = self.client.get(test_url) - self.assertIn('edX', response.content.decode('utf-8')) + self.assertContains(response, 'edX') self.assertNotContains(response, 'My Platform Site') self.assertNotIn( 'This should not survive being overwritten by static content', response.content.decode('utf-8') diff --git a/lms/djangoapps/certificates/tests/test_webview_views.py b/lms/djangoapps/certificates/tests/test_webview_views.py index cd4e7563b0..a74e87f03e 100644 --- a/lms/djangoapps/certificates/tests/test_webview_views.py +++ b/lms/djangoapps/certificates/tests/test_webview_views.py @@ -319,8 +319,8 @@ class CertificatesViewsTests(CommonCertificatesTestCase, CacheIsolationTestCase) test_url = get_certificate_url(course_id=self.cert.course_id, uuid=self.cert.verify_uuid) response = self.client.get(test_url, HTTP_HOST='test.localhost') self.assertEqual(response.status_code, 200) - self.assertIn("Post on Facebook", response.content.decode('utf-8')) - self.assertIn('test_facebook_my_site', response.content.decode('utf-8')) + self.assertContains(response, "Post on Facebook") + self.assertContains(response, 'test_facebook_my_site') @override_settings(FEATURES=FEATURES_WITH_CERTS_ENABLED) @ddt.data( @@ -569,19 +569,19 @@ class CertificatesViewsTests(CommonCertificatesTestCase, CacheIsolationTestCase) course_id=six.text_type(self.course.id) ) response = self.client.get(test_url) - self.assertIn(str(self.cert.verify_uuid), response.content.decode('utf-8')) + self.assertContains(response, str(self.cert.verify_uuid)) # Hit any "verified" mode-specific branches self.cert.mode = 'verified' self.cert.save() response = self.client.get(test_url) - self.assertIn(str(self.cert.verify_uuid), response.content.decode('utf-8')) + self.assertContains(response, str(self.cert.verify_uuid)) # Hit any 'xseries' mode-specific branches self.cert.mode = 'xseries' self.cert.save() response = self.client.get(test_url) - self.assertIn(str(self.cert.verify_uuid), response.content.decode('utf-8')) + self.assertContains(response, str(self.cert.verify_uuid)) @override_settings(FEATURES=FEATURES_WITH_CERTS_ENABLED) def test_render_certificate_only_for_downloadable_status(self): @@ -597,15 +597,15 @@ class CertificatesViewsTests(CommonCertificatesTestCase, CacheIsolationTestCase) # Validate certificate response = self.client.get(test_url) - self.assertIn(str(self.cert.verify_uuid), response.content.decode('utf-8')) + self.assertContains(response, str(self.cert.verify_uuid)) # Change status to 'generating' and validate that Certificate Web View returns "Invalid Certificate" self.cert.status = CertificateStatuses.generating self.cert.save() response = self.client.get(test_url) - self.assertIn("Invalid Certificate", response.content.decode('utf-8')) - self.assertIn("Cannot Find Certificate", response.content.decode('utf-8')) - self.assertIn("We cannot find a certificate with this URL or ID number.", response.content.decode('utf-8')) + self.assertContains(response, "Invalid Certificate") + self.assertContains(response, "Cannot Find Certificate") + self.assertContains(response, "We cannot find a certificate with this URL or ID number.") @ddt.data( (CertificateStatuses.downloadable, True), @@ -632,11 +632,11 @@ class CertificatesViewsTests(CommonCertificatesTestCase, CacheIsolationTestCase) response = self.client.get(test_url) if eligible_for_certificate: - self.assertIn(str(self.cert.verify_uuid), response.content.decode('utf-8')) + self.assertContains(response, str(self.cert.verify_uuid)) else: - self.assertIn("Invalid Certificate", response.content.decode('utf-8')) - self.assertIn("Cannot Find Certificate", response.content.decode('utf-8')) - self.assertIn("We cannot find a certificate with this URL or ID number.", response.content.decode('utf-8')) + self.assertContains(response, "Invalid Certificate") + self.assertContains(response, "Cannot Find Certificate") + self.assertContains(response, "We cannot find a certificate with this URL or ID number.") self.assertNotContains(response, str(self.cert.verify_uuid)) @override_settings(FEATURES=FEATURES_WITH_CERTS_ENABLED) @@ -652,14 +652,14 @@ class CertificatesViewsTests(CommonCertificatesTestCase, CacheIsolationTestCase) # Validate certificate response = self.client.get(test_url) - self.assertIn(str(self.cert.verify_uuid), response.content.decode('utf-8')) + self.assertContains(response, str(self.cert.verify_uuid)) # invalidate certificate and verify that "Cannot Find Certificate" is returned self.cert.invalidate() response = self.client.get(test_url) - self.assertIn("Invalid Certificate", response.content.decode('utf-8')) - self.assertIn("Cannot Find Certificate", response.content.decode('utf-8')) - self.assertIn("We cannot find a certificate with this URL or ID number.", response.content.decode('utf-8')) + self.assertContains(response, "Invalid Certificate") + self.assertContains(response, "Cannot Find Certificate") + self.assertContains(response, "We cannot find a certificate with this URL or ID number.") @override_settings(FEATURES=FEATURES_WITH_CERTS_ENABLED) def test_html_lang_attribute_is_dynamic_for_invalid_certificate_html_view(self): @@ -677,12 +677,12 @@ class CertificatesViewsTests(CommonCertificatesTestCase, CacheIsolationTestCase) user_language = 'fr' self.client.cookies[settings.LANGUAGE_COOKIE] = user_language response = self.client.get(test_url) - self.assertIn('', response.content.decode('utf-8')) + self.assertContains(response, '') user_language = 'ar' self.client.cookies[settings.LANGUAGE_COOKIE] = user_language response = self.client.get(test_url) - self.assertIn('', response.content.decode('utf-8')) + self.assertContains(response, '') @override_settings(FEATURES=FEATURES_WITH_CERTS_ENABLED) def test_html_lang_attribute_is_dynamic_for_certificate_html_view(self): @@ -698,12 +698,12 @@ class CertificatesViewsTests(CommonCertificatesTestCase, CacheIsolationTestCase) user_language = 'fr' self.client.cookies[settings.LANGUAGE_COOKIE] = user_language response = self.client.get(test_url) - self.assertIn('', response.content.decode('utf-8')) + self.assertContains(response, '') user_language = 'ar' self.client.cookies[settings.LANGUAGE_COOKIE] = user_language response = self.client.get(test_url) - self.assertIn('', response.content.decode('utf-8')) + self.assertContains(response, '') @override_settings(FEATURES=FEATURES_WITH_CERTS_ENABLED) def test_html_view_for_non_viewable_certificate_and_for_student_user(self): @@ -730,9 +730,9 @@ class CertificatesViewsTests(CommonCertificatesTestCase, CacheIsolationTestCase) course_id=six.text_type(self.course.id) ) response = self.client.get(test_url) - self.assertIn("Invalid Certificate", response.content.decode('utf-8')) - self.assertIn("Cannot Find Certificate", response.content.decode('utf-8')) - self.assertIn("We cannot find a certificate with this URL or ID number.", response.content.decode('utf-8')) + self.assertContains(response, "Invalid Certificate") + self.assertContains(response, "Cannot Find Certificate") + self.assertContains(response, "We cannot find a certificate with this URL or ID number.") @override_settings(FEATURES=FEATURES_WITH_CERTS_ENABLED) def test_render_html_view_with_valid_signatories(self): @@ -743,11 +743,11 @@ class CertificatesViewsTests(CommonCertificatesTestCase, CacheIsolationTestCase) ) response = self.client.get(test_url) - self.assertIn('course_title_0', response.content.decode('utf-8')) - self.assertIn('Signatory_Name 0', response.content.decode('utf-8')) - self.assertIn('Signatory_Title 0', response.content.decode('utf-8')) - self.assertIn('Signatory_Organization 0', response.content.decode('utf-8')) - self.assertIn('/static/certificates/images/demo-sig0.png', response.content.decode('utf-8')) + self.assertContains(response, 'course_title_0') + self.assertContains(response, 'Signatory_Name 0') + self.assertContains(response, 'Signatory_Title 0') + self.assertContains(response, 'Signatory_Organization 0') + self.assertContains(response, '/static/certificates/images/demo-sig0.png') @override_settings(FEATURES=FEATURES_WITH_CERTS_ENABLED) def test_course_display_name_not_override_with_course_title(self): @@ -773,7 +773,7 @@ class CertificatesViewsTests(CommonCertificatesTestCase, CacheIsolationTestCase) response = self.client.get(test_url) self.assertNotContains(response, 'test_course_title_0') - self.assertIn('refundable course', response.content.decode('utf-8')) + self.assertContains(response, 'refundable course') @override_settings(FEATURES=FEATURES_WITH_CERTS_ENABLED) def test_course_display_overrides(self): @@ -794,8 +794,8 @@ class CertificatesViewsTests(CommonCertificatesTestCase, CacheIsolationTestCase) self.store.update_item(self.course, self.user.id) response = self.client.get(test_url) - self.assertIn('overridden_number', response.content.decode('utf-8')) - self.assertIn('overridden_org', response.content.decode('utf-8')) + self.assertContains(response, 'overridden_number') + self.assertContains(response, 'overridden_org') @override_settings(FEATURES=FEATURES_WITH_CERTS_ENABLED) def test_certificate_view_without_org_logo(self): @@ -858,7 +858,7 @@ class CertificatesViewsTests(CommonCertificatesTestCase, CacheIsolationTestCase) ) response = self.client.get(test_url) self.assertNotContains(response, '