Python Requirements Update (#29516)
* chore: Updating Python Requirements * fix: fix pylint issues Co-authored-by: Mohammad Ahtasham ul Hassan <mohammad.ahtasham@arbisoft.com>
This commit is contained in:
committed by
GitHub
parent
5d5a11fc16
commit
bb20b17428
@@ -409,7 +409,7 @@ class BookmarkModelTests(BookmarksTestsBase):
|
||||
# Block does not exist
|
||||
usage_key = UsageKey.from_string('i4x://edX/apis/html/interactive')
|
||||
usage_key.replace(course_key=self.course.id)
|
||||
assert Bookmark.get_path(usage_key) == []
|
||||
assert not Bookmark.get_path(usage_key)
|
||||
|
||||
# Block is an orphan
|
||||
self.other_sequential_1.children = []
|
||||
|
||||
@@ -663,7 +663,7 @@ class TestSessionEntitlement(CatalogIntegrationMixin, TestCase):
|
||||
)
|
||||
|
||||
session_entitlements = get_visible_sessions_for_entitlement(entitlement)
|
||||
assert session_entitlements == []
|
||||
assert not session_entitlements
|
||||
|
||||
|
||||
@skip_unless_lms
|
||||
@@ -780,10 +780,10 @@ class TestProgramCourseRunCrawling(TestCase):
|
||||
program = {
|
||||
'title': 'notice that I do not have a curriculum',
|
||||
}
|
||||
assert [] == child_programs(program)
|
||||
assert not child_programs(program)
|
||||
|
||||
def test_child_programs_no_children(self):
|
||||
assert [] == child_programs(self.empty_program)
|
||||
assert not child_programs(self.empty_program)
|
||||
|
||||
def test_child_programs_one_child(self):
|
||||
assert [self.grandchild_1] == child_programs(self.simple_program)
|
||||
|
||||
@@ -126,7 +126,7 @@ class TestSimulatePublish(SharedModuleStoreTestCase):
|
||||
assert self.course_key_1 in self.received_1
|
||||
assert self.course_key_2 in self.received_1
|
||||
assert self.course_key_3 in self.received_1
|
||||
assert self.received_2 == []
|
||||
assert not self.received_2
|
||||
|
||||
def test_course_overviews(self):
|
||||
"""Integration test with CourseOverviews."""
|
||||
@@ -140,8 +140,8 @@ class TestSimulatePublish(SharedModuleStoreTestCase):
|
||||
)
|
||||
)
|
||||
assert CourseOverview.objects.all().count() == 3
|
||||
assert self.received_1 == []
|
||||
assert self.received_2 == []
|
||||
assert not self.received_1
|
||||
assert not self.received_2
|
||||
|
||||
def sample_receiver_1(self, sender, course_key, **kwargs): # pylint: disable=unused-argument
|
||||
"""Custom receiver for testing."""
|
||||
|
||||
@@ -488,7 +488,7 @@ class TestCohorts(ModuleStoreTestCase):
|
||||
"""
|
||||
course = modulestore().get_course(self.toy_course_key)
|
||||
config_course_cohorts(course, is_cohorted=True)
|
||||
assert [] == cohorts.get_course_cohorts(course)
|
||||
assert not cohorts.get_course_cohorts(course)
|
||||
|
||||
def test_get_course_cohorts(self):
|
||||
"""
|
||||
|
||||
@@ -747,7 +747,7 @@ class CreditRequirementApiTests(CreditApiTestBase):
|
||||
# Since the requirement hasn't been published yet, it won't show
|
||||
# up in the list of requirements.
|
||||
req_status = api.get_credit_requirement_status(self.course_key, username, namespace="grade", name="grade")
|
||||
assert req_status == []
|
||||
assert not req_status
|
||||
|
||||
# Now add the requirements, simulating what happens when a course is published.
|
||||
requirements = [
|
||||
|
||||
@@ -212,7 +212,7 @@ class TestUserPreferenceMiddleware(CacheIsolationTestCase):
|
||||
result = self.middleware.process_response(self.request, response)
|
||||
|
||||
assert result is response
|
||||
assert response.mock_calls == []
|
||||
assert not response.mock_calls
|
||||
|
||||
def test_preference_update_noop(self):
|
||||
self.request.COOKIES[settings.LANGUAGE_COOKIE_NAME] = 'es'
|
||||
|
||||
@@ -105,9 +105,9 @@ class TestProgramProgressMeter(ModuleStoreTestCase):
|
||||
|
||||
meter = ProgramProgressMeter(self.site, self.user)
|
||||
|
||||
assert meter.engaged_programs == []
|
||||
assert not meter.engaged_programs
|
||||
self._assert_progress(meter)
|
||||
assert list(meter.completed_programs_with_available_dates.keys()) == []
|
||||
assert not list(meter.completed_programs_with_available_dates.keys())
|
||||
|
||||
def test_enrollments_but_no_programs(self, mock_get_programs):
|
||||
"""Verify behavior when enrollments exist, but no matching programs do."""
|
||||
@@ -117,9 +117,9 @@ class TestProgramProgressMeter(ModuleStoreTestCase):
|
||||
self._create_enrollments(course_run_id)
|
||||
meter = ProgramProgressMeter(self.site, self.user)
|
||||
|
||||
assert meter.engaged_programs == []
|
||||
assert not meter.engaged_programs
|
||||
self._assert_progress(meter)
|
||||
assert list(meter.completed_programs_with_available_dates.keys()) == []
|
||||
assert not list(meter.completed_programs_with_available_dates.keys())
|
||||
|
||||
def test_entitlements_but_no_programs(self, mock_get_programs):
|
||||
""" Verify engaged_programs is empty when entitlements exist, but no matching programs do. """
|
||||
@@ -128,7 +128,7 @@ class TestProgramProgressMeter(ModuleStoreTestCase):
|
||||
self._create_entitlements(uuid.uuid4())
|
||||
meter = ProgramProgressMeter(self.site, self.user)
|
||||
|
||||
assert meter.engaged_programs == []
|
||||
assert not meter.engaged_programs
|
||||
|
||||
def test_single_program_enrollment(self, mock_get_programs):
|
||||
"""
|
||||
@@ -158,7 +158,7 @@ class TestProgramProgressMeter(ModuleStoreTestCase):
|
||||
meter,
|
||||
ProgressFactory(uuid=program['uuid'], in_progress=1)
|
||||
)
|
||||
assert list(meter.completed_programs_with_available_dates.keys()) == []
|
||||
assert not list(meter.completed_programs_with_available_dates.keys())
|
||||
|
||||
def test_single_program_entitlement(self, mock_get_programs):
|
||||
"""
|
||||
@@ -375,7 +375,7 @@ class TestProgramProgressMeter(ModuleStoreTestCase):
|
||||
meter,
|
||||
*(ProgressFactory(uuid=program['uuid'], in_progress=1) for program in programs)
|
||||
)
|
||||
assert list(meter.completed_programs_with_available_dates.keys()) == []
|
||||
assert not list(meter.completed_programs_with_available_dates.keys())
|
||||
|
||||
def test_multiple_program_entitlement(self, mock_get_programs):
|
||||
"""
|
||||
@@ -443,7 +443,7 @@ class TestProgramProgressMeter(ModuleStoreTestCase):
|
||||
meter,
|
||||
*(ProgressFactory(uuid=program['uuid'], in_progress=1) for program in programs)
|
||||
)
|
||||
assert list(meter.completed_programs_with_available_dates.keys()) == []
|
||||
assert not list(meter.completed_programs_with_available_dates.keys())
|
||||
|
||||
def test_shared_entitlement_engagement(self, mock_get_programs):
|
||||
"""
|
||||
@@ -522,7 +522,7 @@ class TestProgramProgressMeter(ModuleStoreTestCase):
|
||||
# No enrollments, no programs in progress.
|
||||
meter = ProgramProgressMeter(self.site, self.user)
|
||||
self._assert_progress(meter)
|
||||
assert list(meter.completed_programs_with_available_dates.keys()) == []
|
||||
assert not list(meter.completed_programs_with_available_dates.keys())
|
||||
|
||||
# One enrollment, one program in progress.
|
||||
self._create_enrollments(first_course_run_key)
|
||||
@@ -532,7 +532,7 @@ class TestProgramProgressMeter(ModuleStoreTestCase):
|
||||
meter,
|
||||
ProgressFactory(uuid=program_uuid, in_progress=1, not_started=2)
|
||||
)
|
||||
assert list(meter.completed_programs_with_available_dates.keys()) == []
|
||||
assert not list(meter.completed_programs_with_available_dates.keys())
|
||||
|
||||
# 3 enrollments, 3 courses in progress.
|
||||
self._create_enrollments(second_course_run_key)
|
||||
@@ -545,7 +545,7 @@ class TestProgramProgressMeter(ModuleStoreTestCase):
|
||||
in_progress=3,
|
||||
)
|
||||
)
|
||||
assert list(meter.completed_programs_with_available_dates.keys()) == []
|
||||
assert not list(meter.completed_programs_with_available_dates.keys())
|
||||
|
||||
# One valid certificate earned, one course complete.
|
||||
self._create_certificates(first_course_run_key, mode=MODES.verified)
|
||||
@@ -558,7 +558,7 @@ class TestProgramProgressMeter(ModuleStoreTestCase):
|
||||
in_progress=2,
|
||||
)
|
||||
)
|
||||
assert list(meter.completed_programs_with_available_dates.keys()) == []
|
||||
assert not list(meter.completed_programs_with_available_dates.keys())
|
||||
|
||||
# Invalid certificate earned, still one course to complete. (invalid because mode doesn't match the course)
|
||||
second_cert = self._create_certificates(second_course_run_key, mode=MODES.honor)[0]
|
||||
@@ -572,7 +572,7 @@ class TestProgramProgressMeter(ModuleStoreTestCase):
|
||||
in_progress=2,
|
||||
)
|
||||
)
|
||||
assert list(meter.completed_programs_with_available_dates.keys()) == []
|
||||
assert not list(meter.completed_programs_with_available_dates.keys())
|
||||
|
||||
# Second valid certificate obtained, 2 courses complete.
|
||||
second_cert.mode = MODES.verified
|
||||
@@ -586,7 +586,7 @@ class TestProgramProgressMeter(ModuleStoreTestCase):
|
||||
in_progress=1,
|
||||
)
|
||||
)
|
||||
assert list(meter.completed_programs_with_available_dates.keys()) == []
|
||||
assert not list(meter.completed_programs_with_available_dates.keys())
|
||||
|
||||
# 3 certs, 1 unavailable, Program available in the future
|
||||
self._create_certificates(third_course_run_key, mode=MODES.verified)
|
||||
@@ -770,7 +770,7 @@ class TestProgramProgressMeter(ModuleStoreTestCase):
|
||||
|
||||
# Verify that the test program is not complete.
|
||||
meter = ProgramProgressMeter(self.site, self.user)
|
||||
assert list(meter.completed_programs_with_available_dates.keys()) == []
|
||||
assert not list(meter.completed_programs_with_available_dates.keys())
|
||||
|
||||
# Grant a 'no-id-professional' certificate for one of the course runs,
|
||||
# thereby completing the program.
|
||||
|
||||
@@ -211,8 +211,8 @@ class TestDeactivateLogout(RetirementTestCase):
|
||||
updated_user = User.objects.get(id=self.test_user.id)
|
||||
assert get_retired_email_by_email(self.test_user.email) == updated_user.email
|
||||
assert not updated_user.has_usable_password()
|
||||
assert list(UserSocialAuth.objects.filter(user=self.test_user)) == []
|
||||
assert list(Registration.objects.filter(user=self.test_user)) == []
|
||||
assert not list(UserSocialAuth.objects.filter(user=self.test_user))
|
||||
assert not list(Registration.objects.filter(user=self.test_user))
|
||||
assert len(UserRetirementStatus.objects.filter(user_id=self.test_user.id)) == 1
|
||||
# these retirement utils are tested elsewhere; just make sure we called them
|
||||
mock_retire_dot.assert_called_with(self.test_user)
|
||||
|
||||
@@ -197,7 +197,7 @@ class AccountSettingsViewTest(ThirdPartyAuthTestMixin, SiteMixin, ProgramsApiCon
|
||||
with mock_get_orders(exception=exceptions.HttpNotFoundError):
|
||||
order_detail = get_user_orders(self.user)
|
||||
|
||||
assert order_detail == []
|
||||
assert not order_detail
|
||||
|
||||
def test_incomplete_order_detail(self):
|
||||
response = {
|
||||
@@ -215,7 +215,7 @@ class AccountSettingsViewTest(ThirdPartyAuthTestMixin, SiteMixin, ProgramsApiCon
|
||||
with mock_get_orders(response=response):
|
||||
order_detail = get_user_orders(self.user)
|
||||
|
||||
assert order_detail == []
|
||||
assert not order_detail
|
||||
|
||||
def test_order_history_with_no_product(self):
|
||||
response = {
|
||||
|
||||
@@ -395,7 +395,7 @@ class TestEnterpriseApi(EnterpriseServiceMockMixin, CacheIsolationTestCase):
|
||||
assert request_mock.session['enterprise_customer']['uuid'] == str(enterprise_customer_uuid)
|
||||
|
||||
def test_get_enterprise_learner_data_from_db_no_data(self):
|
||||
assert [] == get_enterprise_learner_data_from_db(self.user)
|
||||
assert not get_enterprise_learner_data_from_db(self.user)
|
||||
|
||||
def test_get_enterprise_learner_data_from_db(self):
|
||||
enterprise_customer_user = EnterpriseCustomerUserFactory(user_id=self.user.id) # lint-amnesty, pylint: disable=unused-variable
|
||||
|
||||
Reference in New Issue
Block a user