From bb0effb75c53ba7f43336b4caf24d428b7abe8ac Mon Sep 17 00:00:00 2001 From: Clinton Blackburn Date: Thu, 5 Nov 2015 11:52:53 -0500 Subject: [PATCH] Updated Zendesk error handling Properly logging exceptions so we have the complete stacktrace. ECOM-2792 --- common/djangoapps/util/views.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/common/djangoapps/util/views.py b/common/djangoapps/util/views.py index e019e04e69..cfa37c62c9 100644 --- a/common/djangoapps/util/views.py +++ b/common/djangoapps/util/views.py @@ -175,8 +175,8 @@ def _record_feedback_in_zendesk(realname, email, subject, details, tags, additio } try: ticket_id = zendesk_api.create_ticket(new_ticket) - except zendesk.ZendeskError as err: - log.error("Error creating Zendesk ticket: %s", str(err)) + except zendesk.ZendeskError: + log.exception("Error creating Zendesk ticket") return False # Additional information is provided as a private update so the information @@ -184,8 +184,8 @@ def _record_feedback_in_zendesk(realname, email, subject, details, tags, additio ticket_update = {"ticket": {"comment": {"public": False, "body": additional_info_string}}} try: zendesk_api.update_ticket(ticket_id, ticket_update) - except zendesk.ZendeskError as err: - log.error("Error updating Zendesk ticket: %s", str(err)) + except zendesk.ZendeskError: + log.exception("Error updating Zendesk ticket") # The update is not strictly necessary, so do not indicate failure to the user pass