From 4277757961f933493a5055259de4e7bd5049e944 Mon Sep 17 00:00:00 2001 From: Richard Moch Date: Wed, 25 Mar 2015 15:33:22 +0000 Subject: [PATCH 1/4] set .response-header-actions block to absolute position to allow overlap with title --- lms/static/sass/discussion/views/_thread.scss | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lms/static/sass/discussion/views/_thread.scss b/lms/static/sass/discussion/views/_thread.scss index 4302a33b95..f4e465ce65 100644 --- a/lms/static/sass/discussion/views/_thread.scss +++ b/lms/static/sass/discussion/views/_thread.scss @@ -39,11 +39,13 @@ body.discussion, .discussion-module { .response-header-content { display: inline-block; vertical-align: top; - width: flex-grid(9,12); + width: flex-grid(11,12); } .response-header-actions { - width: flex-grid(3,12); + position: absolute; + right: ($baseline); + top: ($baseline); @include float(right); } } From e68b78452805309b740f89a87bc47ab0ae1b37cf Mon Sep 17 00:00:00 2001 From: Richard Moch Date: Wed, 25 Mar 2015 16:48:56 +0000 Subject: [PATCH 2/4] add Richard Moch to AUTHORS --- AUTHORS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/AUTHORS b/AUTHORS index 9feb4660c1..47bcffea3e 100644 --- a/AUTHORS +++ b/AUTHORS @@ -223,3 +223,5 @@ Tim Krones Linda Liu Alessandro Verdura Sven Marnach +Richard Moch + From d851c6ded3aca8ccef13b6625a80d7664268c08b Mon Sep 17 00:00:00 2001 From: Richard Moch Date: Mon, 30 Mar 2015 15:03:13 +0000 Subject: [PATCH 3/4] Improve support for right to left languages --- lms/static/sass/discussion/elements/_actions.scss | 1 + lms/static/sass/discussion/views/_thread.scss | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/lms/static/sass/discussion/elements/_actions.scss b/lms/static/sass/discussion/elements/_actions.scss index a6f0ca4e6b..308e48bb23 100644 --- a/lms/static/sass/discussion/elements/_actions.scss +++ b/lms/static/sass/discussion/elements/_actions.scss @@ -295,6 +295,7 @@ .action-button, .action-list-item { .action-label { + @include float(left); .label-checked { display: none; } diff --git a/lms/static/sass/discussion/views/_thread.scss b/lms/static/sass/discussion/views/_thread.scss index f4e465ce65..791bc717f1 100644 --- a/lms/static/sass/discussion/views/_thread.scss +++ b/lms/static/sass/discussion/views/_thread.scss @@ -44,7 +44,7 @@ body.discussion, .discussion-module { .response-header-actions { position: absolute; - right: ($baseline); + @include right($baseline); top: ($baseline); @include float(right); } From e455c3b7b7c4351033d274912728d935c0e9aef2 Mon Sep 17 00:00:00 2001 From: Richard Moch Date: Mon, 30 Mar 2015 15:04:08 +0000 Subject: [PATCH 4/4] Add background to focused labels for cleaner display --- lms/static/sass/discussion/elements/_actions.scss | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lms/static/sass/discussion/elements/_actions.scss b/lms/static/sass/discussion/elements/_actions.scss index 308e48bb23..fed7f3d40b 100644 --- a/lms/static/sass/discussion/elements/_actions.scss +++ b/lms/static/sass/discussion/elements/_actions.scss @@ -196,6 +196,7 @@ &:hover, &:focus { border-color: $blue-d2; + background-color: $white; .action-label { color: $blue-d2; @@ -216,6 +217,7 @@ &:hover, &:focus { border-color: $green-d1; + background-color: $white; .action-label { color: $green-d2; @@ -229,6 +231,7 @@ &:hover, &:focus { border-color: $gray; + background-color: $white; .action-icon { border: 1px solid $gray;