From ab4fd03dd8c5b42afcaa0258e27d51245d613671 Mon Sep 17 00:00:00 2001
From: Don Mitchell <dmitchell@edx.org>
Date: Wed, 30 Jan 2013 09:43:27 -0500
Subject: [PATCH] Catch any and all save errors

---
 .../js/models/settings/course_details.js      | 12 +++++-
 .../js/views/settings/main_settings_view.js   | 38 +++++++++++++++----
 2 files changed, 41 insertions(+), 9 deletions(-)

diff --git a/cms/static/js/models/settings/course_details.js b/cms/static/js/models/settings/course_details.js
index ab80179142..61e31133fd 100644
--- a/cms/static/js/models/settings/course_details.js
+++ b/cms/static/js/models/settings/course_details.js
@@ -68,10 +68,18 @@ CMS.Models.Settings.CourseDetails = Backbone.Model.extend({
 	save_videosource: function(newsource) {
 		// newsource either is <video youtube="speed:key, *"/> or just the "speed:key, *" string
 		// returns the videosource for the preview which iss the key whose speed is closest to 1
-		if (_.isEmpty(newsource) && !_.isEmpty(this.get('intro_video'))) this.save({'intro_video': null}); 
+		if (_.isEmpty(newsource) && !_.isEmpty(this.get('intro_video'))) this.save({'intro_video': null},
+				{ error : function(model, error) {
+					// this handler is for the client:server communication not the vlidation errors which handleValidationError catches
+					window.alert("Error during save: " + error.responseText);
+				}}); 
 		// TODO remove all whitespace w/in string
 		else {
-			if (this.get('intro_video') !== newsource) this.save('intro_video', newsource);
+			if (this.get('intro_video') !== newsource) this.save('intro_video', newsource,
+					{ error : function(model, error) {
+						// this handler is for the client:server communication not the vlidation errors which handleValidationError catches
+						window.alert("Error during save: " + error.responseText);
+					}});
 		}
 		
 		return this.videosourceSample();
diff --git a/cms/static/js/views/settings/main_settings_view.js b/cms/static/js/views/settings/main_settings_view.js
index 704623b56e..602da60ed6 100644
--- a/cms/static/js/views/settings/main_settings_view.js
+++ b/cms/static/js/views/settings/main_settings_view.js
@@ -57,7 +57,7 @@ CMS.Views.ValidatingView = Backbone.View.extend({
 			this.clearValidationErrors();
 			this.model.save(field, newVal, { error : function(model, error) {
 				// this handler is for the client:server communication not the vlidation errors which handleValidationError catches
-				if (error.responseText) window.alert("Error: " + error.responseText);
+				window.alert("Error during save: " + error.responseText);
 			}});
 			return true;
 		}
@@ -230,7 +230,11 @@ CMS.Views.Settings.Details = CMS.Views.ValidatingView.extend({
                     time = 0;
                 }
                 var newVal = new Date(date.getTime() + time * 1000);
-                if (cacheModel.get(fieldName) != newVal) cacheModel.save(fieldName, newVal);
+                if (cacheModel.get(fieldName) != newVal) cacheModel.save(fieldName, newVal,
+                		{ error : function(model, error) {
+            				// this handler is for the client:server communication not the vlidation errors which handleValidationError catches
+            				window.alert("Error during save: " + error.responseText);
+            			}});
             }
 		};
 		
@@ -279,7 +283,11 @@ CMS.Views.Settings.Details = CMS.Views.ValidatingView.extend({
 	},
 	
 	removeSyllabus: function() {
-		if (this.model.has('syllabus'))	this.model.save({'syllabus': null});
+		if (this.model.has('syllabus'))	this.model.save({'syllabus': null}, 
+				{ error : function(model, error) {
+					// this handler is for the client:server communication not the vlidation errors which handleValidationError catches
+					window.alert("Error during save: " + error.responseText);
+				}});
 	},
 	
 	assetSyllabus : function() {
@@ -312,7 +320,11 @@ CMS.Views.Settings.Details = CMS.Views.ValidatingView.extend({
 					mirror.save();
 					cachethis.clearValidationErrors();
 					var newVal = mirror.getValue();
-					if (cachethis.model.get(field) != newVal) cachethis.model.save(field, newVal);
+					if (cachethis.model.get(field) != newVal) cachethis.model.save(field, newVal,
+							{ error : function(model, error) {
+								// this handler is for the client:server communication not the vlidation errors which handleValidationError catches
+								window.alert("Error during save: " + error.responseText);
+							}});
 				}
 			});
 		}
@@ -407,7 +419,11 @@ CMS.Views.Settings.Grading = CMS.Views.ValidatingView.extend({
 	setGracePeriod : function(event) {
 		event.data.clearValidationErrors();
 		var newVal = event.data.model.dateToGracePeriod($(event.currentTarget).timepicker('getTime'));
-		if (event.data.model.get('grace_period') != newVal) event.data.model.save('grace_period', newVal);
+		if (event.data.model.get('grace_period') != newVal) event.data.model.save('grace_period', newVal,
+				{ error : function(model, error) {
+					// this handler is for the client:server communication not the vlidation errors which handleValidationError catches
+					window.alert("Error during save: " + error.responseText);
+				}});
 	},
 	updateModel : function(event) {
 		if (!this.selectorToField[event.currentTarget.id]) return;
@@ -543,7 +559,11 @@ CMS.Views.Settings.Grading = CMS.Views.ValidatingView.extend({
 					object[cutoff['designation']] = cutoff['cutoff'] / 100.0;
 					return object;
 				}, 
-				{}));
+				{}),
+				{ error : function(model, error) {
+					// this handler is for the client:server communication not the vlidation errors which handleValidationError catches
+					window.alert("Error during save: " + error.responseText);
+				}});
 	},
 	
 	addNewGrade: function(e) {
@@ -674,7 +694,11 @@ CMS.Views.Settings.GraderView = CMS.Views.ValidatingView.extend({
 		}
 	},
 	deleteModel : function(e) {
-		this.model.destroy();
+		this.model.destroy(
+				{ error : function(model, error) {
+					// this handler is for the client:server communication not the vlidation errors which handleValidationError catches
+					window.alert("Error during save: " + error.responseText);
+				}});
 		e.preventDefault();
 	}