From 220c1e2934aaf698ecb8127b3e21fadd13305153 Mon Sep 17 00:00:00 2001 From: Giovanni Di Milia Date: Wed, 14 Oct 2015 15:12:44 -0400 Subject: [PATCH] Fixed pylint violation for files in lms/djangoapps/ccx --- lms/djangoapps/ccx/tests/test_views.py | 16 ++++++++-------- lms/djangoapps/ccx/views.py | 9 ++++----- 2 files changed, 12 insertions(+), 13 deletions(-) diff --git a/lms/djangoapps/ccx/tests/test_views.py b/lms/djangoapps/ccx/tests/test_views.py index ad0d52da3f..ec12ce1bb6 100644 --- a/lms/djangoapps/ccx/tests/test_views.py +++ b/lms/djangoapps/ccx/tests/test_views.py @@ -10,23 +10,22 @@ from mock import patch, MagicMock from nose.plugins.attrib import attr from capa.tests.response_xml_factory import StringResponseXMLFactory -from courseware.courses import get_course_by_id # pyline: disable=import-error -from courseware.field_overrides import OverrideFieldData # pylint: disable=import-error -from courseware.tests.factories import StudentModuleFactory # pylint: disable=import-error -from courseware.tests.helpers import LoginEnrollmentTestCase # pylint: disable=import-error +from courseware.courses import get_course_by_id +from courseware.tests.factories import StudentModuleFactory +from courseware.tests.helpers import LoginEnrollmentTestCase from courseware.tabs import get_course_tab_list from django.core.urlresolvers import reverse from django.utils.timezone import UTC from django.test.utils import override_settings from django.test import RequestFactory -from edxmako.shortcuts import render_to_response # pylint: disable=import-error +from edxmako.shortcuts import render_to_response from request_cache.middleware import RequestCache -from student.roles import CourseCcxCoachRole # pylint: disable=import-error +from student.roles import CourseCcxCoachRole from student.models import ( CourseEnrollment, CourseEnrollmentAllowed, ) -from student.tests.factories import ( # pylint: disable=import-error +from student.tests.factories import ( AdminFactory, CourseEnrollmentFactory, UserFactory, @@ -638,7 +637,8 @@ class TestCCXGrades(SharedModuleStoreTestCase, LoginEnrollmentTestCase): metadata={'graded': True, 'format': 'Homework'}) for _ in xrange(4) ] - problems = [ + # making problems available at class level for possible future use in tests + cls.problems = [ [ ItemFactory.create( parent=section, diff --git a/lms/djangoapps/ccx/views.py b/lms/djangoapps/ccx/views.py index 4c54a8e1f3..f2a51259a0 100644 --- a/lms/djangoapps/ccx/views.py +++ b/lms/djangoapps/ccx/views.py @@ -36,12 +36,12 @@ from courseware.module_render import get_module_for_descriptor from edxmako.shortcuts import render_to_response from opaque_keys.edx.keys import CourseKey from ccx_keys.locator import CCXLocator -from student.roles import CourseCcxCoachRole # pylint: disable=import-error +from student.roles import CourseCcxCoachRole from student.models import CourseEnrollment -from instructor.offline_gradecalc import student_grades # pylint: disable=import-error -from instructor.views.api import _split_input_list # pylint: disable=import-error -from instructor.views.tools import get_student_from_identifier # pylint: disable=import-error +from instructor.offline_gradecalc import student_grades +from instructor.views.api import _split_input_list +from instructor.views.tools import get_student_from_identifier from instructor.enrollment import ( enroll_email, unenroll_email, @@ -50,7 +50,6 @@ from instructor.enrollment import ( from .models import CustomCourseForEdX from .overrides import ( - clear_override_for_ccx, get_override_for_ccx, override_field_for_ccx, clear_ccx_field_info_from_ccx_map,