From a65a486125854fcea7b0d04335a871f1ac49fa97 Mon Sep 17 00:00:00 2001 From: Mubbshar Anwar <78487564+mubbsharanwar@users.noreply.github.com> Date: Tue, 7 Dec 2021 14:11:21 +0500 Subject: [PATCH] fix: small fixes in save for later api (#29518) error code response convention update django request object for json data --- lms/djangoapps/save_for_later/api/v1/views.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/lms/djangoapps/save_for_later/api/v1/views.py b/lms/djangoapps/save_for_later/api/v1/views.py index eb60ff0579..10556860c3 100644 --- a/lms/djangoapps/save_for_later/api/v1/views.py +++ b/lms/djangoapps/save_for_later/api/v1/views.py @@ -60,10 +60,11 @@ class SaveForLaterApiView(APIView): } """ user = request.user - course_id = request.POST.get('course_id') - email = request.POST.get('email') - marketing_url = request.POST.get('marketing_url') - org_img_url = request.POST.get('org_img_url') + data = request.data + course_id = data.get('course_id') + email = data.get('email') + marketing_url = data.get('marketing_url') + org_img_url = data.get('org_img_url') course_key = CourseKey.from_string(course_id) @@ -81,7 +82,7 @@ class SaveForLaterApiView(APIView): course_id=course_id, ) except CourseOverview.DoesNotExist: - return Response({'error-code': 'course-not-found'}, status=404) + return Response({'error_code': 'course-not-found'}, status=404) site = Site.objects.get_current() message_context = get_base_template_context(site) @@ -115,6 +116,6 @@ class SaveForLaterApiView(APIView): ) except Exception: # pylint: disable=broad-except log.warning('Unable to send save for later email ', exc_info=True) - return Response({'error-code': 'email-not-send'}, status=400) + return Response({'error_code': 'email-not-send'}, status=400) else: return Response({'result': 'success'}, status=200)