Allow courses api to return data incrementally
Prior to this commit, the course api (/api/courses/v1/courses/) performed all the work necessary to return all courses available to the user, and then only actually returned on page's worth of those courses. With this change, the api now does the work incrementally, computing only the data needed to fetch the courses up to and including the page being returned. This still increases approximately linearly as the page number accessed being increases, but should be more cache-friendly. One side effect of this is that the max_page reported by pagination will be an overestimate (it will include pages that are removed due to a users access restrictions). This change also changes the sort-order of courses being returned by the course_api. By sorting by course-id, rather than course-number, we can sort in the database, rather than in Python, and defer loading data from the end of the list until it is requested. REVMI-90
This commit is contained in:
@@ -57,7 +57,7 @@ def course_detail(request, username, course_key):
|
||||
|
||||
def list_courses(request, username, org=None, filter_=None):
|
||||
"""
|
||||
Return a list of available courses.
|
||||
Yield all available courses.
|
||||
|
||||
The courses returned are all be visible to the user identified by
|
||||
`username` and the logged in user should have permission to view courses
|
||||
@@ -81,7 +81,7 @@ def list_courses(request, username, org=None, filter_=None):
|
||||
by the given key-value pairs.
|
||||
|
||||
Return value:
|
||||
List of `CourseOverview` objects representing the collection of courses.
|
||||
Yield `CourseOverview` objects representing the collection of courses.
|
||||
"""
|
||||
user = get_effective_user(request.user, username)
|
||||
return get_courses(user, org=org, filter_=filter_)
|
||||
|
||||
Reference in New Issue
Block a user