Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Overall Grade Range in Grading does not show consistant view when grades are removed

Browse Source 
TNL2159
This commit is contained in:
Awais Jibran
2015-05-27 23:06:17 +05:00
parent e8022c74f2
commit a2fc4bd216
3 changed files with 39 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
cms/static/js/views/settings/grading.js
View File

@@ -233,6 +233,28 @@ var GradingView = ValidatingView.extend({
};
},
renderGradeLabels: function(){
// When a grade is removed, keep the remaining grades consistent.
var _this = this;
if (_this.descendingCutoffs.length === 1 && _this.descendingCutoffs[0]['designation'] === _this.GRADES[0]) {
_this.descendingCutoffs[0]['designation'] = 'Pass';
_this.setTopGradeLabel();
} else {
_.each(_this.descendingCutoffs, function(cutoff, index) {
cutoff['designation'] = _this.GRADES[index];
});
_this.updateDomGradeLabels();
}
},
updateDomGradeLabels: function(){
// Update the DOM elements (Grades)
var _this = this;
var gradeElements = this.$el.find('.grades .letter-grade[contenteditable=true]');
_.each(gradeElements, function(element, index) {
if (index !== 0 ) $(element).text(_this.GRADES[index])
});
},
saveCutoffs: function() {
this.model.set('grade_cutoffs',
_.reduce(this.descendingCutoffs,
@@ -292,12 +314,9 @@ var GradingView = ValidatingView.extend({
this.descendingCutoffs.splice(index, 1);
domElement.remove();
if (this.descendingCutoffs.length === 1 && this.descendingCutoffs[0]['designation'] === this.GRADES[0]) {
this.descendingCutoffs[0]['designation'] = 'Pass';
this.setTopGradeLabel();
}
this.setFailLabel();
this.renderGradeRanges();
this.renderGradeLabels();
this.saveCutoffs();
},