From a13587af3aa32517d282dec30580e67f891f2ab9 Mon Sep 17 00:00:00 2001
From: Chris Deery <3932645+cdeery@users.noreply.github.com>
Date: Tue, 7 Sep 2021 12:52:06 -0400
Subject: [PATCH] feat: AA-940 Remove split_test from Masquerade dropdown
 (#28501)

* feat: [AA-940] Remove split_test from Masquerade dropdown
Filter content groups that are not part of a cohort from the selection
available to the select in the Masquerade bar.

Refs AA-940

Co-authored-by: cdeery <cdeery@edx.edu>
---
 lms/djangoapps/courseware/masquerade.py       |  4 +-
 .../courseware/tests/test_masquerade.py       | 40 +++++++++++++++++++
 2 files changed, 43 insertions(+), 1 deletion(-)

diff --git a/lms/djangoapps/courseware/masquerade.py b/lms/djangoapps/courseware/masquerade.py
index 1be4d75c0a..b681826154 100644
--- a/lms/djangoapps/courseware/masquerade.py
+++ b/lms/djangoapps/courseware/masquerade.py
@@ -142,7 +142,9 @@ class MasqueradeView(View):
             'user_name': course.user_name or '',
         })
         for partition in partitions:
-            if partition.active:
+            # "random" scheme implies a split_test content group, not a cohort
+            # and masquerading only cares about user cohorts
+            if partition.active and partition.scheme.name != "random":
                 data['available'].extend([
                     {
                         'group_id': group.id,
diff --git a/lms/djangoapps/courseware/tests/test_masquerade.py b/lms/djangoapps/courseware/tests/test_masquerade.py
index a625e6e173..79de1474d8 100644
--- a/lms/djangoapps/courseware/tests/test_masquerade.py
+++ b/lms/djangoapps/courseware/tests/test_masquerade.py
@@ -25,6 +25,7 @@ from lms.djangoapps.courseware.masquerade import (
     get_masquerading_user_group,
     setup_masquerade,
 )
+
 from lms.djangoapps.courseware.tests.helpers import LoginEnrollmentTestCase, MasqueradeMixin, masquerade_as_group_member
 from lms.djangoapps.courseware.tests.test_submitting_problems import ProblemSubmissionTestMixin
 from openedx.core.djangoapps.lang_pref import LANGUAGE_KEY
@@ -243,6 +244,45 @@ class TestMasqueradeLearnerOptions(StaffMasqueradeTestCase):
             assert partitions_enabled != is_learner_available
 
 
+@ddt.ddt
+class TestMasqueradeOptionsNoContentGroups(StaffMasqueradeTestCase):
+    """
+    Test that split_test content groups (which are the partitions with a "random" scheme),
+    do not show up in the masquerade options popup, but cohort groups do appear.
+    """
+
+    def setUp(self):
+        super().setUp()
+
+        self.user_partition = UserPartition(
+            0, 'Test User Partition', '',
+            [Group(0, 'Cohort Group 1'), Group(1, 'Cohort Group 2')],
+            scheme_id='cohort'
+        )
+        self.course.user_partitions.append(self.user_partition)
+        self.user_partition = UserPartition(
+            0, 'Test User Partition 2', '',
+            [Group(0, 'Content Group 1'), Group(1, 'Content Group 2')],
+            scheme_id='random'
+        )
+        self.course.user_partitions.append(self.user_partition)
+
+        modulestore().update_item(self.course, self.test_user.id)
+
+    @ddt.data(['Cohort Group 1', True], ['Content Group 1', False])
+    @ddt.unpack
+    @patch.dict('django.conf.settings.FEATURES', {'ENABLE_MASQUERADE': True})
+    def testMasqueradeCohortAvailable(self, target, expected):
+        """
+        Args:
+            target: The partition to check for in masquerade options
+            expected: Whether to partition should be in the list
+        """
+        response = self.get_available_masquerade_identities()
+        is_target_available = target in map(itemgetter('name'), response.json()['available'])
+        assert is_target_available == expected
+
+
 class TestStaffMasqueradeAsStudent(StaffMasqueradeTestCase):
     """
     Check for staff being able to masquerade as student.