From a06ac2f6a2869db7dc859b2c825029e09fccb370 Mon Sep 17 00:00:00 2001 From: salman2013 Date: Wed, 27 Sep 2023 11:42:57 +0500 Subject: [PATCH] chore: remove karma --- pavelib/paver_tests/test_js_test.py | 120 +++++++++++++------------- pavelib/utils/test/suites/js_suite.py | 86 +++++++++--------- 2 files changed, 103 insertions(+), 103 deletions(-) diff --git a/pavelib/paver_tests/test_js_test.py b/pavelib/paver_tests/test_js_test.py index 9d89a94444..a066a3ea19 100644 --- a/pavelib/paver_tests/test_js_test.py +++ b/pavelib/paver_tests/test_js_test.py @@ -55,15 +55,15 @@ class TestPaverJavaScriptTestTasks(PaverTestCase): ["--suite=lms"], ["--suite=lms --coverage"], ) - @ddt.unpack - def test_test_js_run(self, options_string): - """ - Test the "test_js_run" task. - """ - options = self.parse_options_string(options_string) - self.reset_task_messages() - call_task("pavelib.js_test.test_js_run", options=options) - self.verify_messages(options=options, dev_mode=False) + # @ddt.unpack + # def test_test_js_run(self, options_string): + # """ + # Test the "test_js_run" task. + # """ + # options = self.parse_options_string(options_string) + # self.reset_task_messages() + # call_task("pavelib.js_test.test_js_run", options=options) + # self.verify_messages(options=options, dev_mode=False) @ddt.data( [""], @@ -71,15 +71,15 @@ class TestPaverJavaScriptTestTasks(PaverTestCase): ["--suite=lms"], ["--suite=lms --port=9999"], ) - @ddt.unpack - def test_test_js_dev(self, options_string): - """ - Test the "test_js_run" task. - """ - options = self.parse_options_string(options_string) - self.reset_task_messages() - call_task("pavelib.js_test.test_js_dev", options=options) - self.verify_messages(options=options, dev_mode=True) + # @ddt.unpack + # def test_test_js_dev(self, options_string): + # """ + # Test the "test_js_run" task. + # """ + # options = self.parse_options_string(options_string) + # self.reset_task_messages() + # call_task("pavelib.js_test.test_js_dev", options=options) + # self.verify_messages(options=options, dev_mode=True) def parse_options_string(self, options_string): """ @@ -101,50 +101,50 @@ class TestPaverJavaScriptTestTasks(PaverTestCase): "port": port, } - def verify_messages(self, options, dev_mode): - """ - Verify that the messages generated when running tests are as expected - for the specified options and dev_mode. - """ - is_coverage = options['coverage'] - port = options['port'] - expected_messages = [] - suites = Env.JS_TEST_ID_KEYS if options['suite'] == 'all' else [options['suite']] + # def verify_messages(self, options, dev_mode): + # """ + # Verify that the messages generated when running tests are as expected + # for the specified options and dev_mode. + # """ + # is_coverage = options['coverage'] + # port = options['port'] + # expected_messages = [] + # suites = Env.JS_TEST_ID_KEYS if options['suite'] == 'all' else [options['suite']] - expected_messages.extend(self.EXPECTED_COMMANDS) - if not dev_mode and not is_coverage: - expected_messages.append(self.EXPECTED_DELETE_JAVASCRIPT_REPORT_COMMAND.format( - platform_root=self.platform_root - )) - expected_messages.append(self.EXPECTED_INSTALL_NPM_ASSETS_COMMAND) + # expected_messages.extend(self.EXPECTED_COMMANDS) + # if not dev_mode and not is_coverage: + # expected_messages.append(self.EXPECTED_DELETE_JAVASCRIPT_REPORT_COMMAND.format( + # platform_root=self.platform_root + # )) + # expected_messages.append(self.EXPECTED_INSTALL_NPM_ASSETS_COMMAND) - command_template = ( - 'node --max_old_space_size=4096 node_modules/.bin/karma start {options}' - ) + # command_template = ( + # 'node --max_old_space_size=4096 node_modules/.bin/karma start {options}' + # ) - for suite in suites: - # Karma test command - if suite != 'jest-snapshot': - karma_config_file = Env.KARMA_CONFIG_FILES[Env.JS_TEST_ID_KEYS.index(suite)] - expected_test_tool_command = command_template.format( - options=self.EXPECTED_KARMA_OPTIONS.format( - config_file=karma_config_file, - single_run='false' if dev_mode else 'true', - suite=suite, - platform_root=self.platform_root, - browser=Env.KARMA_BROWSER, - ), - ) - if is_coverage: - expected_test_tool_command += self.EXPECTED_COVERAGE_OPTIONS.format( - platform_root=self.platform_root, - suite=suite - ) - if port: - expected_test_tool_command += f" --port={port}" - else: - expected_test_tool_command = 'jest' + # for suite in suites: + # # Karma test command + # if suite != 'jest-snapshot': + # karma_config_file = Env.KARMA_CONFIG_FILES[Env.JS_TEST_ID_KEYS.index(suite)] + # expected_test_tool_command = command_template.format( + # options=self.EXPECTED_KARMA_OPTIONS.format( + # config_file=karma_config_file, + # single_run='false' if dev_mode else 'true', + # suite=suite, + # platform_root=self.platform_root, + # browser=Env.KARMA_BROWSER, + # ), + # ) + # if is_coverage: + # expected_test_tool_command += self.EXPECTED_COVERAGE_OPTIONS.format( + # platform_root=self.platform_root, + # suite=suite + # ) + # if port: + # expected_test_tool_command += f" --port={port}" + # else: + # expected_test_tool_command = 'jest' - expected_messages.append(expected_test_tool_command) + # expected_messages.append(expected_test_tool_command) - assert self.task_messages == expected_messages + # assert self.task_messages == expected_messages diff --git a/pavelib/utils/test/suites/js_suite.py b/pavelib/utils/test/suites/js_suite.py index 65c5feaf84..b7099c591f 100644 --- a/pavelib/utils/test/suites/js_suite.py +++ b/pavelib/utils/test/suites/js_suite.py @@ -47,55 +47,55 @@ class JsTestSuite(TestSuite): return [JsTestSubSuite(test_id, **self.opts) for test_id in Env.JS_TEST_ID_KEYS if test_id != 'jest-snapshot'] -class JsTestSubSuite(TestSuite): - """ - Class for JS suites like cms, cms-squire, lms, common, - common-requirejs and xmodule - """ - def __init__(self, *args, **kwargs): - super().__init__(*args, **kwargs) - self.test_id = args[0] - self.run_under_coverage = kwargs.get('with_coverage', True) - self.mode = kwargs.get('mode', 'run') - self.port = kwargs.get('port') - self.root = self.root + ' javascript' - self.report_dir = Env.JS_REPORT_DIR +# class JsTestSubSuite(TestSuite): +# """ +# Class for JS suites like cms, cms-squire, lms, common, +# common-requirejs and xmodule +# """ +# def __init__(self, *args, **kwargs): +# super().__init__(*args, **kwargs) +# self.test_id = args[0] +# self.run_under_coverage = kwargs.get('with_coverage', True) +# self.mode = kwargs.get('mode', 'run') +# self.port = kwargs.get('port') +# self.root = self.root + ' javascript' +# self.report_dir = Env.JS_REPORT_DIR - try: - self.test_conf_file = Env.KARMA_CONFIG_FILES[Env.JS_TEST_ID_KEYS.index(self.test_id)] - except ValueError: - self.test_conf_file = Env.KARMA_CONFIG_FILES[0] +# try: +# self.test_conf_file = Env.KARMA_CONFIG_FILES[Env.JS_TEST_ID_KEYS.index(self.test_id)] +# except ValueError: +# self.test_conf_file = Env.KARMA_CONFIG_FILES[0] - self.coverage_report = self.report_dir / f'coverage-{self.test_id}.xml' - self.xunit_report = self.report_dir / f'javascript_xunit-{self.test_id}.xml' +# self.coverage_report = self.report_dir / f'coverage-{self.test_id}.xml' +# self.xunit_report = self.report_dir / f'javascript_xunit-{self.test_id}.xml' - @property - def cmd(self): - """ - Run the tests using karma runner. - """ - cmd = [ - "node", - "--max_old_space_size=4096", - "node_modules/.bin/karma", - "start", - self.test_conf_file, - "--single-run={}".format('false' if self.mode == 'dev' else 'true'), - "--capture-timeout=60000", - f"--junitreportpath={self.xunit_report}", - f"--browsers={Env.KARMA_BROWSER}", - ] +# @property +# def cmd(self): +# """ +# Run the tests using karma runner. +# """ +# cmd = [ +# "node", +# "--max_old_space_size=4096", +# "node_modules/.bin/karma", +# "start", +# self.test_conf_file, +# "--single-run={}".format('false' if self.mode == 'dev' else 'true'), +# "--capture-timeout=60000", +# f"--junitreportpath={self.xunit_report}", +# f"--browsers={Env.KARMA_BROWSER}", +# ] - if self.port: - cmd.append(f"--port={self.port}") +# if self.port: +# cmd.append(f"--port={self.port}") - if self.run_under_coverage: - cmd.extend([ - "--coverage", - f"--coveragereportpath={self.coverage_report}", - ]) +# if self.run_under_coverage: +# cmd.extend([ +# "--coverage", +# f"--coveragereportpath={self.coverage_report}", +# ]) - return cmd +# return cmd class JestSnapshotTestSuite(TestSuite):