From 9e366fe202a6cb17614ff770fcbdff62b8da983f Mon Sep 17 00:00:00 2001
From: Andy Armstrong <andya@edx.org>
Date: Thu, 4 Sep 2014 09:39:34 -0400
Subject: [PATCH] Show cohorts on the new instructor dashboard

TNL-161

Remove placeholder text
---
 .../instructor/views/instructor_dashboard.py  |  1 +
 lms/static/js/collections/cohort.js           | 11 ++++
 lms/static/js/models/cohort.js                | 11 ++++
 lms/static/js/spec/views/cohorts_spec.js      | 64 +++++++++++++++++++
 lms/static/js/views/cohort_editor.js          | 16 +++++
 lms/static/js/views/cohorts.js                | 35 ++++++++++
 lms/static/js_test.yml                        |  9 ++-
 lms/static/templates                          |  1 +
 .../cohort-editor.underscore                  |  6 ++
 .../instructor_dashboard_2/cohorts.underscore | 35 ++++++++++
 .../instructor_dashboard_2.html               | 17 ++++-
 .../instructor_dashboard_2/membership.html    | 30 ++++++++-
 12 files changed, 230 insertions(+), 6 deletions(-)
 create mode 100644 lms/static/js/collections/cohort.js
 create mode 100644 lms/static/js/models/cohort.js
 create mode 100644 lms/static/js/spec/views/cohorts_spec.js
 create mode 100644 lms/static/js/views/cohort_editor.js
 create mode 100644 lms/static/js/views/cohorts.js
 create mode 120000 lms/static/templates
 create mode 100644 lms/templates/instructor/instructor_dashboard_2/cohort-editor.underscore
 create mode 100644 lms/templates/instructor/instructor_dashboard_2/cohorts.underscore

diff --git a/lms/djangoapps/instructor/views/instructor_dashboard.py b/lms/djangoapps/instructor/views/instructor_dashboard.py
index ca7aec3ecf..3025e1cfdb 100644
--- a/lms/djangoapps/instructor/views/instructor_dashboard.py
+++ b/lms/djangoapps/instructor/views/instructor_dashboard.py
@@ -253,6 +253,7 @@ def _section_membership(course_key, access):
         'modify_access_url': reverse('modify_access', kwargs={'course_id': course_key.to_deprecated_string()}),
         'list_forum_members_url': reverse('list_forum_members', kwargs={'course_id': course_key.to_deprecated_string()}),
         'update_forum_role_membership_url': reverse('update_forum_role_membership', kwargs={'course_id': course_key.to_deprecated_string()}),
+        'cohorts_ajax_url': reverse('cohorts', kwargs={'course_key_string': course_key.to_deprecated_string()}),
     }
     return section_data
 
diff --git a/lms/static/js/collections/cohort.js b/lms/static/js/collections/cohort.js
new file mode 100644
index 0000000000..c4d83788b3
--- /dev/null
+++ b/lms/static/js/collections/cohort.js
@@ -0,0 +1,11 @@
+(function(Backbone) {
+    var CohortCollection = Backbone.Collection.extend({
+        model : this.CohortModel,
+        comparator: "name",
+
+        parse: function(response) {
+            return response.cohorts;
+        }
+    });
+    this.CohortCollection = CohortCollection;
+}).call(this, Backbone);
diff --git a/lms/static/js/models/cohort.js b/lms/static/js/models/cohort.js
new file mode 100644
index 0000000000..32d929027a
--- /dev/null
+++ b/lms/static/js/models/cohort.js
@@ -0,0 +1,11 @@
+(function(Backbone) {
+    var CohortModel = Backbone.Model.extend({
+        idAttribute: 'id',
+        defaults: {
+            name: '',
+            user_count: 0
+        }
+    });
+
+    this.CohortModel = CohortModel;
+}).call(this, Backbone);
diff --git a/lms/static/js/spec/views/cohorts_spec.js b/lms/static/js/spec/views/cohorts_spec.js
new file mode 100644
index 0000000000..d1bdc377a7
--- /dev/null
+++ b/lms/static/js/spec/views/cohorts_spec.js
@@ -0,0 +1,64 @@
+describe("Cohorts View", function() {
+    var createMockCohorts, createCohortsView, installTemplateFixture;
+
+    createMockCohorts = function() {
+        return {
+            cohorts: [{
+                id: 1,
+                name: 'Cat Lovers',
+                user_count: 123
+            },{
+                id: 2,
+                name: 'Dog Lovers',
+                user_count: 456
+            }]
+        };
+    };
+
+    createCohortsView = function() {
+        var cohorts, view;
+        cohorts = new CohortCollection(createMockCohorts(), {parse: true});
+        view = new CohortsView({
+            model: cohorts
+        });
+        view.render();
+        return view;
+    };
+
+    installTemplateFixture = function(templateName, templateDirectory) {
+        var templateFixture = readFixtures(templateDirectory + templateName + '.underscore');
+        appendSetFixtures($('<script>', { id: templateName + '-tpl', type: 'text/template' })
+            .text(templateFixture));
+    };
+
+    beforeEach(function() {
+        setFixtures("<div></div>");
+        installTemplateFixture('cohort-editor', 'templates/instructor/instructor_dashboard_2/');
+        installTemplateFixture('cohorts', 'templates/instructor/instructor_dashboard_2/');
+    });
+
+    describe("Cohort Selector", function() {
+        it('has no initial selection', function() {
+            var view = createCohortsView();
+            expect(view.$('.cohort-select').val()).toBe('');
+            expect(view.$('.cohort-management-group-header .title-value').text()).toBe('');
+        });
+
+        it('can select a cohort', function() {
+            var view = createCohortsView();
+            view.$('.cohort-select').val("1").change();
+            expect(view.$('.cohort-select').val()).toBe('1');
+            expect(view.$('.cohort-management-group-header .title-value').text()).toBe('Cat Lovers');
+            expect(view.$('.cohort-management-group-header .group-count').text()).toBe('123');
+        });
+
+        it('can switch cohort', function() {
+            var view = createCohortsView();
+            view.$('.cohort-select').val("1").change();
+            view.$('.cohort-select').val("2").change();
+            expect(view.$('.cohort-select').val()).toBe('2');
+            expect(view.$('.cohort-management-group-header .title-value').text()).toBe('Dog Lovers');
+            expect(view.$('.cohort-management-group-header .group-count').text()).toBe('456');
+        });
+    });
+});
diff --git a/lms/static/js/views/cohort_editor.js b/lms/static/js/views/cohort_editor.js
new file mode 100644
index 0000000000..33766bc80d
--- /dev/null
+++ b/lms/static/js/views/cohort_editor.js
@@ -0,0 +1,16 @@
+(function(Backbone) {
+    var CohortEditorView = Backbone.View.extend({
+        initialize: function() {
+            this.template = _.template($('#cohort-editor-tpl').text());
+        },
+
+        render: function() {
+            this.$el.html(this.template({
+                cohort: this.model
+            }));
+            return this;
+        }
+    });
+
+    this.CohortEditorView = CohortEditorView;
+}).call(this, Backbone);
diff --git a/lms/static/js/views/cohorts.js b/lms/static/js/views/cohorts.js
new file mode 100644
index 0000000000..e3f84c8f08
--- /dev/null
+++ b/lms/static/js/views/cohorts.js
@@ -0,0 +1,35 @@
+(function(Backbone, CohortEditorView) {
+    var CohortsView = Backbone.View.extend({
+        events : {
+            "change .cohort-select": "showCohortEditor"
+        },
+
+        initialize: function() {
+            this.template = _.template($('#cohorts-tpl').text());
+        },
+
+        render: function() {
+            this.$el.html(this.template({
+                cohorts: this.model.models
+            }));
+            return this;
+        },
+
+        getSelectedCohort: function() {
+            var id = this.$('.cohort-select').val();
+            return this.model.get(parseInt(id));
+        },
+
+        showCohortEditor: function(event) {
+            event.preventDefault();
+            var selectedCohort = this.getSelectedCohort();
+            this.editor = new CohortEditorView({
+                el: this.$('.cohort-management-group'),
+                model: selectedCohort
+            });
+            this.editor.render();
+        }
+    });
+
+    this.CohortsView = CohortsView;
+}).call(this, Backbone, CohortEditorView);
diff --git a/lms/static/js_test.yml b/lms/static/js_test.yml
index 06132bb559..6ae9bd2f2f 100644
--- a/lms/static/js_test.yml
+++ b/lms/static/js_test.yml
@@ -46,11 +46,16 @@ lib_paths:
     - xmodule_js/src/capa/
     - xmodule_js/src/video/
     - xmodule_js/src/xmodule.js
+    - xmodule_js/common_static/js/vendor/underscore-min.js
+    - xmodule_js/common_static/js/vendor/backbone-min.js
+    - js/models/cohort.js
+    - js/collections/cohort.js
+    - js/views/cohort_editor.js
+    - js/views/cohorts.js
 
 # Paths to source JavaScript files
 src_paths:
     - coffee/src
-    - js/src
     - js
 
 # Paths to spec (test) JavaScript files
@@ -69,7 +74,7 @@ spec_paths:
 #
 fixture_paths:
     - coffee/fixtures
-    - js/fixtures
+    - templates/instructor/instructor_dashboard_2
 
 # Regular expressions used to exclude *.js files from
 # appearing in the test runner page.
diff --git a/lms/static/templates b/lms/static/templates
new file mode 120000
index 0000000000..564a409d41
--- /dev/null
+++ b/lms/static/templates
@@ -0,0 +1 @@
+../templates
\ No newline at end of file
diff --git a/lms/templates/instructor/instructor_dashboard_2/cohort-editor.underscore b/lms/templates/instructor/instructor_dashboard_2/cohort-editor.underscore
new file mode 100644
index 0000000000..69e024bd16
--- /dev/null
+++ b/lms/templates/instructor/instructor_dashboard_2/cohort-editor.underscore
@@ -0,0 +1,6 @@
+<header class="cohort-management-group-header">
+    <h3 class="group-header-title">
+        <span class="title-value"><%- cohort.get('name') %></span>
+        <span class="group-count"><%- cohort.get('user_count') %></span>
+    </h3>
+</header>
diff --git a/lms/templates/instructor/instructor_dashboard_2/cohorts.underscore b/lms/templates/instructor/instructor_dashboard_2/cohorts.underscore
new file mode 100644
index 0000000000..7c1824f1b5
--- /dev/null
+++ b/lms/templates/instructor/instructor_dashboard_2/cohorts.underscore
@@ -0,0 +1,35 @@
+<h2 class="section-title">
+    <span class="value"><%- gettext('Cohort Management') %></span>
+    <span class="description"></span>
+</h2>
+
+<!-- nav -->
+<% if (cohorts.length > 0) { %>
+    <div class="cohort-management-nav">
+        <form action="" method="post" name="" id="cohort-management-nav-form" class="cohort-management-nav-form">
+
+            <div class="cohort-management-nav-form-select field field-select">
+                <label for="cohort-select" class="label sr">${_("Select a cohort to manage")}</label>
+
+                <select class="input cohort-select" name="cohort-select" id="cohort-select">
+                    <option value=""><%- gettext('Select a cohort') %></option>
+                    <% _.each(cohorts, function(cohort) { %>
+                        <%
+                        var label = interpolate(
+                            gettext('%(cohort_name)s (%(user_count)s)'),
+                            { cohort_name: cohort.get('name'), user_count: cohort.get('user_count') },
+                            true
+                        );
+                        %>
+                        <option value="<%- cohort.get('id') %>"><%- label %></option>
+                    <% }); %>
+                </select>
+            </div>
+
+            <button class="form-submit button action-primary action-view sr"><%- gettext('View cohort group') %></button>
+        </form>
+    </div>
+
+    <!-- individual group -->
+    <div class="cohort-management-group"></div>
+<% } %>
diff --git a/lms/templates/instructor/instructor_dashboard_2/instructor_dashboard_2.html b/lms/templates/instructor/instructor_dashboard_2/instructor_dashboard_2.html
index 4b12593e2c..19f2a49ab8 100644
--- a/lms/templates/instructor/instructor_dashboard_2/instructor_dashboard_2.html
+++ b/lms/templates/instructor/instructor_dashboard_2/instructor_dashboard_2.html
@@ -33,12 +33,12 @@
     }
   </script>
   <script type="text/javascript" src="${static.url('js/vendor/underscore-min.js')}"></script>
+  <script type="text/javascript" src="${static.url('js/vendor/backbone-min.js')}"></script>
   <script type="text/javascript" src="${static.url('js/vendor/mustache.js')}"></script>
   <script type="text/javascript" src="${static.url('js/vendor/flot/jquery.flot.js')}"></script>
   <script type="text/javascript" src="${static.url('js/vendor/flot/jquery.flot.axislabels.js')}"></script>
   <script type="text/javascript" src="${static.url('js/vendor/jquery-jvectormap-1.1.1/jquery-jvectormap-1.1.1.min.js')}"></script>
   <script type="text/javascript" src="${static.url('js/vendor/jquery-jvectormap-1.1.1/jquery-jvectormap-world-mill-en.js')}"></script>
-  <script type="text/javascript" src="${static.url('js/course_groups/cohorts.js')}"></script>
   <script type="text/javascript" src="${static.url('js/vendor/jquery.event.drag-2.2.js')}"></script>
   <script type="text/javascript" src="${static.url('js/vendor/jquery.event.drop-2.2.js')}"></script>
   <script type="text/javascript" src="${static.url('js/vendor/slick.core.js')}"></script>
@@ -50,6 +50,21 @@
   <script type="text/javascript" src="${static.url('js/vendor/tinymce/js/tinymce/jquery.tinymce.min.js')}"></script>
   <%static:js group='module-descriptor-js'/>
   <%static:js group='instructor_dash'/>
+
+  ## Backbone classes declared explicitly until RequireJS is supported
+  <script type="text/javascript" src="${static.url('js/models/cohort.js')}"></script>
+  <script type="text/javascript" src="${static.url('js/collections/cohort.js')}"></script>
+  <script type="text/javascript" src="${static.url('js/views/cohort_editor.js')}"></script>
+  <script type="text/javascript" src="${static.url('js/views/cohorts.js')}"></script>
+</%block>
+
+## Include Underscore templates
+<%block name="header_extras">
+% for template_name in ["cohorts", "cohort-editor"]:
+<script type="text/template" id="${template_name}-tpl">
+  <%static:include path="instructor/instructor_dashboard_2/${template_name}.underscore" />
+</script>
+% endfor
 </%block>
 
 ## NOTE that instructor is set as the active page so that the instructor button lights up, even though this is the instructor_2 page.
diff --git a/lms/templates/instructor/instructor_dashboard_2/membership.html b/lms/templates/instructor/instructor_dashboard_2/membership.html
index 03aff4a163..13ffd499d2 100644
--- a/lms/templates/instructor/instructor_dashboard_2/membership.html
+++ b/lms/templates/instructor/instructor_dashboard_2/membership.html
@@ -26,7 +26,6 @@
   </div>
 </script>
 
-<div class="vert-left">
 <div class="batch-enrollment">
   <h2> ${_("Batch Enrollment")} </h2>
   <p>
@@ -112,9 +111,8 @@
   <div class="request-response-error"></div>
 </div>
 %endif
-</div>
 
-<div class="vert-right member-lists-management">
+<div class="member-lists-management">
   ## Translators: an "Administration List" is a list, such as Course Staff, that users can be added to.
   <h2> ${_("Administration List Management")} </h2>
 
@@ -216,3 +214,29 @@
   %endif
 
 </div>
+
+%if course.is_cohorted:
+<hr class="divider" />
+<div class="cohort-management membership-section" data-ajax_url="${section_data['cohorts_ajax_url']}">
+</div>
+% endif
+
+<%block name="headextra">
+    <script>
+    $(document).ready(function() {
+        var cohortManagementElement = $('.cohort-management');
+        if (cohortManagementElement.length > 0) {
+            var cohorts = new CohortCollection();
+            cohorts.url = cohortManagementElement.data('ajax_url');
+            var cohortsView = new CohortsView({
+                el: cohortManagementElement,
+                model: cohorts
+            });
+            cohortsView.render();
+            cohorts.fetch().done(function() {
+                cohortsView.render();
+            });
+        }
+    });
+    </script>
+</%block>