From 9dc6cdbda0d60ee78ae1f35e3e1b0f2875d79a5a Mon Sep 17 00:00:00 2001
From: Calen Pennington <calen.pennington@gmail.com>
Date: Wed, 24 Oct 2012 15:18:03 -0400
Subject: [PATCH] Remove vestigial save-subsection button

---
 cms/static/js/base.js              | 15 ++++++---------
 cms/templates/edit_subsection.html |  4 +---
 2 files changed, 7 insertions(+), 12 deletions(-)

diff --git a/cms/static/js/base.js b/cms/static/js/base.js
index 17a0b33ca3..cf0b49ef90 100644
--- a/cms/static/js/base.js
+++ b/cms/static/js/base.js
@@ -33,7 +33,6 @@ $(document).ready(function() {
 
     $('.unit .item-actions .delete-button').bind('click', deleteUnit);
     $('.new-unit-item').bind('click', createNewUnit);
-    $('.save-subsection').bind('click', saveSubsection);
 
     // autosave when a field is updated on the subsection page
     $body.on('keyup', '.subsection-display-name-input, .unit-subtitle, .policy-list-value', checkForNewValue);
@@ -169,7 +168,7 @@ function savePolicyMetadata(e) {
     e.preventDefault();
 
     var $policyElement = $(this).parents('.policy-list-element');
-    $('.save-subsection').click();
+    saveSubsection()
     $policyElement.removeClass('new-policy-list-element');
     $policyElement.find('.policy-list-name').attr('disabled', 'disabled');
     $policyElement.removeClass('editing');
@@ -202,7 +201,7 @@ function removePolicyMetadata(e) {
     } else {
         _parent_el.appendTo("#policy-to-delete");
     }
-    $('.save-subsection').click();
+    saveSubsection()
 }
 
 
@@ -299,7 +298,7 @@ function checkForNewValue(e) {
 
         this.saveTimer = setTimeout(function() {
             $changedInput = $(e.target);
-            $('.save-subsection').click();
+            saveSubsection()
             this.saveTimer = null;
         }, 500);
     }
@@ -312,14 +311,12 @@ function autosaveInput(e) {
 
     this.saveTimer = setTimeout(function() {        
         $changedInput = $(e.target);
-        $('.save-subsection').click();
+        saveSubsection()
         this.saveTimer = null;
     }, 500);
 }
 
-function saveSubsection(e) {
-    e.preventDefault();
-
+function saveSubsection() {
     if($changedInput && !$changedInput.hasClass('no-spinner')) {
         $spinner.css({
             'position': 'absolute',
@@ -331,7 +328,7 @@ function saveSubsection(e) {
         $spinner.show();
     }
     
-    var id = $(this).data('id');
+    var id = $('.subsection-body').data('id');
 
     // pull all 'normalized' metadata editable fields on page
     var metadata_fields = $('input[data-metadata-name]');
diff --git a/cms/templates/edit_subsection.html b/cms/templates/edit_subsection.html
index b3e4031822..e1dd91c162 100644
--- a/cms/templates/edit_subsection.html
+++ b/cms/templates/edit_subsection.html
@@ -18,7 +18,7 @@
 <div class="main-wrapper">
   <div class="inner-wrapper">
     <div class="main-column">
-      <article class="subsection-body window">
+      <article class="subsection-body window" data-id="${subsection.location}">
         <div class="subsection-name-input">
           <label>Display Name:</label>
           <input type="text" value="${subsection.metadata['display_name']}" class="subsection-display-name-input" data-metadata-name="display_name"/>
@@ -37,7 +37,6 @@
               % for policy_name in policy_metadata.keys():
               <li class="policy-list-element">
                   <input type="text" class="policy-list-name" name="${policy_name}" value="${policy_name}" disabled size="15"/>:&nbsp;<input type="text" class="policy-list-value" name="${policy_metadata[policy_name]}" value="${policy_metadata[policy_name]}" size="40"/>
-                  <a href="#" class="save-button">Save</a>
                   <a href="#" class="cancel-button">Cancel</a>
                   <a href="#" class="delete-icon remove-policy-data"></a>
               </li>
@@ -101,7 +100,6 @@
       </div>
     </div>
     <div class="row unit-actions">
-      <a href="#" class="save-button save-subsection" data-id="${subsection.location}">Save</a>
       <a href="${preview_link}" target="_blank" class="preview-button">Preview Drafts</a>
       %if can_view_live:
       <a href="${lms_link}" target="_blank" class="preview-button">View Live</a>