From 92d502510e14822df88d85b39c30072de69c7714 Mon Sep 17 00:00:00 2001 From: muzaffaryousaf Date: Fri, 7 Oct 2016 15:30:06 +0500 Subject: [PATCH] Fixing flaky test_studio_help_links TNL-4954 --- common/test/acceptance/pages/studio/utils.py | 15 +++++++++++---- .../acceptance/tests/studio/test_studio_help.py | 1 - 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/common/test/acceptance/pages/studio/utils.py b/common/test/acceptance/pages/studio/utils.py index 6160497305..2a29899709 100644 --- a/common/test/acceptance/pages/studio/utils.py +++ b/common/test/acceptance/pages/studio/utils.py @@ -246,11 +246,18 @@ def verify_ordering(test_class, page, expected_orderings): def click_studio_help(page): - """Click the Studio help link in the page footer.""" - page.q(css='.cta-show-sock').click() + """ + Click the Studio help link in the page footer. + """ + help_link_selector = '.cta-show-sock' + # check if help link is visible + EmptyPromise(lambda: page.q(css=help_link_selector).visible, "Help link visible").fulfill() + + page.q(css=help_link_selector).click() + + # check if extended support section is visible. EmptyPromise( - lambda: page.q(css='.support .list-actions a').results[0].text != '', - 'Support section opened' + lambda: page.q(css='.support .list-actions a').results[0].text != '', 'Support section opened' ).fulfill() diff --git a/common/test/acceptance/tests/studio/test_studio_help.py b/common/test/acceptance/tests/studio/test_studio_help.py index dcfcfeee39..2e65773625 100644 --- a/common/test/acceptance/tests/studio/test_studio_help.py +++ b/common/test/acceptance/tests/studio/test_studio_help.py @@ -39,7 +39,6 @@ from common.test.acceptance.pages.studio.auto_auth import AutoAuthPage class StudioHelpTest(StudioCourseTest): """Tests for Studio help.""" - @flaky # TODO: TNL-4954 def test_studio_help_links(self): """Test that the help links are present and have the correct content.""" page = DashboardPage(self.browser)