From 87ddb56bbb9c57d6bb2b104d03a0f60ca523f278 Mon Sep 17 00:00:00 2001 From: Tasawer Nawaz Date: Mon, 16 Jul 2018 18:31:55 +0500 Subject: [PATCH] fix exception handling in award program certificate task LEARNER-4467 --- openedx/core/djangoapps/programs/tasks/v1/tasks.py | 2 +- openedx/core/djangoapps/programs/tasks/v1/tests/test_tasks.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/openedx/core/djangoapps/programs/tasks/v1/tasks.py b/openedx/core/djangoapps/programs/tasks/v1/tasks.py index 7018715762..401cdd159f 100644 --- a/openedx/core/djangoapps/programs/tasks/v1/tasks.py +++ b/openedx/core/djangoapps/programs/tasks/v1/tasks.py @@ -173,7 +173,7 @@ def award_program_certificates(self, username): try: award_program_certificate(credentials_client, username, program_uuid) LOGGER.info('Awarded certificate for program %s to user %s', program_uuid, username) - except exceptions.HttpNotFoundError: + except exceptions.HttpClientError: LOGGER.exception( 'Certificate for program %s not configured, unable to award certificate to %s', program_uuid, username diff --git a/openedx/core/djangoapps/programs/tasks/v1/tests/test_tasks.py b/openedx/core/djangoapps/programs/tasks/v1/tests/test_tasks.py index 0a0dbedde0..44075b86fc 100644 --- a/openedx/core/djangoapps/programs/tasks/v1/tests/test_tasks.py +++ b/openedx/core/djangoapps/programs/tasks/v1/tests/test_tasks.py @@ -301,7 +301,7 @@ class AwardProgramCertificatesTestCase(CatalogIntegrationMixin, CredentialsApiCo mock_get_completed_programs.return_value = [1, 2] mock_get_certified_programs.side_effect = [[], [2]] mock_award_program_certificate.side_effect = self._make_side_effect( - [exceptions.HttpNotFoundError(), None] + [exceptions.HttpClientError(), None] ) tasks.award_program_certificates.delay(self.student.username).get()