From 9c81004fc7cdf546d5a488e0ae97fcbccc464df0 Mon Sep 17 00:00:00 2001 From: David Baumgold Date: Wed, 17 Sep 2014 10:40:30 -0400 Subject: [PATCH] Remove test cleanups Since `ddt` should make them unnecessary --- common/djangoapps/external_auth/tests/test_shib.py | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/common/djangoapps/external_auth/tests/test_shib.py b/common/djangoapps/external_auth/tests/test_shib.py index 780d4e1e19..3b9668aedc 100644 --- a/common/djangoapps/external_auth/tests/test_shib.py +++ b/common/djangoapps/external_auth/tests/test_shib.py @@ -299,9 +299,6 @@ class ShibSPTest(ModuleStoreTestCase): else: self.assertNotContains(response, fullname_input_html) - # clean up b/c we don't want existing ExternalAuthMap for the next run - client.session['ExternalAuthMap'].delete() - @unittest.skipUnless(settings.FEATURES.get('AUTH_USE_SHIB'), "AUTH_USE_SHIB not set") @data(*gen_all_identities()) def test_registration_form_submit(self, identity): @@ -381,12 +378,6 @@ class ShibSPTest(ModuleStoreTestCase): self.assertEqual(profile.name, request2.session['ExternalAuthMap'].external_name) self.assertEqual(profile.name, identity.get('displayName').decode('utf-8')) - # clean up for next loop - request2.session['ExternalAuthMap'].delete() - UserProfile.objects.filter(user=user).delete() - Registration.objects.filter(user=user).delete() - user.delete() - @unittest.skipUnless(settings.FEATURES.get('AUTH_USE_SHIB'), "AUTH_USE_SHIB not set") @data("", "shib:https://idp.stanford.edu/") def test_course_specific_login_and_reg(self, domain): @@ -532,8 +523,6 @@ class ShibSPTest(ModuleStoreTestCase): if course is open_enroll_course or student is shib_student: self.assertEqual(response.status_code, 200) self.assertTrue(CourseEnrollment.is_enrolled(student, course.id)) - # Clean up - CourseEnrollment.unenroll(student, course.id) else: self.assertEqual(response.status_code, 400) self.assertFalse(CourseEnrollment.is_enrolled(student, course.id))