From 9becd565b303fd9eeb56083332c03cdc0609fa6f Mon Sep 17 00:00:00 2001 From: AlasdairSwan Date: Tue, 10 May 2016 08:57:09 -0400 Subject: [PATCH] If not certificates remove the container element from the DOM --- common/test/acceptance/pages/lms/programs.py | 2 +- lms/static/js/learner_dashboard/views/certificate_view.js | 6 ++++++ .../js/spec/learner_dashboard/certificate_view_spec.js | 4 +--- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/common/test/acceptance/pages/lms/programs.py b/common/test/acceptance/pages/lms/programs.py index ae43a0ba99..08efd8558a 100644 --- a/common/test/acceptance/pages/lms/programs.py +++ b/common/test/acceptance/pages/lms/programs.py @@ -19,4 +19,4 @@ class ProgramListingPage(PageObject): @property def is_sidebar_present(self): """Check whether sidebar is present.""" - return self.q(css='.sidebar').present and self.q(css='.certificates-list').present + return self.q(css='.sidebar').present diff --git a/lms/static/js/learner_dashboard/views/certificate_view.js b/lms/static/js/learner_dashboard/views/certificate_view.js index e706bd1fc7..db823e0e07 100644 --- a/lms/static/js/learner_dashboard/views/certificate_view.js +++ b/lms/static/js/learner_dashboard/views/certificate_view.js @@ -25,6 +25,12 @@ if (certificatesData.length) { this.$el.html(this.tpl(this.context)); + } else { + /** + * If not rendering remove el because + * styles are applied to it + */ + this.remove(); } } }); diff --git a/lms/static/js/spec/learner_dashboard/certificate_view_spec.js b/lms/static/js/spec/learner_dashboard/certificate_view_spec.js index 51c9e99df1..7378c9cf4a 100644 --- a/lms/static/js/spec/learner_dashboard/certificate_view_spec.js +++ b/lms/static/js/spec/learner_dashboard/certificate_view_spec.js @@ -50,15 +50,13 @@ define([ }); it('should display no certificate box if certificates list is empty', function() { - var $certificate; view.remove(); setFixtures('
'); view = new CertificateView({ context: {certificatesData: []} }); view.render(); - $certificate = view.$el.find('.certificate-link'); - expect($certificate.length).toBe(0); + expect(view.$('.certificates-list').length).toBe(0); }); }); }