From 5b38f9d4acb4b114ec5b2ec8eba69a432c4f21f4 Mon Sep 17 00:00:00 2001 From: Bridger Maxwell Date: Mon, 20 Aug 2012 14:15:41 -0400 Subject: [PATCH 1/4] Removed empty sidebar from Progress page. --- lms/templates/progress.html | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lms/templates/progress.html b/lms/templates/progress.html index 6b01e5896d..5ce86d04c2 100644 --- a/lms/templates/progress.html +++ b/lms/templates/progress.html @@ -81,9 +81,5 @@ ${profile_graphs.body(grade_summary, course.grade_cutoffs, "grade-detail-graph") - -
- -
From ee3f46fd3022bc44817d05839f83475ca05987b0 Mon Sep 17 00:00:00 2001 From: Bridger Maxwell Date: Mon, 20 Aug 2012 14:19:47 -0400 Subject: [PATCH 2/4] Changed titles on course pages. --- lms/templates/courseware.html | 2 +- lms/templates/info.html | 2 ++ lms/templates/progress.html | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lms/templates/courseware.html b/lms/templates/courseware.html index 92c6c9707c..9aa1836e93 100644 --- a/lms/templates/courseware.html +++ b/lms/templates/courseware.html @@ -1,7 +1,7 @@ <%inherit file="main.html" /> <%namespace name='static' file='static_content.html'/> <%block name="bodyclass">courseware -<%block name="title">Courseware – MITx 6.002x +<%block name="title">${course.number} Courseware <%block name="headextra"> <%static:css group='course'/> diff --git a/lms/templates/info.html b/lms/templates/info.html index a04e31896f..a2b94a2b98 100644 --- a/lms/templates/info.html +++ b/lms/templates/info.html @@ -5,6 +5,8 @@ <%static:css group='course'/> +<%block name="title">${course.number} Course Info + <%include file="course_navigation.html" args="active_page='info'" /> <%! from courseware.courses import get_course_info_section diff --git a/lms/templates/progress.html b/lms/templates/progress.html index 5ce86d04c2..d9608d7cea 100644 --- a/lms/templates/progress.html +++ b/lms/templates/progress.html @@ -7,7 +7,7 @@ <%namespace name="profile_graphs" file="profile_graphs.js"/> -<%block name="title">Progress - edX 6.002x +<%block name="title">${course.number} Progress <%! from django.core.urlresolvers import reverse From 0ac5ded095daf57fe97fc517c71653c57be45a5d Mon Sep 17 00:00:00 2001 From: Bridger Maxwell Date: Mon, 20 Aug 2012 14:45:33 -0400 Subject: [PATCH 3/4] Moved the course template pages to be templates/courseware/ --- lms/djangoapps/courseware/views.py | 12 +++---- .../{ => courseware}/course_navigation.html | 0 .../{ => courseware}/courseware.html | 8 ++--- .../{ => courseware}/grade_summary.html | 6 ++-- lms/templates/{ => courseware}/gradebook.html | 6 ++-- lms/templates/{ => courseware}/info.html | 6 ++-- .../instructor_dashboard.html | 6 ++-- lms/templates/{ => courseware}/progress.html | 10 +++--- .../progress_graph.js} | 0 lms/templates/gradebook_profilegraphs.html | 31 ------------------- lms/templates/wiki/base.html | 2 +- 11 files changed, 28 insertions(+), 59 deletions(-) rename lms/templates/{ => courseware}/course_navigation.html (100%) rename lms/templates/{ => courseware}/courseware.html (90%) rename lms/templates/{ => courseware}/grade_summary.html (61%) rename lms/templates/{ => courseware}/gradebook.html (94%) rename lms/templates/{ => courseware}/info.html (88%) rename lms/templates/{ => courseware}/instructor_dashboard.html (74%) rename lms/templates/{ => courseware}/progress.html (89%) rename lms/templates/{profile_graphs.js => courseware/progress_graph.js} (100%) delete mode 100644 lms/templates/gradebook_profilegraphs.html diff --git a/lms/djangoapps/courseware/views.py b/lms/djangoapps/courseware/views.py index cedd7f642a..314562aeb8 100644 --- a/lms/djangoapps/courseware/views.py +++ b/lms/djangoapps/courseware/views.py @@ -154,7 +154,7 @@ def index(request, course_id, chapter=None, section=None, # Add a list of all the errors... context['course_errors'] = modulestore().get_item_errors(course.location) - result = render_to_response('courseware.html', context) + result = render_to_response('courseware/courseware.html', context) except: # In production, don't want to let a 500 out for any reason if settings.DEBUG: @@ -215,7 +215,7 @@ def course_info(request, course_id): course = get_course_with_access(request.user, course_id, 'load') staff_access = has_access(request.user, course, 'staff') - return render_to_response('info.html', {'course': course, + return render_to_response('courseware/info.html', {'course': course, 'staff_access': staff_access,}) @@ -288,7 +288,7 @@ def progress(request, course_id, student_id=None): } context.update() - return render_to_response('progress.html', context) + return render_to_response('courseware/progress.html', context) @@ -316,7 +316,7 @@ def gradebook(request, course_id): } for student in enrolled_students] - return render_to_response('gradebook.html', {'students': student_info, + return render_to_response('courseware/gradebook.html', {'students': student_info, 'course': course, 'course_id': course_id, # Checked above @@ -331,7 +331,7 @@ def grade_summary(request, course_id): # For now, just a static page context = {'course': course, 'staff_access': True,} - return render_to_response('grade_summary.html', context) + return render_to_response('courseware/grade_summary.html', context) @cache_control(no_cache=True, no_store=True, must_revalidate=True) @@ -342,5 +342,5 @@ def instructor_dashboard(request, course_id): # For now, just a static page context = {'course': course, 'staff_access': True,} - return render_to_response('instructor_dashboard.html', context) + return render_to_response('courseware/instructor_dashboard.html', context) diff --git a/lms/templates/course_navigation.html b/lms/templates/courseware/course_navigation.html similarity index 100% rename from lms/templates/course_navigation.html rename to lms/templates/courseware/course_navigation.html diff --git a/lms/templates/courseware.html b/lms/templates/courseware/courseware.html similarity index 90% rename from lms/templates/courseware.html rename to lms/templates/courseware/courseware.html index 9aa1836e93..e1d6d11f37 100644 --- a/lms/templates/courseware.html +++ b/lms/templates/courseware/courseware.html @@ -1,5 +1,5 @@ -<%inherit file="main.html" /> -<%namespace name='static' file='static_content.html'/> +<%inherit file="/main.html" /> +<%namespace name='static' file='/static_content.html'/> <%block name="bodyclass">courseware <%block name="title">${course.number} Courseware @@ -21,7 +21,7 @@ <%static:js group='courseware'/> - <%include file="mathjax_include.html" /> + <%include file="/mathjax_include.html" /> -<%include file="course_navigation.html" args="active_page='courseware'" /> +<%include file="/courseware/course_navigation.html" args="active_page='courseware'" />
diff --git a/lms/templates/grade_summary.html b/lms/templates/courseware/grade_summary.html similarity index 61% rename from lms/templates/grade_summary.html rename to lms/templates/courseware/grade_summary.html index 3fdcd910ae..e5f91d9ddf 100644 --- a/lms/templates/grade_summary.html +++ b/lms/templates/courseware/grade_summary.html @@ -1,8 +1,8 @@ -<%inherit file="main.html" /> +<%inherit file="/main.html" /> <%! from django.core.urlresolvers import reverse %> -<%namespace name='static' file='static_content.html'/> +<%namespace name='static' file='/static_content.html'/> -<%include file="course_navigation.html" args="active_page=''" /> +<%include file="/courseware/course_navigation.html" args="active_page=''" />
diff --git a/lms/templates/gradebook.html b/lms/templates/courseware/gradebook.html similarity index 94% rename from lms/templates/gradebook.html rename to lms/templates/courseware/gradebook.html index 5cb4e12701..20426041c4 100644 --- a/lms/templates/gradebook.html +++ b/lms/templates/courseware/gradebook.html @@ -1,6 +1,6 @@ -<%inherit file="main.html" /> +<%inherit file="/main.html" /> <%! from django.core.urlresolvers import reverse %> -<%namespace name='static' file='static_content.html'/> +<%namespace name='static' file='/static_content.html'/> <%block name="js_extra"> @@ -28,7 +28,7 @@ -<%include file="course_navigation.html" args="active_page=''" /> +<%include file="/courseware/course_navigation.html" args="active_page=''" />
diff --git a/lms/templates/info.html b/lms/templates/courseware/info.html similarity index 88% rename from lms/templates/info.html rename to lms/templates/courseware/info.html index a2b94a2b98..33195f985e 100644 --- a/lms/templates/info.html +++ b/lms/templates/courseware/info.html @@ -1,5 +1,5 @@ -<%inherit file="main.html" /> -<%namespace name='static' file='static_content.html'/> +<%inherit file="/main.html" /> +<%namespace name='static' file='/static_content.html'/> <%block name="headextra"> <%static:css group='course'/> @@ -7,7 +7,7 @@ <%block name="title">${course.number} Course Info -<%include file="course_navigation.html" args="active_page='info'" /> +<%include file="/courseware/course_navigation.html" args="active_page='info'" /> <%! from courseware.courses import get_course_info_section %> diff --git a/lms/templates/instructor_dashboard.html b/lms/templates/courseware/instructor_dashboard.html similarity index 74% rename from lms/templates/instructor_dashboard.html rename to lms/templates/courseware/instructor_dashboard.html index 6b87f63031..9508624f9b 100644 --- a/lms/templates/instructor_dashboard.html +++ b/lms/templates/courseware/instructor_dashboard.html @@ -1,12 +1,12 @@ -<%inherit file="main.html" /> +<%inherit file="/main.html" /> <%! from django.core.urlresolvers import reverse %> -<%namespace name='static' file='static_content.html'/> +<%namespace name='static' file='/static_content.html'/> <%block name="headextra"> <%static:css group='course'/> -<%include file="course_navigation.html" args="active_page='instructor'" /> +<%include file="/courseware/course_navigation.html" args="active_page='instructor'" />
diff --git a/lms/templates/progress.html b/lms/templates/courseware/progress.html similarity index 89% rename from lms/templates/progress.html rename to lms/templates/courseware/progress.html index d9608d7cea..86649a2e91 100644 --- a/lms/templates/progress.html +++ b/lms/templates/courseware/progress.html @@ -1,11 +1,11 @@ -<%inherit file="main.html" /> -<%namespace name='static' file='static_content.html'/> +<%inherit file="/main.html" /> +<%namespace name='static' file='/static_content.html'/> <%block name="headextra"> <%static:css group='course'/> -<%namespace name="profile_graphs" file="profile_graphs.js"/> +<%namespace name="progress_graph" file="/courseware/progress_graph.js"/> <%block name="title">${course.number} Progress @@ -18,11 +18,11 @@ -<%include file="course_navigation.html" args="active_page='progress'" /> +<%include file="/courseware/course_navigation.html" args="active_page='progress'" />
diff --git a/lms/templates/profile_graphs.js b/lms/templates/courseware/progress_graph.js similarity index 100% rename from lms/templates/profile_graphs.js rename to lms/templates/courseware/progress_graph.js diff --git a/lms/templates/gradebook_profilegraphs.html b/lms/templates/gradebook_profilegraphs.html deleted file mode 100644 index fc36c84fb8..0000000000 --- a/lms/templates/gradebook_profilegraphs.html +++ /dev/null @@ -1,31 +0,0 @@ -<%inherit file="main.html" /> -<%namespace name='static' file='static_content.html'/> -<%namespace name="profile_graphs" file="profile_graphs.js"/> - -<%block name="js_extra"> - - - - % for s in students: - - %endfor - - -<%include file="navigation.html" args="active_page=''" /> -
-
-
-

Gradebook

-
    - % for s in students: -
  1. -

    ${s['username']}

    -
    -
  2. - % endfor -
-
-
-
diff --git a/lms/templates/wiki/base.html b/lms/templates/wiki/base.html index 2c1943e2a5..d4428da466 100644 --- a/lms/templates/wiki/base.html +++ b/lms/templates/wiki/base.html @@ -47,7 +47,7 @@ {% block body %} {% if course %} - {% include "course_navigation.html" with active_page_context="wiki" %} + {% include "courseware/course_navigation.html" with active_page_context="wiki" %} {% endif %}
From 9bc5aec01a92e26a9db4f26c7bb9acc22a263a9b Mon Sep 17 00:00:00 2001 From: Bridger Maxwell Date: Mon, 20 Aug 2012 15:03:55 -0400 Subject: [PATCH 4/4] Fixed up courseware-error view. Moved it to templates/courseware too. --- lms/djangoapps/courseware/views.py | 5 +++-- lms/templates/{ => courseware}/courseware-error.html | 9 +++++++-- lms/templates/simplewiki/simplewiki_base.html | 2 +- lms/templates/staticbook.html | 2 +- 4 files changed, 12 insertions(+), 6 deletions(-) rename lms/templates/{ => courseware}/courseware-error.html (67%) diff --git a/lms/djangoapps/courseware/views.py b/lms/djangoapps/courseware/views.py index 314562aeb8..c5d99947dc 100644 --- a/lms/djangoapps/courseware/views.py +++ b/lms/djangoapps/courseware/views.py @@ -170,8 +170,9 @@ def index(request, course_id, chapter=None, section=None, position=position )) try: - result = render_to_response('courseware-error.html', - {'staff_access': staff_access}) + result = render_to_response('courseware/courseware-error.html', + {'staff_access': staff_access, + 'course' : course}) except: result = HttpResponse("There was an unrecoverable error") diff --git a/lms/templates/courseware-error.html b/lms/templates/courseware/courseware-error.html similarity index 67% rename from lms/templates/courseware-error.html rename to lms/templates/courseware/courseware-error.html index 3c26ae8aeb..169c7de8bc 100644 --- a/lms/templates/courseware-error.html +++ b/lms/templates/courseware/courseware-error.html @@ -1,8 +1,13 @@ -<%inherit file="main.html" /> +<%inherit file="/main.html" /> +<%namespace name='static' file='../static_content.html'/> <%block name="bodyclass">courseware <%block name="title">Courseware – edX -<%include file="course_navigation.html" args="active_page='courseware'" /> +<%block name="headextra"> + <%static:css group='course'/> + + +<%include file="/courseware/course_navigation.html" args="active_page='courseware'" />
diff --git a/lms/templates/simplewiki/simplewiki_base.html b/lms/templates/simplewiki/simplewiki_base.html index 8736f3e421..e19d8d61ca 100644 --- a/lms/templates/simplewiki/simplewiki_base.html +++ b/lms/templates/simplewiki/simplewiki_base.html @@ -79,7 +79,7 @@ <%block name="bodyextra"> %if course: -<%include file="../course_navigation.html" args="active_page='wiki'" /> +<%include file="/courseware/course_navigation.html" args="active_page='wiki'" /> %endif
diff --git a/lms/templates/staticbook.html b/lms/templates/staticbook.html index 2a0a6f03bb..f9d6ff109c 100644 --- a/lms/templates/staticbook.html +++ b/lms/templates/staticbook.html @@ -61,7 +61,7 @@ $("#open_close_accordion a").click(function(){ -<%include file="course_navigation.html" args="active_page='book'" /> +<%include file="/courseware/course_navigation.html" args="active_page='book'" />