Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add passthrough for context_title and context_label LTI parameters

Browse Source
This commit is contained in:
Eric Fischer
2018-04-18 12:28:07 -04:00
parent 38f5358541
commit 9b093ff17f
2 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
lms/djangoapps/lti_provider/tests/test_views.py
View File

@@ -28,6 +28,8 @@ LTI_DEFAULT_PARAMS = {
} }
LTI_OPTIONAL_PARAMS = { LTI_OPTIONAL_PARAMS = {
'context_title': u'context title',
'context_label': u'context label',
'lis_result_sourcedid': u'result sourcedid', 'lis_result_sourcedid': u'result sourcedid',
'lis_outcome_service_url': u'outcome service URL', 'lis_outcome_service_url': u'outcome service URL',
'tool_consumer_instance_guid': u'consumer instance guid' 'tool_consumer_instance_guid': u'consumer instance guid'
@@ -95,6 +97,21 @@ class LtiLaunchTest(LtiTestMixin, TestCase):
views.lti_launch(request, unicode(COURSE_KEY), unicode(USAGE_KEY)) views.lti_launch(request, unicode(COURSE_KEY), unicode(USAGE_KEY))
render.assert_called_with(request, USAGE_KEY) render.assert_called_with(request, USAGE_KEY)
@patch('lti_provider.views.render_courseware')
@patch('lti_provider.views.store_outcome_parameters')
@patch('lti_provider.views.authenticate_lti_user')
def test_valid_launch_with_optional_params(self, _authenticate, store_params, _render):
"""
Verifies that the LTI launch succeeds when passed a valid request.
"""
request = build_launch_request(extra_post_data=LTI_OPTIONAL_PARAMS)
views.lti_launch(request, unicode(COURSE_KEY), unicode(USAGE_KEY))
store_params.assert_called_with(
dict(ALL_PARAMS.items() + LTI_OPTIONAL_PARAMS.items()),
request.user,
self.consumer
)
@patch('lti_provider.views.render_courseware') @patch('lti_provider.views.render_courseware')
@patch('lti_provider.views.store_outcome_parameters') @patch('lti_provider.views.store_outcome_parameters')
@patch('lti_provider.views.authenticate_lti_user') @patch('lti_provider.views.authenticate_lti_user')

4
lms/djangoapps/lti_provider/views.py
View File

@@ -28,8 +28,8 @@ REQUIRED_PARAMETERS = [
] ]
OPTIONAL_PARAMETERS = [ OPTIONAL_PARAMETERS = [
'lis_result_sourcedid', 'lis_outcome_service_url', 'context_title', 'context_label', 'lis_result_sourcedid',
'tool_consumer_instance_guid' 'lis_outcome_service_url', 'tool_consumer_instance_guid'
] ]