diff --git a/lms/djangoapps/support/static/support/js/certificates_factory.js b/lms/djangoapps/support/static/support/js/certificates_factory.js index 753e4e1c5e..9f9c60fd95 100644 --- a/lms/djangoapps/support/static/support/js/certificates_factory.js +++ b/lms/djangoapps/support/static/support/js/certificates_factory.js @@ -1,9 +1,9 @@ -;(function (define) { +(function(define) { 'use strict'; define(['jquery', 'underscore', 'support/js/views/certificates'], - function ($, _, CertificatesView) { - return function (options) { + function($, _, CertificatesView) { + return function(options) { options = _.extend(options, { el: $('.certificates-content') }); diff --git a/lms/djangoapps/support/static/support/js/collections/certificate.js b/lms/djangoapps/support/static/support/js/collections/certificate.js index 4d2260ad30..d56236d167 100644 --- a/lms/djangoapps/support/static/support/js/collections/certificate.js +++ b/lms/djangoapps/support/static/support/js/collections/certificate.js @@ -1,4 +1,4 @@ -;(function (define) { +(function(define) { 'use strict'; define(['backbone', 'support/js/models/certificate'], function(Backbone, CertModel) { @@ -26,5 +26,5 @@ return url; } }); - }); + }); }).call(this, define || RequireJS.define); diff --git a/lms/djangoapps/support/static/support/js/collections/enrollment.js b/lms/djangoapps/support/static/support/js/collections/enrollment.js index 5a8491a02b..300c95df45 100644 --- a/lms/djangoapps/support/static/support/js/collections/enrollment.js +++ b/lms/djangoapps/support/static/support/js/collections/enrollment.js @@ -1,4 +1,4 @@ -;(function (define) { +(function(define) { 'use strict'; define(['backbone', 'support/js/models/enrollment'], function(Backbone, EnrollmentModel) { @@ -14,5 +14,5 @@ return this.baseUrl + this.user; } }); - }); + }); }).call(this, define || RequireJS.define); diff --git a/lms/djangoapps/support/static/support/js/enrollment_factory.js b/lms/djangoapps/support/static/support/js/enrollment_factory.js index 9e285b6b3b..202edf540c 100644 --- a/lms/djangoapps/support/static/support/js/enrollment_factory.js +++ b/lms/djangoapps/support/static/support/js/enrollment_factory.js @@ -1,11 +1,11 @@ -;(function (define) { +(function(define) { 'use strict'; define([ 'underscore', 'support/js/views/enrollment' - ], function (_, EnrollmentView) { - return function (options) { + ], function(_, EnrollmentView) { + return function(options) { options = _.extend({el: '.enrollment-content'}, options); return new EnrollmentView(options).render(); }; diff --git a/lms/djangoapps/support/static/support/js/models/certificate.js b/lms/djangoapps/support/static/support/js/models/certificate.js index 7cb7d02eda..da7322ff0a 100644 --- a/lms/djangoapps/support/static/support/js/models/certificate.js +++ b/lms/djangoapps/support/static/support/js/models/certificate.js @@ -1,6 +1,6 @@ -(function (define) { +(function(define) { 'use strict'; - define(['backbone'], function (Backbone) { + define(['backbone'], function(Backbone) { return Backbone.Model.extend({ defaults: { username: null, diff --git a/lms/djangoapps/support/static/support/js/models/enrollment.js b/lms/djangoapps/support/static/support/js/models/enrollment.js index 1fb8ead6a8..5bfa2f7d1b 100644 --- a/lms/djangoapps/support/static/support/js/models/enrollment.js +++ b/lms/djangoapps/support/static/support/js/models/enrollment.js @@ -1,8 +1,8 @@ -(function (define) { +(function(define) { 'use strict'; - define(['backbone', 'underscore'], function (Backbone, _) { + define(['backbone', 'underscore'], function(Backbone, _) { return Backbone.Model.extend({ - updateEnrollment: function (new_mode, reason) { + updateEnrollment: function(new_mode, reason) { return $.ajax({ url: this.url(), type: 'POST', @@ -13,7 +13,7 @@ old_mode: this.get('mode'), reason: reason }), - success: _.bind(function (response) { + success: _.bind(function(response) { this.set('manual_enrollment', response); this.set('mode', new_mode); }, this) diff --git a/lms/djangoapps/support/static/support/js/spec/collections/enrollment_spec.js b/lms/djangoapps/support/static/support/js/spec/collections/enrollment_spec.js index aaef20f179..fcb8db90bc 100644 --- a/lms/djangoapps/support/static/support/js/spec/collections/enrollment_spec.js +++ b/lms/djangoapps/support/static/support/js/spec/collections/enrollment_spec.js @@ -1,21 +1,21 @@ define([ 'edx-ui-toolkit/js/utils/spec-helpers/ajax-helpers', 'support/js/spec_helpers/enrollment_helpers', - 'support/js/collections/enrollment', -], function (AjaxHelpers, EnrollmentHelpers, EnrollmentCollection) { + 'support/js/collections/enrollment' +], function(AjaxHelpers, EnrollmentHelpers, EnrollmentCollection) { 'use strict'; - describe('EnrollmentCollection', function () { + describe('EnrollmentCollection', function() { var enrollmentCollection; - beforeEach(function () { + beforeEach(function() { enrollmentCollection = new EnrollmentCollection([EnrollmentHelpers.mockEnrollmentData], { user: 'test-user', baseUrl: '/support/enrollment/' }); }); - it('sets its URL based on the user', function () { + it('sets its URL based on the user', function() { expect(enrollmentCollection.url()).toEqual('/support/enrollment/test-user'); }); }); diff --git a/lms/djangoapps/support/static/support/js/spec/models/enrollment_spec.js b/lms/djangoapps/support/static/support/js/spec/models/enrollment_spec.js index cd280bd6e3..9f81994a78 100644 --- a/lms/djangoapps/support/static/support/js/spec/models/enrollment_spec.js +++ b/lms/djangoapps/support/static/support/js/spec/models/enrollment_spec.js @@ -2,20 +2,20 @@ define([ 'edx-ui-toolkit/js/utils/spec-helpers/ajax-helpers', 'support/js/spec_helpers/enrollment_helpers', 'support/js/models/enrollment' -], function (AjaxHelpers, EnrollmentHelpers, EnrollmentModel) { +], function(AjaxHelpers, EnrollmentHelpers, EnrollmentModel) { 'use strict'; - describe('EnrollmentModel', function () { + describe('EnrollmentModel', function() { var enrollment; - beforeEach(function () { + beforeEach(function() { enrollment = new EnrollmentModel(EnrollmentHelpers.mockEnrollmentData); - enrollment.url = function () { + enrollment.url = function() { return '/support/enrollment/test-user'; }; }); - it('can save an enrollment to the server and updates itself on success', function () { + it('can save an enrollment to the server and updates itself on success', function() { var requests = AjaxHelpers.requests(this), manual_enrollment = { 'enrolled_by': 'staff@edx.org', @@ -33,7 +33,7 @@ define([ expect(enrollment.get('manual_enrollment')).toEqual(manual_enrollment); }); - it('does not update itself on a server error', function () { + it('does not update itself on a server error', function() { var requests = AjaxHelpers.requests(this); enrollment.updateEnrollment('verified', 'Financial Assistance'); AjaxHelpers.respondWithError(requests, 500); diff --git a/lms/djangoapps/support/static/support/js/spec/views/certificates_spec.js b/lms/djangoapps/support/static/support/js/spec/views/certificates_spec.js index 7080d77944..87eee9f3ea 100644 --- a/lms/djangoapps/support/static/support/js/spec/views/certificates_spec.js +++ b/lms/djangoapps/support/static/support/js/spec/views/certificates_spec.js @@ -6,91 +6,90 @@ define([ 'use strict'; describe('CertificatesView', function() { - var view = null, - REGENERATE_SEARCH_RESULTS = [ - { - 'username': 'student', - 'status': 'notpassing', - 'created': '2015-08-05T17:32:25+00:00', - 'grade': '0.0', - 'type': 'honor', - 'course_key': 'course-v1:edX+DemoX+Demo_Course', - 'download_url': null, - 'modified': '2015-08-06T19:47:07+00:00', - 'regenerate': true - }, - { - 'username': 'student', - 'status': 'downloadable', - 'created': '2015-08-05T17:53:33+00:00', - 'grade': '1.0', - 'type': 'verified', - 'course_key': 'edx/test/2015', - 'download_url': 'http://www.example.com/certificate.pdf', - 'modified': '2015-08-06T19:47:05+00:00', - 'regenerate': true - } - ], + REGENERATE_SEARCH_RESULTS = [ + { + 'username': 'student', + 'status': 'notpassing', + 'created': '2015-08-05T17:32:25+00:00', + 'grade': '0.0', + 'type': 'honor', + 'course_key': 'course-v1:edX+DemoX+Demo_Course', + 'download_url': null, + 'modified': '2015-08-06T19:47:07+00:00', + 'regenerate': true + }, + { + 'username': 'student', + 'status': 'downloadable', + 'created': '2015-08-05T17:53:33+00:00', + 'grade': '1.0', + 'type': 'verified', + 'course_key': 'edx/test/2015', + 'download_url': 'http://www.example.com/certificate.pdf', + 'modified': '2015-08-06T19:47:05+00:00', + 'regenerate': true + } + ], - GENERATE_SEARCH_RESULTS = [ - { - 'username': 'student', - 'status': '', - 'created': '', - 'grade': '', - 'type': '', - 'course_key': 'edx/test1/2016', - 'download_url': null, - 'modified': '', - 'regenerate': false - } - ], + GENERATE_SEARCH_RESULTS = [ + { + 'username': 'student', + 'status': '', + 'created': '', + 'grade': '', + 'type': '', + 'course_key': 'edx/test1/2016', + 'download_url': null, + 'modified': '', + 'regenerate': false + } + ], - getSearchResults = function() { - var results = []; + getSearchResults = function() { + var results = []; - $('.certificates-results tr').each(function(rowIndex, rowValue) { - var columns = []; - $(rowValue).children('td').each(function(colIndex, colValue) { - columns[colIndex] = $(colValue).html(); + $('.certificates-results tr').each(function(rowIndex, rowValue) { + var columns = []; + $(rowValue).children('td').each(function(colIndex, colValue) { + columns[colIndex] = $(colValue).html(); + }); + + if (columns.length > 0) { + results.push(columns); + } }); - if (columns.length > 0) { - results.push(columns); - } - }); + return results; + }, - return results; - }, - - searchFor = function(user_filter, course_filter, requests, response) { + searchFor = function(user_filter, course_filter, requests, response) { // Enter the search term and submit - var url = '/certificates/search?user=' + user_filter; - view.setUserFilter(user_filter); - if (course_filter) { - view.setCourseFilter(course_filter); - url += '&course_id=' + course_filter; - } - view.triggerSearch(); + var url = '/certificates/search?user=' + user_filter; + view.setUserFilter(user_filter); + if (course_filter) { + view.setCourseFilter(course_filter); + url += '&course_id=' + course_filter; + } + view.triggerSearch(); // Simulate a response from the server - AjaxHelpers.expectJsonRequest(requests, 'GET', url); - AjaxHelpers.respondWithJson(requests, response); - }, + AjaxHelpers.expectJsonRequest(requests, 'GET', url); + AjaxHelpers.respondWithJson(requests, response); + }, - regenerateCerts = function(username, courseKey) { - var sel = '.btn-cert-regenerate[data-course-key="' + courseKey + '"]'; - $(sel).click(); - }, + regenerateCerts = function(username, courseKey) { + var sel = '.btn-cert-regenerate[data-course-key="' + courseKey + '"]'; + $(sel).click(); + }, - generateCerts = function(username, courseKey) { - var sel = '.btn-cert-generate[data-course-key="' + courseKey + '"]'; - $(sel).click(); - }; + generateCerts = function(username, courseKey) { + var sel = '.btn-cert-generate[data-course-key="' + courseKey + '"]'; + $(sel).click(); + }; - beforeEach(function () { + beforeEach(function() { spyOn(window.history, 'pushState'); setFixtures('
'); view = new CertificatesView({ @@ -142,7 +141,6 @@ define([ expect(results[0][3]).toContain('Not available'); expect(results[0][4]).toEqual(GENERATE_SEARCH_RESULTS[0].grade); expect(results[0][5]).toEqual(GENERATE_SEARCH_RESULTS[0].modified); - }); it('searches for certificates and displays a message when there are no results', function() { @@ -201,7 +199,7 @@ define([ AjaxHelpers.respondWithJson(requests, ''); }); - it('generate a certificate for a student', function() { + it('generate a certificate for a student', function() { var requests = AjaxHelpers.requests(this); // Trigger a search @@ -223,6 +221,5 @@ define([ // Respond with success AjaxHelpers.respondWithJson(requests, ''); }); - }); }); diff --git a/lms/djangoapps/support/static/support/js/spec/views/enrollment_modal_spec.js b/lms/djangoapps/support/static/support/js/spec/views/enrollment_modal_spec.js index 8411babf9f..f942d43764 100644 --- a/lms/djangoapps/support/static/support/js/spec/views/enrollment_modal_spec.js +++ b/lms/djangoapps/support/static/support/js/spec/views/enrollment_modal_spec.js @@ -4,16 +4,15 @@ define([ 'support/js/spec_helpers/enrollment_helpers', 'support/js/models/enrollment', 'support/js/views/enrollment_modal' -], function (_, AjaxHelpers, EnrollmentHelpers, EnrollmentModel, EnrollmentModal) { +], function(_, AjaxHelpers, EnrollmentHelpers, EnrollmentModel, EnrollmentModal) { 'use strict'; - describe('EnrollmentModal', function () { - + describe('EnrollmentModal', function() { var modal; - beforeEach(function () { + beforeEach(function() { var enrollment = new EnrollmentModel(EnrollmentHelpers.mockEnrollmentData); - enrollment.url = function () { + enrollment.url = function() { return '/support/enrollment/test-user'; }; setFixtures(''); @@ -23,53 +22,53 @@ define([ modes: ['verified', 'audit'], reasons: _.reduce( ['Financial Assistance', 'Stampeding Buffalo', 'Angry Customer'], - function (acc, x) { acc[x] = x; return acc; }, + function(acc, x) { acc[x] = x; return acc; }, {} ) }).render(); }); - it('can render itself', function () { + it('can render itself', function() { expect($('.enrollment-modal h1').text()).toContain( 'Change enrollment for ' + EnrollmentHelpers.TEST_COURSE ); expect($('.enrollment-change-field p').first().text()).toContain('Current enrollment mode: audit'); - _.each(['verified', 'audit'], function (mode) { + _.each(['verified', 'audit'], function(mode) { expect($('.enrollment-new-mode').html()).toContain('