From 9968622c582b455221a19dbe98f4f0778401c488 Mon Sep 17 00:00:00 2001 From: cahrens Date: Wed, 21 Oct 2015 16:15:11 -0400 Subject: [PATCH] Use waits because MathJax rendering is asynchronous. TNL-2419 --- .../acceptance/tests/discussion/test_discussion.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/common/test/acceptance/tests/discussion/test_discussion.py b/common/test/acceptance/tests/discussion/test_discussion.py index 7b31c14f5c..be9f6b0aa4 100644 --- a/common/test/acceptance/tests/discussion/test_discussion.py +++ b/common/test/acceptance/tests/discussion/test_discussion.py @@ -6,7 +6,6 @@ import datetime from pytz import UTC from uuid import uuid4 from nose.plugins.attrib import attr -from flaky import flaky from .helpers import BaseDiscussionTestCase from ..helpers import UniqueCourseTest @@ -218,7 +217,6 @@ class DiscussionTabSingleThreadTest(BaseDiscussionTestCase, DiscussionResponsePa self.thread_page = self.create_single_thread_page(thread_id) # pylint: disable=attribute-defined-outside-init self.thread_page.visit() - @flaky # TODO fix this, see TNL-2419 def test_mathjax_rendering(self): thread_id = "test_thread_{}".format(uuid4().hex) @@ -233,8 +231,14 @@ class DiscussionTabSingleThreadTest(BaseDiscussionTestCase, DiscussionResponsePa thread_fixture.push() self.setup_thread_page(thread_id) self.assertTrue(self.thread_page.is_discussion_body_visible()) - self.assertTrue(self.thread_page.is_mathjax_preview_available()) - self.assertTrue(self.thread_page.is_mathjax_rendered()) + self.thread_page.wait_for( + self.thread_page.is_mathjax_preview_available, + description="MathJax Preview is rendered" + ) + self.thread_page.wait_for( + self.thread_page.is_mathjax_rendered, + description="MathJax is rendered" + ) def test_markdown_reference_link(self): """