From 443034ed5589a19e3a22a23605c1b804c98ba995 Mon Sep 17 00:00:00 2001 From: uzairr Date: Tue, 7 Dec 2021 17:59:31 +0500 Subject: [PATCH] refactor: add a property to distinguish old and new users Add a new prop in existing props to differentiate users either a particular one is newly registered or not. VAN-665 --- openedx/core/djangoapps/user_authn/tasks.py | 3 ++- openedx/core/djangoapps/user_authn/views/register.py | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/openedx/core/djangoapps/user_authn/tasks.py b/openedx/core/djangoapps/user_authn/tasks.py index 4974d226b5..4c39085bfd 100644 --- a/openedx/core/djangoapps/user_authn/tasks.py +++ b/openedx/core/djangoapps/user_authn/tasks.py @@ -24,7 +24,7 @@ log = logging.getLogger('edx.celery.task') @shared_task @set_code_owner_attribute -def check_pwned_password_and_send_track_event(user_id, password, internal_user=False): +def check_pwned_password_and_send_track_event(user_id, password, internal_user=False, is_new_user=False): """ Check the Pwned Databases and send its event to Segment. """ @@ -32,6 +32,7 @@ def check_pwned_password_and_send_track_event(user_id, password, internal_user=F pwned_properties = check_pwned_password(password) if pwned_properties: pwned_properties['internal_user'] = internal_user + pwned_properties['new_user'] = is_new_user segment.track(user_id, 'edx.bi.user.pwned.password.status', pwned_properties) except Exception: # pylint: disable=W0703 log.exception( diff --git a/openedx/core/djangoapps/user_authn/views/register.py b/openedx/core/djangoapps/user_authn/views/register.py index c32534908f..4b2221644b 100644 --- a/openedx/core/djangoapps/user_authn/views/register.py +++ b/openedx/core/djangoapps/user_authn/views/register.py @@ -292,7 +292,7 @@ def create_account_with_params(request, params): # pylint: disable=too-many-sta def is_new_user(password, user): if user is not None: AUDIT_LOG.info(f"Login success on new account creation - {user.username}") - check_pwned_password_and_send_track_event.delay(user.id, password, user.is_staff) + check_pwned_password_and_send_track_event.delay(user.id, password, user.is_staff, True) def _link_user_to_third_party_provider(