From 94faa6b8368fcd649d6fc0420cec07e1938f4695 Mon Sep 17 00:00:00 2001 From: louyihua Date: Wed, 2 Jul 2014 20:59:18 +0800 Subject: [PATCH] Misuse of 'gettext' into mako templates To translate strings in mako templates, the pattern of ```${_()}``` should be used instead of ```gettext``` even if the strings to be translated is located in a ```script``` block. --- cms/templates/settings_advanced.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cms/templates/settings_advanced.html b/cms/templates/settings_advanced.html index 3ed9146680..0bd9ed36e9 100644 --- a/cms/templates/settings_advanced.html +++ b/cms/templates/settings_advanced.html @@ -40,12 +40,12 @@ require(["domReady!", "jquery", "gettext", "js/models/settings/advanced", "js/vi var deprecatedSettingsLabel = $('.deprecated-settings-label'); if ($this.is(':checked')) { wrapperDeprecatedSetting.addClass('is-set'); - deprecatedSettingsLabel.text(gettext('Hide Deprecated Settings')); + deprecatedSettingsLabel.text('${_('Hide Deprecated Settings')}'); editor.render_deprecated = true; } else { wrapperDeprecatedSetting.removeClass('is-set'); - deprecatedSettingsLabel.text(gettext('Show Deprecated Settings')); + deprecatedSettingsLabel.text('${_('Show Deprecated Settings')}'); editor.render_deprecated = false; }