From 91acd3a26f851ed5b689c08ed414e9ca1f4615c9 Mon Sep 17 00:00:00 2001
From: Rodrigo Martin
Date: Tue, 11 Mar 2025 12:07:29 -0300
Subject: [PATCH] feat: Update link styling (#36348)
---
.../instructor/tests/views/test_instructor_dashboard.py | 3 ++-
lms/static/js/instructor_dashboard/util.js | 2 +-
.../instructor_dashboard_2/instructor_analytics.html | 2 +-
.../instructor/instructor_dashboard_2/send_email.html | 2 +-
4 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/lms/djangoapps/instructor/tests/views/test_instructor_dashboard.py b/lms/djangoapps/instructor/tests/views/test_instructor_dashboard.py
index 400e9b5562..e48098b9ef 100644
--- a/lms/djangoapps/instructor/tests/views/test_instructor_dashboard.py
+++ b/lms/djangoapps/instructor/tests/views/test_instructor_dashboard.py
@@ -103,7 +103,8 @@ class TestInstructorDashboard(ModuleStoreTestCase, LoginEnrollmentTestCase, XssT
Returns expected dashboard demographic message with link to Insights.
"""
return 'For analytics about your course, go to Example.'.format(str(self.course.id))
+ 'rel="noopener" target="_blank">ExampleOpens in a new tab' \
+ '.'.format(str(self.course.id))
def test_instructor_tab(self):
"""
diff --git a/lms/static/js/instructor_dashboard/util.js b/lms/static/js/instructor_dashboard/util.js
index 8e39f4d03e..4e24c44c77 100644
--- a/lms/static/js/instructor_dashboard/util.js
+++ b/lms/static/js/instructor_dashboard/util.js
@@ -507,7 +507,7 @@
return edx.HtmlUtils.joinHtml(edx.HtmlUtils.HTML(
''), dataContext.name,
- edx.HtmlUtils.HTML(''));
+ edx.HtmlUtils.HTML('Opens in a new tab'));
}
}
];
diff --git a/lms/templates/instructor/instructor_dashboard_2/instructor_analytics.html b/lms/templates/instructor/instructor_dashboard_2/instructor_analytics.html
index bef5d2b0ba..772b3066fd 100644
--- a/lms/templates/instructor/instructor_dashboard_2/instructor_analytics.html
+++ b/lms/templates/instructor/instructor_dashboard_2/instructor_analytics.html
@@ -18,7 +18,7 @@ from openedx.core.djangolib.markup import HTML, Text
))
),
analytics_dashboard_name=settings.ANALYTICS_DASHBOARD_NAME,
- link_end=HTML('')
+ link_end=HTML('Opens in a new tab')
)}
diff --git a/lms/templates/instructor/instructor_dashboard_2/send_email.html b/lms/templates/instructor/instructor_dashboard_2/send_email.html
index 4550b7e76a..771079b8df 100644
--- a/lms/templates/instructor/instructor_dashboard_2/send_email.html
+++ b/lms/templates/instructor/instructor_dashboard_2/send_email.html
@@ -10,7 +10,7 @@ from openedx.core.djangolib.markup import HTML, Text
%if 'communications_mfe_url' in section_data:
- ${_("To use the email tool, visit the")} ${_("new experience")}.
+ ${_("To use the email tool, visit the")} ${_("new experience")}${Text(_("Opens in a new tab"))}.
%else: