From 8d6df18357decce4728467654b959686ed545b27 Mon Sep 17 00:00:00 2001 From: Davorin Sego Date: Wed, 22 Jul 2015 12:13:49 +0200 Subject: [PATCH] Course discovery UI improvements --- lms/djangoapps/branding/tests/test_page.py | 4 +- lms/static/js/discovery/collection.js | 6 +- .../js/discovery/collections/filters.js | 18 + lms/static/js/discovery/discovery_factory.js | 110 ++-- lms/static/js/discovery/filter_bar_view.js | 119 ---- lms/static/js/discovery/filters.js | 30 - .../{result.js => models/course_card.js} | 0 .../js/discovery/models/course_discovery.js | 65 ++ .../js/discovery/models/facet_option.js | 18 + .../js/discovery/{ => models}/filter.js | 8 +- .../js/discovery/models/search_state.js | 151 +++++ lms/static/js/discovery/search_facets_view.js | 127 ---- .../course_card.js} | 2 +- .../courses_listing.js} | 35 +- .../{facet_view.js => views/facet.js} | 0 .../{facets_view.js => views/facets.js} | 0 lms/static/js/discovery/views/filter_bar.js | 78 +++ .../{filter_view.js => views/filter_label.js} | 16 +- .../js/discovery/views/refine_sidebar.js | 99 +++ .../{form.js => views/search_form.js} | 10 +- lms/static/js/fixtures/discovery.html | 12 +- .../discovery/collections/filters_spec.js | 22 + .../spec/discovery/discovery_factory_spec.js | 195 ++++++ .../js/spec/discovery/discovery_spec.js | 603 ------------------ .../spec/discovery/models/course_card_spec.js | 28 + .../discovery/models/course_directory_spec.js | 101 +++ .../discovery/models/facet_option_spec.js | 19 + .../js/spec/discovery/models/filter_spec.js | 16 + .../discovery/models/search_state_spec.js | 90 +++ .../spec/discovery/views/course_card_spec.js | 56 ++ .../discovery/views/courses_listing_spec.js | 76 +++ .../spec/discovery/views/filter_bar_spec.js | 53 ++ .../spec/discovery/views/filter_label_spec.js | 40 ++ .../discovery/views/refine_sidebar_spec.js | 77 +++ .../spec/discovery/views/search_form_spec.js | 53 ++ lms/static/js/spec/main.js | 13 +- lms/static/sass/multicourse/_courses.scss | 92 ++- lms/templates/courseware/courses.html | 9 +- ...item.underscore => course_card.underscore} | 0 lms/templates/discovery/facet.underscore | 16 + .../discovery/facet_option.underscore | 8 + lms/templates/discovery/filter_bar.underscore | 9 +- .../discovery/more_less_links.underscore | 8 - .../discovery/search_facet.underscore | 6 - .../discovery/search_facets_list.underscore | 5 - .../search_facets_section.underscore | 5 - 46 files changed, 1467 insertions(+), 1041 deletions(-) create mode 100644 lms/static/js/discovery/collections/filters.js delete mode 100644 lms/static/js/discovery/filter_bar_view.js delete mode 100644 lms/static/js/discovery/filters.js rename lms/static/js/discovery/{result.js => models/course_card.js} (100%) create mode 100644 lms/static/js/discovery/models/course_discovery.js create mode 100644 lms/static/js/discovery/models/facet_option.js rename lms/static/js/discovery/{ => models}/filter.js (66%) create mode 100644 lms/static/js/discovery/models/search_state.js delete mode 100644 lms/static/js/discovery/search_facets_view.js rename lms/static/js/discovery/{result_item_view.js => views/course_card.js} (96%) rename lms/static/js/discovery/{result_list_view.js => views/courses_listing.js} (59%) rename lms/static/js/discovery/{facet_view.js => views/facet.js} (100%) rename lms/static/js/discovery/{facets_view.js => views/facets.js} (100%) create mode 100644 lms/static/js/discovery/views/filter_bar.js rename lms/static/js/discovery/{filter_view.js => views/filter_label.js} (60%) create mode 100644 lms/static/js/discovery/views/refine_sidebar.js rename lms/static/js/discovery/{form.js => views/search_form.js} (88%) create mode 100644 lms/static/js/spec/discovery/collections/filters_spec.js create mode 100644 lms/static/js/spec/discovery/discovery_factory_spec.js delete mode 100644 lms/static/js/spec/discovery/discovery_spec.js create mode 100644 lms/static/js/spec/discovery/models/course_card_spec.js create mode 100644 lms/static/js/spec/discovery/models/course_directory_spec.js create mode 100644 lms/static/js/spec/discovery/models/facet_option_spec.js create mode 100644 lms/static/js/spec/discovery/models/filter_spec.js create mode 100644 lms/static/js/spec/discovery/models/search_state_spec.js create mode 100644 lms/static/js/spec/discovery/views/course_card_spec.js create mode 100644 lms/static/js/spec/discovery/views/courses_listing_spec.js create mode 100644 lms/static/js/spec/discovery/views/filter_bar_spec.js create mode 100644 lms/static/js/spec/discovery/views/filter_label_spec.js create mode 100644 lms/static/js/spec/discovery/views/refine_sidebar_spec.js create mode 100644 lms/static/js/spec/discovery/views/search_form_spec.js rename lms/templates/discovery/{result_item.underscore => course_card.underscore} (100%) create mode 100644 lms/templates/discovery/facet.underscore create mode 100644 lms/templates/discovery/facet_option.underscore delete mode 100644 lms/templates/discovery/more_less_links.underscore delete mode 100644 lms/templates/discovery/search_facet.underscore delete mode 100644 lms/templates/discovery/search_facets_list.underscore delete mode 100644 lms/templates/discovery/search_facets_section.underscore diff --git a/lms/djangoapps/branding/tests/test_page.py b/lms/djangoapps/branding/tests/test_page.py index 4b3c725a8c..5ab6ce288a 100644 --- a/lms/djangoapps/branding/tests/test_page.py +++ b/lms/djangoapps/branding/tests/test_page.py @@ -217,7 +217,7 @@ class IndexPageCourseCardsSortingTests(ModuleStoreTestCase): # assert that the course discovery UI is not present self.assertNotIn('Search for a course', response.content) - self.assertNotIn('