From 8cef4f42214d3b0a8d9dc55c6d4aa3866b74f42c Mon Sep 17 00:00:00 2001 From: Prem Sichanugrist Date: Thu, 5 Jul 2012 15:25:37 -0400 Subject: [PATCH] Pass in the model into the view when create it --- cms/static/coffee/src/views/module.coffee | 5 +---- cms/static/coffee/src/views/module_edit.coffee | 7 +++---- cms/static/coffee/src/views/week.coffee | 3 +-- 3 files changed, 5 insertions(+), 10 deletions(-) diff --git a/cms/static/coffee/src/views/module.coffee b/cms/static/coffee/src/views/module.coffee index 63ecabe835..e8d7fd68ee 100644 --- a/cms/static/coffee/src/views/module.coffee +++ b/cms/static/coffee/src/views/module.coffee @@ -2,8 +2,5 @@ class CMS.Views.Module extends Backbone.View events: "click .module-edit": "edit" - initialize: -> - @model = new CMS.Models.Module(id: @$el.data('id'), type: @$el.data('type')) - edit: => - CMS.replaceView(new CMS.Views.ModuleEdit(model: @model)) + CMS.replaceView(new CMS.Views.ModuleEdit(model: new CMS.Models.Module(id: @$el.data('id'), type: @$el.data('type')))) diff --git a/cms/static/coffee/src/views/module_edit.coffee b/cms/static/coffee/src/views/module_edit.coffee index 7611d75fa4..987595ef23 100644 --- a/cms/static/coffee/src/views/module_edit.coffee +++ b/cms/static/coffee/src/views/module_edit.coffee @@ -19,7 +19,6 @@ class CMS.Views.ModuleEdit extends Backbone.View cancel: -> CMS.popView() - editSubmodule: (event) => - $el = $(event.target) - model = new CMS.Models.Module(id: $el.data('id'), type: $el.data('type')) - CMS.pushView(new CMS.Views.ModuleEdit(model: model)) + editSubmodule: (event) -> + event.preventDefault() + CMS.pushView(new CMS.Views.ModuleEdit(model: new CMS.Models.Module(id: $(event.target).data('id'), type: $(event.target).data('type')))) diff --git a/cms/static/coffee/src/views/week.coffee b/cms/static/coffee/src/views/week.coffee index f81a76c369..d1ed4cc6c4 100644 --- a/cms/static/coffee/src/views/week.coffee +++ b/cms/static/coffee/src/views/week.coffee @@ -3,7 +3,6 @@ class CMS.Views.Week extends Backbone.View 'click .week-edit': 'edit' initialize: -> - @model = new CMS.Models.Week(id: @$el.data('id')) @setHeight() @$('.editable').inlineEdit() @$('.editable-textarea').inlineEdit(control: 'textarea') @@ -15,7 +14,7 @@ class CMS.Views.Week extends Backbone.View CMS.on('content.hide', @setHeight) edit: => - CMS.replaceView(new CMS.Views.WeekEdit(model: @model)) + CMS.replaceView(new CMS.Views.WeekEdit(model: new CMS.Models.Week(id: @$el.data('id')))) setHeight: => @$el.height(@options.height)