Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat!: removes deprecated v1 certificate behavior (#35562)

Browse Source 
* feat!: removes deprecated v1 certificate behavior

this removes the long-deprecated v1  certificate behavior. This removes
the old-style date selection behavior  (ie., not a choice between
*Immediately upon passing*, *End date of course*, *A date after the course
end date*), which is no longer reliably maintained or supported in
Studio or Credentials.

FIXES: #35399
This commit is contained in:
Deborah Kaplan
2024-10-02 12:06:57 -04:00
committed by GitHub
parent 761bc5d159
commit 8c923bea24
18 changed files with 89 additions and 270 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
openedx/core/djangoapps/models/course_details.py
View File

@@ -371,10 +371,6 @@ class CourseDetails:
tuple[str, str]: updated certificate_available_date, updated certificates_display_behavior
None
"""
# If V2 is not enable, return original values
if not settings.FEATURES.get("ENABLE_V2_CERT_DISPLAY_SETTINGS", False):
return (certificate_available_date, certificates_display_behavior)
# "early_no_info" will always show regardless of settings
if certificates_display_behavior == CertificatesDisplayBehaviors.EARLY_NO_INFO:
return (None, CertificatesDisplayBehaviors.EARLY_NO_INFO)

26
openedx/core/djangoapps/models/tests/test_course_details.py
View File

@@ -8,7 +8,6 @@ from django.test import override_settings
import pytest
import ddt
from pytz import UTC
from unittest.mock import patch # lint-amnesty, pylint: disable=wrong-import-order
from django.conf import settings
from xmodule.modulestore import ModuleStoreEnum
@@ -212,30 +211,7 @@ class CourseDetailsTestCase(ModuleStoreTestCase):
),
)
@ddt.unpack
@patch.dict(settings.FEATURES, ENABLE_V2_CERT_DISPLAY_SETTINGS=True)
def test_validate_certificate_settings_v2(self, stored_date, stored_behavior, expected_date, expected_behavior):
assert CourseDetails.validate_certificate_settings(
stored_date, stored_behavior
) == (expected_date, expected_behavior)
@ddt.data(
(
EXAMPLE_CERTIFICATE_AVAILABLE_DATE,
CertificatesDisplayBehaviors.END_WITH_DATE,
EXAMPLE_CERTIFICATE_AVAILABLE_DATE,
CertificatesDisplayBehaviors.END_WITH_DATE
),
(
None,
"invalid_option",
None,
"invalid_option"
),
)
@ddt.unpack
@patch.dict(settings.FEATURES, ENABLE_V2_CERT_DISPLAY_SETTINGS=False)
def test_validate_certificate_settings_v1(self, stored_date, stored_behavior, expected_date, expected_behavior):
"""Test that method just returns passed in arguments if v2 is off"""
def test_validate_certificate_settings(self, stored_date, stored_behavior, expected_date, expected_behavior):
assert CourseDetails.validate_certificate_settings(
stored_date, stored_behavior
) == (expected_date, expected_behavior)