From 03c344f0059ef2f77288db5ece7ecdd80bf8c96b Mon Sep 17 00:00:00 2001 From: Shadi Naif Date: Thu, 11 Jun 2020 18:40:33 +0300 Subject: [PATCH 1/2] Remove unused InstructorAnalytics from JS file --- lms/static/js/instructor_dashboard/instructor_dashboard.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/lms/static/js/instructor_dashboard/instructor_dashboard.js b/lms/static/js/instructor_dashboard/instructor_dashboard.js index c58e7610e9..2559e72203 100644 --- a/lms/static/js/instructor_dashboard/instructor_dashboard.js +++ b/lms/static/js/instructor_dashboard/instructor_dashboard.js @@ -178,9 +178,6 @@ such that the value can be defined later than this assignment (file load order). }, { constructor: window.InstructorDashboard.sections.Email, $element: idashContent.find('.' + CSS_IDASH_SECTION + '#send_email') - }, { - constructor: window.InstructorDashboard.sections.InstructorAnalytics, - $element: idashContent.find('.' + CSS_IDASH_SECTION + '#instructor_analytics') }, { constructor: window.InstructorDashboard.sections.Metrics, $element: idashContent.find('.' + CSS_IDASH_SECTION + '#metrics') From 6c65e10826a79f58d1565058349be9a58a7d1090 Mon Sep 17 00:00:00 2001 From: Shadi Naif Date: Thu, 11 Jun 2020 19:07:42 +0300 Subject: [PATCH 2/2] Avoid processing unavailable tabs in instructor dashboard --- lms/static/js/instructor_dashboard/instructor_dashboard.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lms/static/js/instructor_dashboard/instructor_dashboard.js b/lms/static/js/instructor_dashboard/instructor_dashboard.js index 2559e72203..b613267643 100644 --- a/lms/static/js/instructor_dashboard/instructor_dashboard.js +++ b/lms/static/js/instructor_dashboard/instructor_dashboard.js @@ -214,7 +214,11 @@ such that the value can be defined later than this assignment (file load order). constructor = _arg.constructor; $element = _arg.$element; return plantTimeout(0, sectionsHaveLoaded.waitFor(function() { - return new constructor($element); + if ($element[0]) { + return new constructor($element); + } else { + return null; + } })); }); };